yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2026-01-07 04:56:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): notify auth provider for login failed event (#6484)

Browse Source
This commit is contained in:
Chirag Madlani 2022-08-01 20:17:26 +05:30 committed by GitHub
parent f276a65612
commit cc2dcefa6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openmetadata-ui/src/main/resources/ui/src/authentication/auth-provider/AuthProvider.tsx
View File

@ -557,6 +557,7 @@ export const AuthProvider = ({
<MsalProvider instance={msalInstance}>
<MsalAuthenticator
ref={authenticatorRef}
onLoginFailure={handleFailedLogin}
onLoginSuccess={handleSuccessfulLogin}
onLogoutSuccess={handleSuccessfulLogout}>
{children}

2
openmetadata-ui/src/main/resources/ui/src/authentication/authenticators/MsalAuthenticator.test.tsx
View File

@ -30,10 +30,12 @@ describe('Test MsalAuthenticator component', () => {
it('Checks if the MsalAuthenticator renders', async () => {
const onLogoutMock = jest.fn();
const onLoginMock = jest.fn();
const onFailedLoginMock = jest.fn();
const authenticatorRef = null;
render(
<MsalAuthenticator
ref={authenticatorRef}
onLoginFailure={onFailedLoginMock}
onLoginSuccess={onLoginMock}
onLogoutSuccess={onLogoutMock}>
<p data-testid="children" />

8
openmetadata-ui/src/main/resources/ui/src/authentication/authenticators/MsalAuthenticator.tsx
View File

@ -13,6 +13,7 @@
import { InteractionStatus } from '@azure/msal-browser';
import { useAccount, useIsAuthenticated, useMsal } from '@azure/msal-react';
import { AxiosError } from 'axios';
import React, {
forwardRef,
Fragment,
@ -32,11 +33,15 @@ import {
interface Props {
children: ReactNode;
onLoginSuccess: (user: OidcUser) => void;
onLoginFailure: (error: AxiosError) => void;
onLogoutSuccess: () => void;
}
const MsalAuthenticator = forwardRef<AuthenticatorRef, Props>(
({ children, onLoginSuccess, onLogoutSuccess }: Props, ref) => {
(
{ children, onLoginSuccess, onLogoutSuccess, onLoginFailure }: Props,
ref
) => {
const { setIsAuthenticated, loading, setLoadingIndicator } =
useAuthContext();
const { instance, accounts, inProgress } = useMsal();
@ -115,6 +120,7 @@ const MsalAuthenticator = forwardRef<AuthenticatorRef, Props>(
onLoginSuccess(user as OidcUser);
}
})
.catch(onLoginFailure)
.finally(() => {
if (loading) {
setLoadingIndicator(false);