diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less index 10ce94c6427..166a35be937 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/data-asset-header.less @@ -75,16 +75,22 @@ color: @primary-heading-color; max-width: 200px; } - .owner-label-container { + .owner-label-container, + .domain-label-container { max-width: 148px; } - .domain-link-text.render-domain-lebel-style { - color: @grey-700; - display: inline-block; - overflow: hidden; - text-overflow: ellipsis; - white-space: nowrap; + .domain-link-container { + //consistent width for data-asset-header max-width: 148px; + + .domain-link-text.render-domain-lebel-style { + color: @grey-700; + display: inline-block; + overflow: hidden; + text-overflow: ellipsis; + white-space: nowrap; + max-width: 148px; + } } a.source-url-link { text-decoration: none; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsVersionHeader/DataAssetsVersionHeader.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsVersionHeader/DataAssetsVersionHeader.tsx index e381c996c4a..dc08521d649 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsVersionHeader/DataAssetsVersionHeader.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsVersionHeader/DataAssetsVersionHeader.tsx @@ -26,6 +26,7 @@ import { getDataAssetsVersionHeaderInfo } from '../../../utils/DataAssetsVersion import serviceUtilClassBase from '../../../utils/ServiceUtilClassBase'; import TitleBreadcrumb from '../../common/TitleBreadcrumb/TitleBreadcrumb.component'; import { EntitiesWithDomainField } from '../DataAssetsHeader/DataAssetsHeader.interface'; +import './data-asset-version-header.less'; import { DataAssetsVersionHeaderProps } from './DataAssetsVersionHeader.interface'; function DataAssetsVersionHeader({ @@ -64,7 +65,10 @@ function DataAssetsVersionHeader({ }, [currentVersionData]); return ( - + @@ -80,7 +84,7 @@ function DataAssetsVersionHeader({ /> -
+
{entityType !== EntityType.METADATA_SERVICE && ( <> +
{headerLayout && (
= ({ ); retn = [domain]; } - await onSubmit(retn); - setIsSubmitLoading(false); + try { + await onSubmit(retn); + } finally { + setIsSubmitLoading(false); + } } else { onCancel(); } @@ -211,23 +214,25 @@ const DomainSelectablTree: FC = ({ ); } else { return ( - + } spinning={isSubmitLoading}> + + ); } }, [isLoading, treeData, value, onSelect, isMultiple, searchTerm]); @@ -238,6 +243,13 @@ const DomainSelectablTree: FC = ({ fetchAPI(); } }, [visible]); + const handleAllDomainKeyPress = (e: React.KeyboardEvent) => { + // To pass Sonar test + if (e.key === 'Enter' || e.key === ' ') { + e.preventDefault(); + handleMyDomainsClick(); + } + }; return (
@@ -259,7 +271,10 @@ const DomainSelectablTree: FC = ({ } )} data-testid="all-domains-selector" - onClick={handleMyDomainsClick}> + role="button" + tabIndex={0} + onClick={handleMyDomainsClick} + onKeyDown={handleAllDomainKeyPress}>