yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-31 20:51:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix tag page flaky playwright test (#19150)

Browse Source 
* fix tag page flaky playwright failures

* removed commented code
This commit is contained in:
Ashish Gupta 2024-12-31 17:12:15 +05:30 committed by GitHub
parent 24b668a642
commit ceeba2ad75
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openmetadata-ui/src/main/resources/ui/playwright/support/tag/TagClass.ts
View File

@ -66,6 +66,7 @@ export class TagClass {
async visitPage(page: Page) { async visitPage(page: Page) {
await visitClassificationPage( await visitClassificationPage(
page, page,
this.responseData.classification.name,
this.responseData.classification.displayName this.responseData.classification.displayName
); );
await page.getByTestId(this.data.name).click(); await page.getByTestId(this.data.name).click();

15
openmetadata-ui/src/main/resources/ui/playwright/utils/tag.ts
View File

@ -39,23 +39,26 @@ export const TAG_INVALID_NAMES = {
export const visitClassificationPage = async ( export const visitClassificationPage = async (
page: Page, page: Page,
classificationName: string classificationName: string,
classificationDisplayName: string
) => { ) => {
await redirectToHomePage(page); await redirectToHomePage(page);
const classificationResponse = page.waitForResponse( const classificationResponse = page.waitForResponse(
'/api/v1/classifications?**' '/api/v1/classifications?**'
); );
const fetchTags = page.waitForResponse('/api/v1/tags?*parent=*'); const fetchTags = page.waitForResponse(
`/api/v1/tags?*parent=${classificationName}**`
);
await sidebarClick(page, SidebarItem.TAGS); await sidebarClick(page, SidebarItem.TAGS);
await classificationResponse; await classificationResponse;
await page await page
.locator(`[data-testid="side-panel-classification"]`) .getByTestId('data-summary-container')
.filter({ hasText: classificationName }) .getByText(classificationDisplayName)
.click(); .click();
await expect(page.locator('.activeCategory')).toContainText( await expect(page.locator('.activeCategory')).toContainText(
classificationName classificationDisplayName
); );
await fetchTags; await fetchTags;
@ -351,7 +354,7 @@ export const editTagPageDescription = async (page: Page, tag: TagClass) => {
}; };
export const verifyCertificationTagPageUI = async (page: Page) => { export const verifyCertificationTagPageUI = async (page: Page) => {
await visitClassificationPage(page, 'Certification'); await visitClassificationPage(page, 'Certification', 'Certification');
const res = page.waitForResponse(`/api/v1/tags/name/*`); const res = page.waitForResponse(`/api/v1/tags/name/*`);
await page.getByTestId('Gold').click(); await page.getByTestId('Gold').click();
await res; await res;