diff --git a/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamDetails.tsx b/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamDetails.tsx index 58cdb829ed2..f7781fbd6c2 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamDetails.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/TeamDetails/TeamDetails.tsx @@ -34,7 +34,6 @@ import { } from '../../generated/entity/teams/user'; import { useAuth } from '../../hooks/authHooks'; import { TeamDetailsProp } from '../../interface/teamsAndUsers.interface'; -import AddUsersModal from '../../pages/teams/AddUsersModal'; import UserCard from '../../pages/teams/UserCard'; import { hasEditAccess } from '../../utils/CommonUtils'; import { getInfoElements } from '../../utils/EntityUtils'; @@ -72,10 +71,7 @@ const TeamDetails = ({ descriptionHandler, handleTeamUsersSearchAction, teamUserPaginHandler, - isAddingUsers, handleJoinTeamClick, - getUniqueUserList, - addUsersToTeam, handleAddUser, removeUserFromTeam, }: TeamDetailsProp) => { @@ -524,27 +520,8 @@ const TeamDetails = ({ data-testid="header"> {getTeamHeading()}
- {isActionAllowed() && ( - - - - - - )} {!isAlreadyJoinedTeam(currentTeam.id) ? ( - currentTeam.isJoinable ? ( + currentTeam.isJoinable || hasAccess ? (
); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/TeamsAndUsers/TeamsAndUsers.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/TeamsAndUsers/TeamsAndUsers.component.tsx index ea1821a1b0f..713a0be265b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/TeamsAndUsers/TeamsAndUsers.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/TeamsAndUsers/TeamsAndUsers.component.tsx @@ -11,12 +11,17 @@ * limitations under the License. */ +import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; import { capitalize } from 'lodash'; import React from 'react'; +import { TITLE_FOR_NON_ADMIN_ACTION } from '../../constants/constants'; import { UserType } from '../../enums/user.enum'; import { TeamsAndUsersProps } from '../../interface/teamsAndUsers.interface'; +import AddUsersModal from '../../pages/teams/AddUsersModal'; import { getActiveCatClass, getCountBadge } from '../../utils/CommonUtils'; import { getActiveUsers } from '../../utils/TeamUtils'; +import { Button } from '../buttons/Button/Button'; +import NonAdminAction from '../common/non-admin-action/NonAdminAction'; import PageLayout from '../containers/PageLayout'; import Loader from '../Loader/Loader'; import TeamDetails from '../TeamDetails/TeamDetails'; @@ -85,8 +90,25 @@ const TeamsAndUsers = ({ return ( <>
-
+

Teams

+ {hasAccess && ( + + + + )}
{teams.map((team) => (
{hasAccess && (
-
+

All Users

+ {hasAccess && ( + + + + )}
{usersData.map((d) => (
{!isTeamVisible ? ( ) : ( )} + + {isAddingUsers && ( + handleAddUser(false)} + onSave={(data) => addUsersToTeam(data)} + /> + )} ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/UserDetails/UserDetails.tsx b/openmetadata-ui/src/main/resources/ui/src/components/UserDetails/UserDetails.tsx index 9c3957d12ea..2ace2f8e369 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/UserDetails/UserDetails.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/UserDetails/UserDetails.tsx @@ -14,15 +14,10 @@ import { isUndefined } from 'lodash'; import React, { useState } from 'react'; import { useHistory } from 'react-router-dom'; -import { - getUserPath, - TITLE_FOR_NON_ADMIN_ACTION, -} from '../../constants/constants'; +import { getUserPath } from '../../constants/constants'; import { EntityReference, User } from '../../generated/entity/teams/user'; import { getEntityName } from '../../utils/CommonUtils'; -import { Button } from '../buttons/Button/Button'; import ErrorPlaceHolder from '../common/error-with-placeholder/ErrorPlaceHolder'; -import NonAdminAction from '../common/non-admin-action/NonAdminAction'; import Searchbar from '../common/searchbar/Searchbar'; import Loader from '../Loader/Loader'; import ConfirmationModal from '../Modals/ConfirmationModal/ConfirmationModal'; @@ -34,7 +29,6 @@ type UserDetailsProps = { userSearchTerm: string; isUsersLoading: boolean; handleDeleteUser: (id: string) => void; - handleAddNewUser: () => void; }; interface DeleteUserInfo { @@ -48,7 +42,6 @@ const UserDetails = ({ isUsersLoading, handleDeleteUser, handleUserSearchTerm, - handleAddNewUser, }: UserDetailsProps) => { const history = useHistory(); const [deletingUser, setDeletingUser] = useState(); @@ -130,19 +123,6 @@ const UserDetails = ({ onSearch={handleUserSearchTerm} />
-
- - - -
{getUserCards()} diff --git a/openmetadata-ui/src/main/resources/ui/src/interface/teamsAndUsers.interface.ts b/openmetadata-ui/src/main/resources/ui/src/interface/teamsAndUsers.interface.ts index 35c342c52cc..c5a673fd220 100644 --- a/openmetadata-ui/src/main/resources/ui/src/interface/teamsAndUsers.interface.ts +++ b/openmetadata-ui/src/main/resources/ui/src/interface/teamsAndUsers.interface.ts @@ -104,9 +104,6 @@ export interface TeamDetailsProp { cursorValue: string | number, activePage?: number ) => void; - isAddingUsers: boolean; - getUniqueUserList: () => Array; - addUsersToTeam: (data: Array) => void; handleAddUser: (data: boolean) => void; removeUserFromTeam: (id: string) => Promise; handleJoinTeamClick: (id: string, data: Operation[]) => void;