From cf914dea94c5ab4729e839cf896b595be1230cde Mon Sep 17 00:00:00 2001 From: Ayush Shah Date: Tue, 23 Apr 2024 16:32:30 +0530 Subject: [PATCH] Fix Inspector (#15997) --- .../src/metadata/ingestion/source/database/hive/metadata.py | 4 ++-- .../metadata/ingestion/source/database/presto/metadata.py | 5 +++-- .../metadata/ingestion/source/database/saphana/metadata.py | 5 ++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/database/hive/metadata.py b/ingestion/src/metadata/ingestion/source/database/hive/metadata.py index 2b7f2894e0b..681ddd86f7f 100644 --- a/ingestion/src/metadata/ingestion/source/database/hive/metadata.py +++ b/ingestion/src/metadata/ingestion/source/database/hive/metadata.py @@ -15,7 +15,6 @@ Hive source methods. from typing import Optional, Tuple from pyhive.sqlalchemy_hive import HiveDialect -from sqlalchemy.inspection import inspect from metadata.generated.schema.entity.services.connections.database.hiveConnection import ( HiveConnection, @@ -95,4 +94,5 @@ class HiveSource(CommonDbSourceService): self.engine = get_metastore_connection( self.service_connection.metastoreConnection ) - self.inspector = inspect(self.engine) + self._connection_map = {} # Lazy init as well + self._inspector_map = {} diff --git a/ingestion/src/metadata/ingestion/source/database/presto/metadata.py b/ingestion/src/metadata/ingestion/source/database/presto/metadata.py index b9997bfb1ef..a171391c574 100644 --- a/ingestion/src/metadata/ingestion/source/database/presto/metadata.py +++ b/ingestion/src/metadata/ingestion/source/database/presto/metadata.py @@ -18,7 +18,7 @@ from copy import deepcopy from typing import Iterable, Optional from pyhive.sqlalchemy_presto import PrestoDialect, _type_map -from sqlalchemy import inspect, types, util +from sqlalchemy import types, util from sqlalchemy.engine import reflection from metadata.generated.schema.entity.data.database import Database @@ -140,7 +140,8 @@ class PrestoSource(CommonDbSourceService): new_service_connection = deepcopy(self.service_connection) new_service_connection.catalog = database_name self.engine = get_connection(new_service_connection) - self.inspector = inspect(self.engine) + self._connection_map = {} # Lazy init as well + self._inspector_map = {} def get_database_names(self) -> Iterable[str]: configured_catalog = self.service_connection.catalog diff --git a/ingestion/src/metadata/ingestion/source/database/saphana/metadata.py b/ingestion/src/metadata/ingestion/source/database/saphana/metadata.py index f8abf6ef28b..1e9632743c5 100644 --- a/ingestion/src/metadata/ingestion/source/database/saphana/metadata.py +++ b/ingestion/src/metadata/ingestion/source/database/saphana/metadata.py @@ -13,8 +13,6 @@ SAP Hana source module """ from typing import Iterable, Optional -from sqlalchemy import inspect - from metadata.generated.schema.entity.services.connections.database.sapHanaConnection import ( SapHanaConnection, ) @@ -51,7 +49,8 @@ class SaphanaSource(CommonDbSourceService): """ Check if the db is configured, or query the name """ - self.inspector = inspect(self.engine) + self._connection_map = {} # Lazy init as well + self._inspector_map = {} if getattr(self.service_connection.connection, "database"): yield self.service_connection.connection.database