mirror of
https://github.com/open-metadata/OpenMetadata.git
synced 2025-09-26 17:34:41 +00:00
Update pull_request_template.md
This commit is contained in:
parent
b8863648d6
commit
d00327dfba
7
.github/pull_request_template.md
vendored
7
.github/pull_request_template.md
vendored
@ -6,6 +6,7 @@ I worked on the ..... because ...
|
|||||||
### Type of change :
|
### Type of change :
|
||||||
<!-- You should choose 1 option and delete options that aren't relevant -->
|
<!-- You should choose 1 option and delete options that aren't relevant -->
|
||||||
- [x] Bug fix
|
- [x] Bug fix
|
||||||
|
- [x] Improvement
|
||||||
- [x] New feature
|
- [x] New feature
|
||||||
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
||||||
- [x] Documentation
|
- [x] Documentation
|
||||||
@ -18,13 +19,13 @@ I worked on the ..... because ...
|
|||||||
#
|
#
|
||||||
### Checklist:
|
### Checklist:
|
||||||
<!-- add an x in [] if done, don't mark items that you didn't do !-->
|
<!-- add an x in [] if done, don't mark items that you didn't do !-->
|
||||||
- [ ] I have read the [**CONTRIBUTING**](https://docs.open-metadata.org/open-source-community/developer) document.
|
- [x] I have read the [**CONTRIBUTING**](https://docs.open-metadata.org/open-source-community/developer) document.
|
||||||
- [ ] I have performed a self-review of my own.
|
- [ ] I have performed a self-review of my own.
|
||||||
- [ ] I have tagged my reviewers below.
|
- [ ] I have tagged my reviewers below.
|
||||||
- [ ] I have commented on my code, particularly in hard-to-understand areas.
|
- [ ] I have commented on my code, particularly in hard-to-understand areas.
|
||||||
- [ ] My changes generate no new warnings.
|
- [ ] My changes generate no new warnings.
|
||||||
- [ ] I have added tests that prove my fix is effective or that my feature works.
|
- [ ] I have added tests that prove my fix is effective or that my feature works.
|
||||||
- [ ] All new and existing tests passed.
|
- [x] All new and existing tests passed.
|
||||||
|
|
||||||
#
|
#
|
||||||
### Reviewers
|
### Reviewers
|
||||||
@ -33,4 +34,4 @@ I worked on the ..... because ...
|
|||||||
<!--- If you are unsure of people to review your work, you can add anyone of these developers :) !-->
|
<!--- If you are unsure of people to review your work, you can add anyone of these developers :) !-->
|
||||||
<!--- Frontend: @shahsank3t, @darth-coder00, @Sachin-chaurasiya -->
|
<!--- Frontend: @shahsank3t, @darth-coder00, @Sachin-chaurasiya -->
|
||||||
<!--- Backend: @sureshms @harshach -->
|
<!--- Backend: @sureshms @harshach -->
|
||||||
<!--- Ingestion: @harshach @ayush-shah -->
|
<!--- Ingestion: @harshach @ayush-shah @pmbrull -->
|
||||||
|
Loading…
x
Reference in New Issue
Block a user