From d16980a30c4c83bf3111e0c846f8abb7249c1b6c Mon Sep 17 00:00:00 2001 From: Pere Miquel Brull Date: Thu, 4 Jan 2024 14:57:37 +0100 Subject: [PATCH] MINOR - Fix Empty Test Suites list filter (#14546) * MINOR - Fix Empty Test Suites list filter * allowed empty test suite to appear in logical test suite page --------- Co-authored-by: Shailesh Parmar --- .../main/java/org/openmetadata/service/jdbi3/ListFilter.java | 2 +- .../components/DataQuality/TestSuites/TestSuites.component.tsx | 2 +- .../src/components/DataQuality/TestSuites/TestSuites.test.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/ListFilter.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/ListFilter.java index 671f6e83141..4d36e1fb513 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/ListFilter.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/ListFilter.java @@ -236,7 +236,7 @@ public class ListFilter { } if (Boolean.TRUE.equals(DatasourceConfig.getInstance().isMySQL())) { - return "!JSON_CONTAINS(json, JSON_ARRAY() , '$.testCaseResultSummary')"; + return "JSON_LENGTH(JSON_EXTRACT(json, '$.testCaseResultSummary')) != 0"; } return "jsonb_array_length(json#>'{testCaseResultSummary}') != 0"; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.component.tsx index 62c885e9941..8804889c960 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.component.tsx @@ -145,7 +145,7 @@ export const TestSuites = ({ summaryPanel }: { summaryPanel: ReactNode }) => { const result = await getListTestSuites({ ...params, fields: 'owner,summary', - includeEmptyTestSuites: false, + includeEmptyTestSuites: !(tab === DataQualityPageTabs.TABLES), testSuiteType: tab === DataQualityPageTabs.TABLES ? TestSuiteType.executable diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.test.tsx index 493c385f3d3..6c1d9168664 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.test.tsx @@ -139,7 +139,7 @@ describe('TestSuites component', () => { ).toBeInTheDocument(); expect(mockGetListTestSuites).toHaveBeenCalledWith({ fields: 'owner,summary', - includeEmptyTestSuites: false, + includeEmptyTestSuites: true, limit: 15, testSuiteType: 'logical', });