yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-03 22:23:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR - Fix Empty Test Suites list filter (#14546)

Browse Source 
* MINOR - Fix Empty Test Suites list filter

* allowed empty test suite to appear in logical test suite page

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
This commit is contained in:
Pere Miquel Brull 2024-01-04 14:57:37 +01:00 committed by GitHub
parent 277ef6b57d
commit d16980a30c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/ListFilter.java
View File

@ -236,7 +236,7 @@ public class ListFilter {
} }
if (Boolean.TRUE.equals(DatasourceConfig.getInstance().isMySQL())) { if (Boolean.TRUE.equals(DatasourceConfig.getInstance().isMySQL())) {
return "!JSON_CONTAINS(json, JSON_ARRAY() , '$.testCaseResultSummary')"; return "JSON_LENGTH(JSON_EXTRACT(json, '$.testCaseResultSummary')) != 0";
} }
return "jsonb_array_length(json#>'{testCaseResultSummary}') != 0"; return "jsonb_array_length(json#>'{testCaseResultSummary}') != 0";

2
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.component.tsx
View File

@ -145,7 +145,7 @@ export const TestSuites = ({ summaryPanel }: { summaryPanel: ReactNode }) => {
const result = await getListTestSuites({ const result = await getListTestSuites({
...params, ...params,
fields: 'owner,summary', fields: 'owner,summary',
includeEmptyTestSuites: false, includeEmptyTestSuites: !(tab === DataQualityPageTabs.TABLES),
testSuiteType: testSuiteType:
tab === DataQualityPageTabs.TABLES tab === DataQualityPageTabs.TABLES
? TestSuiteType.executable ? TestSuiteType.executable

2
openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuites/TestSuites.test.tsx
View File

@ -139,7 +139,7 @@ describe('TestSuites component', () => {
).toBeInTheDocument(); ).toBeInTheDocument();
expect(mockGetListTestSuites).toHaveBeenCalledWith({ expect(mockGetListTestSuites).toHaveBeenCalledWith({
fields: 'owner,summary', fields: 'owner,summary',
includeEmptyTestSuites: false, includeEmptyTestSuites: true,
limit: 15, limit: 15,
testSuiteType: 'logical', testSuiteType: 'logical',
}); });