diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx index a8419dc746e..b02f52ec153 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/AppRouter/AuthenticatedAppRouter.tsx @@ -523,6 +523,22 @@ const AuthenticatedAppRouter: FunctionComponent = () => { } path={ROUTES.TEST_SUITES_EDIT_INGESTION} /> + + + + } + path={ROUTES.DATA_QUALITY_WITH_SUB_TAB} + /> { }; const handleSubTabChange = (e: RadioChangeEvent) => { - history.replace( - getDataQualityPagePath(tab, e.target.value as DataQualitySubTabs) - ); + navigate(getDataQualityPagePath(tab, e.target.value as DataQualitySubTabs)); }; useEffect(() => { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuite/TestSuiteList/TestSuites.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuite/TestSuiteList/TestSuites.test.tsx index 744145042bd..a738f4121b4 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuite/TestSuiteList/TestSuites.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataQuality/TestSuite/TestSuiteList/TestSuites.test.tsx @@ -25,9 +25,7 @@ const testSuitePermission = { EditDisplayName: true, EditCustomFields: true, }; -const mockUseParam = { tab: DataQualityPageTabs.TEST_CASES } as { - tab?: DataQualityPageTabs; -}; + const mockLocation = { search: '', }; diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityPage.tsx index 46d3c762bb7..c4971eb214a 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityPage.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityPage.tsx @@ -15,7 +15,7 @@ import { Button, Card, Col, Row, Tabs } from 'antd'; import { isEmpty } from 'lodash'; import { useMemo } from 'react'; import { useTranslation } from 'react-i18next'; -import { Navigate, useNavigate } from 'react-router-dom'; +import { Link, useNavigate } from 'react-router-dom'; import ManageButton from '../../components/common/EntityPageInfos/ManageButton/ManageButton'; import TabsLabel from '../../components/common/TabsLabel/TabsLabel.component'; import PageHeader from '../../components/PageHeader/PageHeader.component'; @@ -31,10 +31,8 @@ import { DataQualityPageTabs } from './DataQualityPage.interface'; import DataQualityProvider from './DataQualityProvider'; const DataQualityPage = () => { - const { - tab: activeTab = (DataQualityClassBase.getDefaultActiveTab() = - DataQualityClassBase.getDefaultActiveTab()), - } = useRequiredParams<{ tab: DataQualityPageTabs }>(); + const { tab: activeTab = DataQualityClassBase.getDefaultActiveTab() } = + useRequiredParams<{ tab: DataQualityPageTabs }>(); const navigate = useNavigate(); const { t } = useTranslation(); const { permissions } = usePermissionProvider(); @@ -64,27 +62,6 @@ const DataQualityPage = () => { } }; - const renderTabComponent = useMemo(() => { - const currentTab = DataQualityClassBase.getDataQualityTab().find( - (tabItem) => tabItem.key === activeTab - ); - - if (!currentTab) { - return ( - - ); - } - - const TabComponent = currentTab.component; - - return ; - }, [activeTab]); - return ( diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityProvider.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityProvider.tsx index 1f1fe917bf6..6ceb9652dd4 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityProvider.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityProvider.tsx @@ -37,9 +37,10 @@ export const DataQualityContext = createContext( ); const DataQualityProvider = ({ children }: { children: React.ReactNode }) => { - const { tab: activeTab = DataQualityPageTabs.TABLES } = useRequiredParams<{ - tab: DataQualityPageTabs; - }>(); + const { tab: activeTab = DataQualityPageTabs.TEST_CASES } = + useRequiredParams<{ + tab: DataQualityPageTabs; + }>(); const location = useCustomLocation(); const params = useMemo(() => { const search = location.search;