yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-31 10:39:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX - e2e test for pydantic v2 (#16577)

Browse Source 
* FIX - e2e test for pydantic v2

* FIX - e2e test for pydantic v2

* FIX - e2e test for pydantic v2
This commit is contained in:
Pere Miquel Brull 2024-06-10 08:04:36 +02:00 committed by GitHub
parent 4c8bf1cac1
commit d2bba3b8e0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ingestion/src/metadata/ingestion/source/dashboard/metabase/metadata.py
View File

@ -148,7 +148,7 @@ class MetabaseSource(DashboardServiceSource):
f"{replace_special_with(raw=dashboard_details.name.lower(), replacement='-')}" f"{replace_special_with(raw=dashboard_details.name.lower(), replacement='-')}"
) )
dashboard_request = CreateDashboardRequest( dashboard_request = CreateDashboardRequest(
name=EntityName(dashboard_details.id), name=EntityName(str(dashboard_details.id)),
sourceUrl=SourceUrl(dashboard_url), sourceUrl=SourceUrl(dashboard_url),
displayName=dashboard_details.name, displayName=dashboard_details.name,
description=Markdown(dashboard_details.description) description=Markdown(dashboard_details.description)

2
ingestion/src/metadata/ingestion/source/dashboard/metabase/models.py
View File

@ -33,7 +33,7 @@ class MetabaseCollection(BaseModel):
""" """
name: str name: str
id: str id: int
class MetabaseDashboardList(BaseModel): class MetabaseDashboardList(BaseModel):

4
ingestion/src/metadata/ingestion/source/dashboard/redash/metadata.py
View File

@ -158,7 +158,7 @@ class RedashSource(DashboardServiceSource):
dashboard_description = widgets.get("text") dashboard_description = widgets.get("text")
dashboard_request = CreateDashboardRequest( dashboard_request = CreateDashboardRequest(
name=EntityName(dashboard_details["id"]), name=EntityName(str(dashboard_details["id"])),
displayName=dashboard_details.get("name"), displayName=dashboard_details.get("name"),
description=Markdown(dashboard_description) description=Markdown(dashboard_description)
if dashboard_description if dashboard_description
@ -274,7 +274,7 @@ class RedashSource(DashboardServiceSource):
continue continue
yield Either( yield Either(
right=CreateChartRequest( right=CreateChartRequest(
name=EntityName(widgets["id"]), name=EntityName(str(widgets["id"])),
displayName=chart_display_name displayName=chart_display_name
if visualization and visualization["query"] if visualization and visualization["query"]
else "", else "",

2
ingestion/src/metadata/ingestion/source/database/dbt/metadata.py
View File

@ -446,7 +446,7 @@ class DbtSource(DbtServiceSource):
if dbt_raw_query if dbt_raw_query
else None, else None,
# SQL Is a required param for the DataModel # SQL Is a required param for the DataModel
sql=SqlQuery(dbt_compiled_query or dbt_raw_query), sql=SqlQuery(dbt_compiled_query or dbt_raw_query or ""),
columns=self.parse_data_model_columns( columns=self.parse_data_model_columns(
manifest_node, catalog_node manifest_node, catalog_node
), ),