yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-21 08:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui: only allow updating displayName for domain and data product (#14050)

Browse Source 
* ui: only allow updating displayName for domain and data product

* change title edit name to edit display name
This commit is contained in:
Shailesh Parmar 2023-11-21 16:46:17 +05:30 committed by GitHub
parent d55100592d
commit d340efa664
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
openmetadata-ui/src/main/resources/ui/cypress/common/DomainUtils.js
View File

@ -62,16 +62,6 @@ const checkDisplayName = (displayName) => {
}); });
}; };
const checkName = (name) => {
cy.get('[data-testid="entity-header-name"]')
.scrollIntoView()
.should('exist')
.and('be.visible')
.within(() => {
cy.contains(name);
});
};
const updateOwner = (newOwner) => { const updateOwner = (newOwner) => {
interceptURL('PATCH', `/api/v1/domains/*`, 'patchOwner'); interceptURL('PATCH', `/api/v1/domains/*`, 'patchOwner');
interceptURL('GET', '/api/v1/users?limit=25&isBot=false', 'getUsers'); interceptURL('GET', '/api/v1/users?limit=25&isBot=false', 'getUsers');
@ -290,7 +280,7 @@ export const deleteDomain = (domainObj) => {
cy.get('[data-testid="delete-modal"] .ant-modal-title').should( cy.get('[data-testid="delete-modal"] .ant-modal-title').should(
'contain', 'contain',
`Delete ${domainObj.updatedName}` `Delete ${domainObj.name}`
); );
cy.get('[data-testid="confirmation-text-input"]').type(DELETE_TERM); cy.get('[data-testid="confirmation-text-input"]').type(DELETE_TERM);
@ -371,15 +361,13 @@ export const renameDomain = (domainObj) => {
cy.get('[data-testid="manage-button"]').click(); cy.get('[data-testid="manage-button"]').click();
cy.get('[data-testid="rename-button-details-container"]').click(); cy.get('[data-testid="rename-button-details-container"]').click();
cy.get('#name').should('not.be.disabled').clear(); cy.get('#name').should('be.disabled');
cy.get('#displayName').should('not.be.disabled').clear(); cy.get('#displayName').should('not.be.disabled').clear();
cy.get('#name').type(domainObj.updatedName);
cy.get('#displayName').type(domainObj.updatedDisplayName); cy.get('#displayName').type(domainObj.updatedDisplayName);
cy.get('[data-testid="save-button"]').click(); cy.get('[data-testid="save-button"]').click();
verifyResponseStatusCode('@patchName&DisplayName', 200); verifyResponseStatusCode('@patchName&DisplayName', 200);
checkName(domainObj.updatedName);
checkDisplayName(domainObj.updatedDisplayName); checkDisplayName(domainObj.updatedDisplayName);
}; };

6
openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx
View File

@ -312,12 +312,11 @@ const DataProductsDetailsPage = ({
const onNameSave = (obj: { name: string; displayName: string }) => { const onNameSave = (obj: { name: string; displayName: string }) => {
if (dataProduct) { if (dataProduct) {
const { name, displayName } = obj; const { displayName } = obj;
let updatedDetails = cloneDeep(dataProduct); let updatedDetails = cloneDeep(dataProduct);
updatedDetails = { updatedDetails = {
...dataProduct, ...dataProduct,
name: name?.trim() || dataProduct.name,
displayName: displayName?.trim(), displayName: displayName?.trim(),
}; };
@ -548,10 +547,9 @@ const DataProductsDetailsPage = ({
</Row> </Row>
<EntityNameModal <EntityNameModal
allowRename
entity={dataProduct} entity={dataProduct}
title={t('label.edit-entity', { title={t('label.edit-entity', {
entity: t('label.name'), entity: t('label.display-name'),
})} })}
visible={isNameEditing} visible={isNameEditing}
onCancel={() => setIsNameEditing(false)} onCancel={() => setIsNameEditing(false)}

6
openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainDetailsPage/DomainDetailsPage.component.tsx
View File

@ -300,12 +300,11 @@ const DomainDetailsPage = ({
}, []); }, []);
const onNameSave = (obj: { name: string; displayName: string }) => { const onNameSave = (obj: { name: string; displayName: string }) => {
const { name, displayName } = obj; const { displayName } = obj;
let updatedDetails = cloneDeep(domain); let updatedDetails = cloneDeep(domain);
updatedDetails = { updatedDetails = {
...domain, ...domain,
name: name?.trim() || domain.name,
displayName: displayName?.trim(), displayName: displayName?.trim(),
}; };
@ -650,10 +649,9 @@ const DomainDetailsPage = ({
/> />
)} )}
<EntityNameModal <EntityNameModal
allowRename
entity={domain} entity={domain}
title={t('label.edit-entity', { title={t('label.edit-entity', {
entity: t('label.name'), entity: t('label.display-name'),
})} })}
visible={isNameEditing} visible={isNameEditing}
onCancel={() => setIsNameEditing(false)} onCancel={() => setIsNameEditing(false)}