yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-10 15:59:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #6291 UI: Remove required condition for dbt s3 from ui (#6361)

Browse Source
This commit is contained in:
Shailesh Parmar 2022-07-27 03:49:39 +05:30 committed by GitHub
parent a23a9c84c1
commit d3977bcb29
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTConfigForm.interface.ts
View File

@ -62,10 +62,7 @@ export type DbtS3Creds = Pick<
| 'endPointURL' | 'endPointURL'
>; >;
export type DbtS3CredsReq = Pick< export type DbtS3CredsReq = Pick<DbtS3Creds, 'awsRegion'>;
DbtS3Creds,
'awsAccessKeyId' | 'awsSecretAccessKey' | 'awsRegion'
>;
export interface DbtSourceTypes { export interface DbtSourceTypes {
sourceType: DBT_SOURCES; sourceType: DBT_SOURCES;

2
openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTFormConstants.ts
View File

@ -78,8 +78,6 @@ export const reqDBTHttpFields: Record<keyof DbtConfigHttp, string> = {
}; };
export const reqDBTS3Fields: Record<keyof DbtS3CredsReq, string> = { export const reqDBTS3Fields: Record<keyof DbtS3CredsReq, string> = {
awsAccessKeyId: 'AWS Access Key ID',
awsSecretAccessKey: 'AWS Secret Access Key',
awsRegion: 'AWS Region', awsRegion: 'AWS Region',
}; };

6
openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTS3Config.tsx
View File

@ -92,7 +92,7 @@ export const DBTS3Config: FunctionComponent<Props> = ({
<label <label
className="tw-block tw-form-label tw-mb-1" className="tw-block tw-form-label tw-mb-1"
htmlFor="aws-access-key-id"> htmlFor="aws-access-key-id">
{requiredField('AWS Access Key ID')} AWS Access Key ID
</label> </label>
<p className="tw-text-grey-muted tw-mt-1 tw-mb-2 tw-text-xs"> <p className="tw-text-grey-muted tw-mt-1 tw-mb-2 tw-text-xs">
AWS Access Key ID. AWS Access Key ID.
@ -106,13 +106,12 @@ export const DBTS3Config: FunctionComponent<Props> = ({
value={dbtSecurityConfig?.awsAccessKeyId} value={dbtSecurityConfig?.awsAccessKeyId}
onChange={(e) => updateS3Creds('awsAccessKeyId', e.target.value)} onChange={(e) => updateS3Creds('awsAccessKeyId', e.target.value)}
/> />
{errors?.awsAccessKeyId && errorMsg(errors.awsAccessKeyId)}
</Field> </Field>
<Field> <Field>
<label <label
className="tw-block tw-form-label tw-mb-1" className="tw-block tw-form-label tw-mb-1"
htmlFor="aws-secret-access-key-id"> htmlFor="aws-secret-access-key-id">
{requiredField('AWS Secret Access Key')} AWS Secret Access Key
</label> </label>
<p className="tw-text-grey-muted tw-mt-1 tw-mb-2 tw-text-xs"> <p className="tw-text-grey-muted tw-mt-1 tw-mb-2 tw-text-xs">
AWS Secret Access Key. AWS Secret Access Key.
@ -126,7 +125,6 @@ export const DBTS3Config: FunctionComponent<Props> = ({
value={dbtSecurityConfig?.awsSecretAccessKey} value={dbtSecurityConfig?.awsSecretAccessKey}
onChange={(e) => updateS3Creds('awsSecretAccessKey', e.target.value)} onChange={(e) => updateS3Creds('awsSecretAccessKey', e.target.value)}
/> />
{errors?.awsSecretAccessKey && errorMsg(errors.awsSecretAccessKey)}
</Field> </Field>
<Field> <Field>
<label className="tw-block tw-form-label tw-mb-1" htmlFor="aws-region"> <label className="tw-block tw-form-label tw-mb-1" htmlFor="aws-region">