Set max_analyzed_offset in HighlightBuilder to Fix Highlighting Errors for Large Fields (#18495)

* Set max_analyzed_offset in HighlightBuilder to Fix Highlighting Errors for Large Fields

* fix java checkstyle

---------

Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com>
This commit is contained in:
sonika-shah 2024-11-04 15:26:49 +05:30 committed by GitHub
parent 7f2240698b
commit d5497ec2ac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 0 deletions

View File

@ -28,6 +28,7 @@ public class EntityBuilderConstant {
public static final String POST_TAG = "</span>";
public static final Integer MAX_AGGREGATE_SIZE = 10000;
public static final Integer MAX_RESULT_HITS = 10000;
public static final Integer MAX_ANALYZED_OFFSET = 1000;
public static final String QUERY = "query";
public static final String QUERY_NGRAM = "query.ngram";

View File

@ -25,6 +25,7 @@ import static org.openmetadata.service.search.EntityBuilderConstant.FIELD_COLUMN
import static org.openmetadata.service.search.EntityBuilderConstant.FIELD_DISPLAY_NAME_NGRAM;
import static org.openmetadata.service.search.EntityBuilderConstant.FIELD_NAME_NGRAM;
import static org.openmetadata.service.search.EntityBuilderConstant.MAX_AGGREGATE_SIZE;
import static org.openmetadata.service.search.EntityBuilderConstant.MAX_ANALYZED_OFFSET;
import static org.openmetadata.service.search.EntityBuilderConstant.MAX_RESULT_HITS;
import static org.openmetadata.service.search.EntityBuilderConstant.OWNER_DISPLAY_NAME_KEYWORD;
import static org.openmetadata.service.search.EntityBuilderConstant.POST_TAG;
@ -1442,6 +1443,7 @@ public class ElasticSearchClient implements SearchClient {
}
hb.preTags(PRE_TAG);
hb.postTags(POST_TAG);
hb.maxAnalyzedOffset(MAX_ANALYZED_OFFSET);
return hb;
}

View File

@ -23,6 +23,7 @@ import static org.openmetadata.service.search.EntityBuilderConstant.ES_TAG_FQN_F
import static org.openmetadata.service.search.EntityBuilderConstant.FIELD_COLUMN_NAMES;
import static org.openmetadata.service.search.EntityBuilderConstant.FIELD_DISPLAY_NAME_NGRAM;
import static org.openmetadata.service.search.EntityBuilderConstant.MAX_AGGREGATE_SIZE;
import static org.openmetadata.service.search.EntityBuilderConstant.MAX_ANALYZED_OFFSET;
import static org.openmetadata.service.search.EntityBuilderConstant.MAX_RESULT_HITS;
import static org.openmetadata.service.search.EntityBuilderConstant.OWNER_DISPLAY_NAME_KEYWORD;
import static org.openmetadata.service.search.EntityBuilderConstant.POST_TAG;
@ -1274,6 +1275,7 @@ public class OpenSearchClient implements SearchClient {
}
hb.preTags(PRE_TAG);
hb.postTags(POST_TAG);
hb.maxAnalyzerOffset(MAX_ANALYZED_OFFSET);
return hb;
}