diff --git a/ingestion/examples/workflows/snowflake.json b/ingestion/examples/workflows/snowflake.json index d7725062c1d..04520311df4 100644 --- a/ingestion/examples/workflows/snowflake.json +++ b/ingestion/examples/workflows/snowflake.json @@ -2,11 +2,11 @@ "source": { "type": "snowflake", "config": { - "host_port": "account.region.service.snowflakecomputing.com", "username": "username", "password": "strong_password", "database": "SNOWFLAKE_SAMPLE_DATA", + "warehouse": "warehouse_name", "account": "account_name", "service_name": "snowflake", "table_filter_pattern": { diff --git a/ingestion/src/metadata/ingestion/source/snowflake.py b/ingestion/src/metadata/ingestion/source/snowflake.py index 2644ea37ff9..29dad7dc688 100644 --- a/ingestion/src/metadata/ingestion/source/snowflake.py +++ b/ingestion/src/metadata/ingestion/source/snowflake.py @@ -25,12 +25,11 @@ register_custom_type(custom_types.TIMESTAMP_NTZ, "TIME") class SnowflakeConfig(SQLConnectionConfig): scheme = "snowflake" account: str - database: Optional[str] - warehouse: Optional[str] + database: str + warehouse: str role: Optional[str] duration: Optional[int] service_type = "Snowflake" - connect_args: Optional[dict] def get_connection_url(self): connect_string = super().get_connection_url() diff --git a/ingestion/src/metadata/ingestion/source/sql_source.py b/ingestion/src/metadata/ingestion/source/sql_source.py index cd45b219ea7..1c8e59192c6 100644 --- a/ingestion/src/metadata/ingestion/source/sql_source.py +++ b/ingestion/src/metadata/ingestion/source/sql_source.py @@ -530,8 +530,9 @@ class SQLSource(Source[OMetaDatabaseAndTable]): ) if col_type == "NULL": col_type = "VARCHAR" + data_type_display = "varchar" logger.warning( - f"Unknown type mapped to VARCHAR: {column['name']}" + f"Unknown type {column['type']} mapped to VARCHAR: {column['name']}" ) om_column = Column( name=column["name"], @@ -549,7 +550,7 @@ class SQLSource(Source[OMetaDatabaseAndTable]): except Exception as err: logger.error(traceback.format_exc()) logger.error(traceback.print_exc()) - logger.error(err) + logger.error(f"{err} : {column}") continue table_columns.append(om_column) row_order = row_order + 1