From d747536f480cfd918d97e9cae7a21c812022a5c4 Mon Sep 17 00:00:00 2001
From: Shrushti Polekar <shrushtipolekar@gmail.com>
Date: Fri, 4 Apr 2025 22:59:02 +0530
Subject: [PATCH] Minor(UI): Inherited domain and Activity Feed No data
 placeholder size updates (#20638)

* inherited domain and no data placeholder size updates

* update icon size and color

* address pr comments
---
 .../ui/src/assets/svg/no-conversations.svg          |  4 ++--
 .../ActivityFeedTab/ActivityFeedTab.component.tsx   |  4 ++--
 .../ActivityFeedTab/activity-feed-tab.less          |  3 +++
 .../UserProfileTeams/UserProfileTeams.component.tsx |  2 +-
 .../ui/src/components/Settings/Users/users.less     | 13 +++++++++++++
 .../common/DomainLabel/DomainLabelNew.tsx           |  9 ++++-----
 .../src/main/resources/ui/src/styles/app.less       |  6 +++---
 7 files changed, 28 insertions(+), 13 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/no-conversations.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/no-conversations.svg
index 953b86e6efa..9afc0556a55 100644
--- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/no-conversations.svg
+++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/no-conversations.svg
@@ -1,6 +1,6 @@
 <svg width="140" height="140" viewBox="0 0 127 126" fill="none" xmlns="http://www.w3.org/2000/svg">
 <g id="message_empty">
-<ellipse id="Ellipse 1183" opacity="0.1" cx="63.75" cy="122.184" rx="62.9629" ry="3.77777" fill="#7C7B91"/>
-<path id="Union" fill-rule="evenodd" clip-rule="evenodd" d="M97.0359 19.136C97.0359 17.3037 95.5506 15.8184 93.7183 15.8184C91.886 15.8184 90.4007 17.3037 90.4007 19.136V25.9609C90.4007 27.7932 91.886 29.2785 93.7183 29.2785C95.5506 29.2785 97.0359 27.7932 97.0359 25.9609V19.136ZM93.7183 18.3369C94.1596 18.3369 94.5174 18.6946 94.5174 19.136V25.9609C94.5174 26.4022 94.1596 26.76 93.7183 26.76C93.277 26.76 92.9192 26.4022 92.9192 25.9609V19.136C92.9192 18.6946 93.277 18.3369 93.7183 18.3369ZM13.3789 42.8517C13.3789 36.5925 18.453 31.5185 24.7122 31.5185H82.6381C88.8973 31.5185 93.9714 36.5925 93.9714 42.8517V52.9258H104.045C108.914 52.9258 112.86 56.8723 112.86 61.7405V92.97C112.86 97.8383 108.914 101.785 104.045 101.785H100.764V106.347C100.764 109.643 96.8379 111.358 94.4193 109.119L86.497 101.785H52.4159C47.5476 101.785 43.6011 97.8383 43.6011 92.97V88.9902L33.8852 98.0583C31.4704 100.312 27.5298 98.5998 27.5298 95.2966V88.6886H24.7122C18.453 88.6886 13.3789 83.6145 13.3789 77.3553V42.8517ZM93.9714 77.3553V55.4443H104.045C107.523 55.4443 110.342 58.2632 110.342 61.7405V92.97C110.342 96.4474 107.523 99.2663 104.045 99.2663H99.5043C98.8088 99.2663 98.245 99.8301 98.245 100.526V106.347C98.245 107.446 96.9365 108.017 96.1303 107.271L87.8459 99.6015C87.6131 99.386 87.3076 99.2663 86.9904 99.2663H52.4159C48.9386 99.2663 46.1196 96.4474 46.1196 92.97V88.6886H82.6381C88.8973 88.6886 93.9714 83.6145 93.9714 77.3553ZM82.6381 86.1701H46.1196H43.6011H43.4279C43.109 86.1701 42.8019 86.2911 42.5687 86.5087L32.1668 96.2172C31.3619 96.9685 30.0483 96.3977 30.0483 95.2966V87.4293C30.0483 86.7339 29.4845 86.1701 28.7891 86.1701H24.7122C19.8439 86.1701 15.8974 82.2236 15.8974 77.3553V42.8517C15.8974 37.9835 19.8439 34.037 24.7122 34.037H82.6381C87.5064 34.037 91.4529 37.9835 91.4529 42.8517V77.3553C91.4529 82.2236 87.5064 86.1701 82.6381 86.1701ZM35.1326 65.9588C38.3665 65.9588 40.9881 63.3372 40.9881 60.1033C40.9881 56.8694 38.3665 54.2477 35.1326 54.2477C31.8987 54.2477 29.277 56.8694 29.277 60.1033C29.277 63.3372 31.8987 65.9588 35.1326 65.9588ZM59.5302 60.1033C59.5302 63.3372 56.9086 65.9588 53.6747 65.9588C50.4407 65.9588 47.8191 63.3372 47.8191 60.1033C47.8191 56.8694 50.4407 54.2477 53.6747 54.2477C56.9086 54.2477 59.5302 56.8694 59.5302 60.1033ZM72.218 65.9588C75.4519 65.9588 78.0735 63.3372 78.0735 60.1033C78.0735 56.8694 75.4519 54.2477 72.218 54.2477C68.984 54.2477 66.3624 56.8694 66.3624 60.1033C66.3624 63.3372 68.984 65.9588 72.218 65.9588ZM96.9228 33.2206C96.9228 35.0529 98.4081 36.5383 100.24 36.5383H107.065C108.898 36.5383 110.383 35.0529 110.383 33.2206C110.383 31.3884 108.898 29.903 107.065 29.903H100.24C98.4081 29.903 96.9228 31.3884 96.9228 33.2206ZM100.24 34.0197C99.7991 34.0197 99.4413 33.662 99.4413 33.2206C99.4413 32.7793 99.7991 32.4215 100.24 32.4215H107.065C107.507 32.4215 107.864 32.7793 107.864 33.2206C107.864 33.662 107.507 34.0197 107.065 34.0197H100.24Z" fill="#7C7B91"/>
+<ellipse id="Ellipse 1183" opacity="0.1" cx="63.75" cy="122.184" rx="62.9629" ry="3.77777" fill="#A4A7AE"/>
+<path id="Union" fill-rule="evenodd" clip-rule="evenodd" d="M97.0359 19.136C97.0359 17.3037 95.5506 15.8184 93.7183 15.8184C91.886 15.8184 90.4007 17.3037 90.4007 19.136V25.9609C90.4007 27.7932 91.886 29.2785 93.7183 29.2785C95.5506 29.2785 97.0359 27.7932 97.0359 25.9609V19.136ZM93.7183 18.3369C94.1596 18.3369 94.5174 18.6946 94.5174 19.136V25.9609C94.5174 26.4022 94.1596 26.76 93.7183 26.76C93.277 26.76 92.9192 26.4022 92.9192 25.9609V19.136C92.9192 18.6946 93.277 18.3369 93.7183 18.3369ZM13.3789 42.8517C13.3789 36.5925 18.453 31.5185 24.7122 31.5185H82.6381C88.8973 31.5185 93.9714 36.5925 93.9714 42.8517V52.9258H104.045C108.914 52.9258 112.86 56.8723 112.86 61.7405V92.97C112.86 97.8383 108.914 101.785 104.045 101.785H100.764V106.347C100.764 109.643 96.8379 111.358 94.4193 109.119L86.497 101.785H52.4159C47.5476 101.785 43.6011 97.8383 43.6011 92.97V88.9902L33.8852 98.0583C31.4704 100.312 27.5298 98.5998 27.5298 95.2966V88.6886H24.7122C18.453 88.6886 13.3789 83.6145 13.3789 77.3553V42.8517ZM93.9714 77.3553V55.4443H104.045C107.523 55.4443 110.342 58.2632 110.342 61.7405V92.97C110.342 96.4474 107.523 99.2663 104.045 99.2663H99.5043C98.8088 99.2663 98.245 99.8301 98.245 100.526V106.347C98.245 107.446 96.9365 108.017 96.1303 107.271L87.8459 99.6015C87.6131 99.386 87.3076 99.2663 86.9904 99.2663H52.4159C48.9386 99.2663 46.1196 96.4474 46.1196 92.97V88.6886H82.6381C88.8973 88.6886 93.9714 83.6145 93.9714 77.3553ZM82.6381 86.1701H46.1196H43.6011H43.4279C43.109 86.1701 42.8019 86.2911 42.5687 86.5087L32.1668 96.2172C31.3619 96.9685 30.0483 96.3977 30.0483 95.2966V87.4293C30.0483 86.7339 29.4845 86.1701 28.7891 86.1701H24.7122C19.8439 86.1701 15.8974 82.2236 15.8974 77.3553V42.8517C15.8974 37.9835 19.8439 34.037 24.7122 34.037H82.6381C87.5064 34.037 91.4529 37.9835 91.4529 42.8517V77.3553C91.4529 82.2236 87.5064 86.1701 82.6381 86.1701ZM35.1326 65.9588C38.3665 65.9588 40.9881 63.3372 40.9881 60.1033C40.9881 56.8694 38.3665 54.2477 35.1326 54.2477C31.8987 54.2477 29.277 56.8694 29.277 60.1033C29.277 63.3372 31.8987 65.9588 35.1326 65.9588ZM59.5302 60.1033C59.5302 63.3372 56.9086 65.9588 53.6747 65.9588C50.4407 65.9588 47.8191 63.3372 47.8191 60.1033C47.8191 56.8694 50.4407 54.2477 53.6747 54.2477C56.9086 54.2477 59.5302 56.8694 59.5302 60.1033ZM72.218 65.9588C75.4519 65.9588 78.0735 63.3372 78.0735 60.1033C78.0735 56.8694 75.4519 54.2477 72.218 54.2477C68.984 54.2477 66.3624 56.8694 66.3624 60.1033C66.3624 63.3372 68.984 65.9588 72.218 65.9588ZM96.9228 33.2206C96.9228 35.0529 98.4081 36.5383 100.24 36.5383H107.065C108.898 36.5383 110.383 35.0529 110.383 33.2206C110.383 31.3884 108.898 29.903 107.065 29.903H100.24C98.4081 29.903 96.9228 31.3884 96.9228 33.2206ZM100.24 34.0197C99.7991 34.0197 99.4413 33.662 99.4413 33.2206C99.4413 32.7793 99.7991 32.4215 100.24 32.4215H107.065C107.507 32.4215 107.864 32.7793 107.864 33.2206C107.864 33.662 107.507 34.0197 107.065 34.0197H100.24Z" fill="#A4A7AE"/>
 </g>
 </svg>
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/ActivityFeedTab.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/ActivityFeedTab.component.tsx
index 028c1ec2d75..98ecf7e0036 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/ActivityFeedTab.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/ActivityFeedTab.component.tsx
@@ -501,7 +501,7 @@ export const ActivityFeedTab = ({
 
     return (
       <div className="d-flex flex-col gap-4">
-        <Typography.Text className="placeholder-title m-t-0">
+        <Typography.Text className="placeholder-title m-t-md">
           {t('message.no-conversations')}
         </Typography.Text>
         <Typography.Text className="placeholder-text">
@@ -639,7 +639,7 @@ export const ActivityFeedTab = ({
         {selectedThread && !loading
           ? getRightPanelContent(selectedThread)
           : !loading && (
-              <div className="p-x-md no-data-placeholder-container d-flex justify-center items-center h-full">
+              <div className="p-x-md no-data-placeholder-container-right-panel d-flex justify-center items-center h-full">
                 <ErrorPlaceHolderNew
                   icon={<NoConversationsIcon />}
                   type={ERROR_PLACEHOLDER_TYPE.CUSTOM}>
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less
index 249015c55a9..6ae2cf6c3a3 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less
+++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less
@@ -635,3 +635,6 @@
     }
   }
 }
+.no-data-placeholder-container-right-panel {
+  margin-top: @size-xl;
+}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx
index bd478789d26..a6b5dbf8e23 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileTeams/UserProfileTeams.component.tsx
@@ -121,7 +121,7 @@ const UserProfileTeams = ({
         </div>
 
         <div className="d-flex justify-between w-full">
-          <Typography.Text className="text-sm font-medium">
+          <Typography.Text className="text-sm font-medium p-l-xss">
             {t('label.team-plural')}
           </Typography.Text>
 
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less
index 9266303afe0..05c7bd509f9 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/users.less
@@ -440,3 +440,16 @@
   white-space: nowrap;
   max-width: 140px;
 }
+.inherit-icon-container {
+  background-color: @white;
+  border-color: @primary-color;
+  color: @primary-color;
+  border: 1px solid @primary-color;
+  width: 12px;
+  height: 12px;
+  border-radius: 50%;
+  margin-top: @size-xxs;
+  &.inherit-icon {
+    color: @primary-color;
+  }
+}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainLabel/DomainLabelNew.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainLabel/DomainLabelNew.tsx
index 04eaf156a6d..42a11dbc651 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/DomainLabel/DomainLabelNew.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/DomainLabel/DomainLabelNew.tsx
@@ -121,10 +121,9 @@ export const DomainLabelNew = ({
                   title={t('label.inherited-entity', {
                     entity: t('label.domain'),
                   })}>
-                  <InheritIcon
-                    className="inherit-icon cursor-pointer"
-                    width={14}
-                  />
+                  <span className="inherit-icon-container d-flex items-center flex-center">
+                    <InheritIcon className="inherit-icon" height={8} />
+                  </span>
                 </Tooltip>
               ) : null;
 
@@ -205,7 +204,7 @@ export const DomainLabelNew = ({
         </div>
 
         <div className="d-flex justify-between w-full">
-          <Typography.Text className="text-sm font-medium">
+          <Typography.Text className="text-sm font-medium p-l-xss">
             {t('label.domain-plural')}
           </Typography.Text>
           {selectableList}
diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/app.less b/openmetadata-ui/src/main/resources/ui/src/styles/app.less
index 5f72cb75a2e..10b268ae563 100644
--- a/openmetadata-ui/src/main/resources/ui/src/styles/app.less
+++ b/openmetadata-ui/src/main/resources/ui/src/styles/app.less
@@ -945,12 +945,12 @@ a[href].link-text-grey,
 .placeholder-title {
   color: @text-color;
   text-align: center;
-  font-size: 20px;
+  font-size: 18px;
   font-style: normal;
   font-weight: 400;
   line-height: normal;
   letter-spacing: 0.25px;
-  margin-top: 16px;
+  margin-top: @size-md;
 }
 
 .no-data-placeholder-container {
@@ -960,7 +960,7 @@ a[href].link-text-grey,
 .placeholder-text {
   color: @text-color-tertiary;
   text-align: center;
-  font-size: 16px;
+  font-size: @font-size-base;
   font-style: normal;
   font-weight: 400;
   line-height: normal;