From dbd9311a2ca706bf125027346b47f2aef334d7d5 Mon Sep 17 00:00:00 2001 From: Shailesh Parmar Date: Wed, 4 Dec 2024 18:15:11 +0530 Subject: [PATCH] GEN-2186: Fix Updating sampling config from deep link issue (#18916) --- .../ui/playwright/e2e/Pages/DataQualityAndProfiler.spec.ts | 5 ++++- .../ProfilerSettingsModal/ProfilerSettingsModal.tsx | 2 +- .../Profiler/TableProfiler/TableProfilerProvider.tsx | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataQualityAndProfiler.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataQualityAndProfiler.spec.ts index a1578a45eee..6d767449500 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataQualityAndProfiler.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataQualityAndProfiler.spec.ts @@ -493,9 +493,12 @@ test( await page.getByTestId('profiler').click(); await page .getByTestId('profiler-tab-left-panel') - .getByText('Table Profile') + .getByText('Data Quality') .click(); + await page.reload(); + await page.waitForLoadState('networkidle'); + await page.click('[data-testid="profiler-setting-btn"]'); await page.waitForSelector('.ant-modal-body'); await page.locator('[data-testid="slider-input"]').clear(); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/ProfilerSettingsModal/ProfilerSettingsModal.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/ProfilerSettingsModal/ProfilerSettingsModal.tsx index b6e6b7894d6..d0b0d2b3e33 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/ProfilerSettingsModal/ProfilerSettingsModal.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/ProfilerSettingsModal/ProfilerSettingsModal.tsx @@ -415,7 +415,7 @@ const ProfilerSettingsModal: React.FC = ({ } else { setIsDataLoading(false); } - }, []); + }, [tableId]); return (