yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-25 01:18:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

GEN-2186: Fix Updating sampling config from deep link issue (#18916)

Browse Source
This commit is contained in:
Shailesh Parmar 2024-12-04 18:15:11 +05:30 committed by GitHub
parent 28f551d20a
commit dbd9311a2c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataQualityAndProfiler.spec.ts
View File

@ -493,9 +493,12 @@ test(
await page.getByTestId('profiler').click(); await page.getByTestId('profiler').click();
await page await page
.getByTestId('profiler-tab-left-panel') .getByTestId('profiler-tab-left-panel')
.getByText('Table Profile') .getByText('Data Quality')
.click(); .click();
await page.reload();
await page.waitForLoadState('networkidle');
await page.click('[data-testid="profiler-setting-btn"]'); await page.click('[data-testid="profiler-setting-btn"]');
await page.waitForSelector('.ant-modal-body'); await page.waitForSelector('.ant-modal-body');
await page.locator('[data-testid="slider-input"]').clear(); await page.locator('[data-testid="slider-input"]').clear();

2
openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/ProfilerSettingsModal/ProfilerSettingsModal.tsx
View File

@ -415,7 +415,7 @@ const ProfilerSettingsModal: React.FC<ProfilerSettingsModalProps> = ({
} else { } else {
setIsDataLoading(false); setIsDataLoading(false);
} }
}, []); }, [tableId]);
return ( return (
<Modal <Modal

4
openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/TableProfilerProvider.tsx
View File

@ -308,8 +308,8 @@ export const TableProfilerProvider = ({
{children} {children}
{settingModalVisible && ( {settingModalVisible && (
<ProfilerSettingsModal <ProfilerSettingsModal
columns={tableProfiler?.columns ?? []} columns={table?.columns ?? []}
tableId={tableProfiler?.id ?? ''} tableId={table?.id ?? ''}
visible={settingModalVisible} visible={settingModalVisible}
onVisibilityChange={handleSettingModal} onVisibilityChange={handleSettingModal}
/> />