From dccba2010153251d13995252d5989f23cee8b846 Mon Sep 17 00:00:00 2001 From: IceS2 Date: Tue, 5 Nov 2024 18:39:50 +0100 Subject: [PATCH] Return s3 endpoint as str() instead of Url (#18521) --- .../src/metadata/ingestion/source/database/iceberg/fs/s3.py | 2 +- ingestion/tests/unit/topology/database/test_iceberg.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ingestion/src/metadata/ingestion/source/database/iceberg/fs/s3.py b/ingestion/src/metadata/ingestion/source/database/iceberg/fs/s3.py index 7fa6a090170..326abc1447f 100644 --- a/ingestion/src/metadata/ingestion/source/database/iceberg/fs/s3.py +++ b/ingestion/src/metadata/ingestion/source/database/iceberg/fs/s3.py @@ -67,7 +67,7 @@ class S3FileSystem(IcebergFileSystemBase): ) return { - S3_ENDPOINT: fs_config.endPointURL, + S3_ENDPOINT: str(fs_config.endPointURL), S3_ACCESS_KEY_ID: fs_config.awsAccessKeyId, S3_SECRET_ACCESS_KEY: fs_config.awsSecretAccessKey.get_secret_value() if fs_config.awsSecretAccessKey diff --git a/ingestion/tests/unit/topology/database/test_iceberg.py b/ingestion/tests/unit/topology/database/test_iceberg.py index 740cdb4ec25..8123a80758f 100644 --- a/ingestion/tests/unit/topology/database/test_iceberg.py +++ b/ingestion/tests/unit/topology/database/test_iceberg.py @@ -464,6 +464,7 @@ MOCK_DYNAMO_CONFIG = { "connection": { "tableName": "table", "awsConfig": { + "endPointURL": "http://example.com", "awsAccessKeyId": "access_key", "awsSecretAccessKey": "secret", "awsRegion": "us-east-2",