ui: updated ux for database service name field in database ingestion form (#10387)

* ui: updated ux for database service name field in database ingestion form

* addressing comments

* updated message
This commit is contained in:
Shailesh Parmar 2023-03-03 14:53:22 +05:30 committed by GitHub
parent b3c8657547
commit ddf39d8d6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 15 deletions

View File

@ -156,16 +156,10 @@ const ConfigureIngestion = ({
handleProfileSample(undefined);
};
const handleDashBoardServiceNames = (inputValue: string) => {
const separator = ',';
const databaseNames = inputValue.includes(separator)
? inputValue.split(separator)
: Array(inputValue);
if (databaseNames) {
const handleDashBoardServiceNames = (inputValue: string[]) => {
if (inputValue) {
onChange({
databaseServiceNames: databaseNames,
databaseServiceNames: inputValue,
});
}
};
@ -490,14 +484,17 @@ const ConfigureIngestion = ({
<p className="tw-text-grey-muted tw-mt-1 tw-mb-2 tw-text-sm">
{t('message.database-service-name-message')}
</p>
<input
className="tw-form-inputs tw-form-inputs-padding"
<Select
allowClear
data-testid="name"
id="name"
name="name"
type="text"
mode="tags"
placeholder={t('label.add-entity', {
entity: t('label.database-service-name'),
})}
style={{ width: '100%' }}
value={databaseServiceNames}
onChange={(e) => handleDashBoardServiceNames(e.target.value)}
onChange={handleDashBoardServiceNames}
/>
{getSeparator('')}
</Field>

View File

@ -914,7 +914,7 @@
"data-asset-has-been-action-type": "Data Asset has been {{actionType}}",
"data-insight-page-views": "Displays the number of times a dataset type was viewed.",
"data-insight-subtitle": "Get a single pane view of the health of all your data assets over time.",
"database-service-name-message": "Database Service Name for creation of lineage.",
"database-service-name-message": "Add the database service names to create lineage.",
"dbt-catalog-file-extract-path": " dbt catalog file to extract dbt models with their column schemas.",
"dbt-cloud-project": "In case of multiple projects in a dbt cloud account, specify the project's id from which you want to extract the dbt run artifacts",
"dbt-ingestion-description": "A dbt workflow can be configured and deployed after a metadata ingestion has been set up. Multiple dbt pipelines can be set up for the same database service. The pipeline feeds the dbt tab of the Table entity, creates lineage from dbt nodes and adds tests from dbt. Add the source configuration of the dbt files to start.",