yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-03 20:19:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

GEN-2031: fix Add profiler configuration button in Data Quality tab (#18798)

Browse Source
This commit is contained in:
Shailesh Parmar 2024-11-26 20:49:36 +05:30 committed by GitHub
parent 490bbf6241
commit de3d7c40db
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 52 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/QualityTab/QualityTab.component.tsx
View File

@ -11,11 +11,22 @@
* limitations under the License.
*/
import { DownOutlined } from '@ant-design/icons';
import { Button, Col, Dropdown, Form, Row, Select, Space, Tabs } from 'antd';
import {
Button,
Col,
Dropdown,
Form,
Row,
Select,
Space,
Tabs,
Tooltip,
} from 'antd';
import { isEmpty } from 'lodash';
import React, { useMemo, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { useHistory } from 'react-router-dom';
import { ReactComponent as SettingIcon } from '../../../../../assets/svg/ic-settings-primery.svg';
import {
getEntityDetailsPath,
INITIAL_PAGING_VALUE,
@ -64,6 +75,7 @@ export const QualityTab = () => {
testCasePaging,
table,
testCaseSummary,
onSettingButtonClick,
} = useTableProfiler();
const { getResourceLimit } = useLimitStore();
@ -76,7 +88,12 @@ export const QualityTab = () => {
showPagination,
} = testCasePaging;
const editTest = permissions.EditAll || permissions.EditTests;
const { editTest, editDataProfile } = useMemo(() => {
return {
editTest: permissions?.EditAll || permissions?.EditTests,
editDataProfile: permissions?.EditAll || permissions?.EditDataProfile,
};
}, [permissions]);
const { fqn: datasetFQN } = useFqn();
const history = useHistory();
const { t } = useTranslation();
@ -293,6 +310,19 @@ export const QualityTab = () => {
</LimitWrapper>
</Form.Item>
)}
{editDataProfile && (
<Tooltip
placement="topRight"
title={t('label.setting-plural')}>
<Button
className="flex-center"
data-testid="profiler-setting-btn"
onClick={onSettingButtonClick}>
<SettingIcon />
</Button>
</Tooltip>
)}
</Space>
</Form>
</Col>

20
openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/QualityTab/QualityTab.test.tsx
View File

@ -35,6 +35,7 @@ const mockTable = {
const mockPush = jest.fn();
const mockUseTableProfiler = {
tableProfiler: MOCK_TABLE,
onSettingButtonClick: jest.fn(),
permissions: {
EditAll: true,
EditDataProfile: true,
@ -136,6 +137,9 @@ describe('QualityTab', () => {
'message.page-sub-header-for-data-quality'
);
expect(await screen.findByTestId('mock-searchbar')).toBeInTheDocument();
expect(
await screen.findByTestId('profiler-setting-btn')
).toBeInTheDocument();
expect(
await screen.findByText('label.test-case-plural')
).toBeInTheDocument();
@ -262,4 +266,20 @@ describe('QualityTab', () => {
expect(await screen.findByText('label.success')).toBeInTheDocument();
expect(await screen.findByText('label.aborted')).toBeInTheDocument();
});
it('should call onSettingButtonClick', async () => {
await act(async () => {
render(<QualityTab />);
});
const profilerSettingBtn = await screen.findByTestId(
'profiler-setting-btn'
);
await act(async () => {
fireEvent.click(profilerSettingBtn);
});
expect(mockUseTableProfiler.onSettingButtonClick).toHaveBeenCalled();
});
});