From df84876da0e9698a483038cce5c4c9357691c19f Mon Sep 17 00:00:00 2001 From: Anubhav Jain <30366878+anubhav823@users.noreply.github.com> Date: Mon, 3 Oct 2022 20:01:05 +0530 Subject: [PATCH] added assert statements for sonar build (#7865) * added assert statements for sonar build * added assert statements to test cases for sonar build failure --- .../service/resources/databases/TableResourceTest.java | 7 ++++--- .../service/resources/teams/UserResourceTest.java | 3 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java index 4b46d34ee8b..e6088eb1e01 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java @@ -240,11 +240,12 @@ public class TableResourceTest extends EntityResourceTest { // Create table with different optional fields // Optional field description CreateTable create = createRequest(test).withDescription("description"); - createAndCheckEntity(create, ADMIN_AUTH_HEADERS); - + Table createdTable = createAndCheckEntity(create, ADMIN_AUTH_HEADERS); // Optional fields tableType create.withName(getEntityName(test, 1)).withTableType(TableType.View); - createAndCheckEntity(create, ADMIN_AUTH_HEADERS); + Table createdTableWithOptionalFields = createAndCheckEntity(create, ADMIN_AUTH_HEADERS); + assertNotNull(createdTable); + assertNotNull(createdTableWithOptionalFields); } @Test diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java index fbb1735f04e..3f20e09006a 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/teams/UserResourceTest.java @@ -206,6 +206,7 @@ public class UserResourceTest extends EntityResourceTest { create = createRequest(test, 6).withDisplayName("displayName").withProfile(PROFILE).withIsAdmin(true); createAndCheckEntity(create, ADMIN_AUTH_HEADERS); + assertNotNull(create); } @Test @@ -228,6 +229,7 @@ public class UserResourceTest extends EntityResourceTest { change = getChangeDescription(user.getVersion()); fieldUpdated(change, "displayName", "displayName1", "displayName2"); updateAndCheckEntity(update, OK, authHeaders("user.xyz@email.com"), MINOR_UPDATE, change); + assertNotNull(user); } @Test @@ -251,6 +253,7 @@ public class UserResourceTest extends EntityResourceTest { .withEmail("testAdmin@email.com") .withIsAdmin(true); createAndCheckEntity(create, ADMIN_AUTH_HEADERS); + assertNotNull(create); } @Test