From e083293db7cb88854a0eafbbc4ba76bab8724720 Mon Sep 17 00:00:00 2001 From: Ashish Gupta Date: Thu, 22 May 2025 14:13:12 +0530 Subject: [PATCH] fix the entityRightPanel and serviceEntity playwright spec (#21352) (cherry picked from commit bbffeb87c738316b75ef2005a12be7a74088fbc9) --- .../ui/playwright/e2e/Features/BulkEditEntity.spec.ts | 4 ++++ .../e2e/Features/EntityRightCollapsablePanel.spec.ts | 8 -------- .../ui/playwright/support/entity/DatabaseClass.ts | 4 +++- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkEditEntity.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkEditEntity.spec.ts index e2e24974c90..64b7b7758e8 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkEditEntity.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/BulkEditEntity.spec.ts @@ -683,6 +683,10 @@ test.describe('Bulk Edit Entity', () => { .locator('.inovua-react-toolkit-load-mask__background-layer') .waitFor({ state: 'detached' }); + await page.waitForSelector('[data-testid="loader"]', { + state: 'detached', + }); + await toastNotification( page, `Glossaryterm ${glossary.responseData.fullyQualifiedName} details updated successfully` diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/EntityRightCollapsablePanel.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/EntityRightCollapsablePanel.spec.ts index ceb8718d865..4d6ef7380ad 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/EntityRightCollapsablePanel.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/EntityRightCollapsablePanel.spec.ts @@ -52,10 +52,6 @@ test('Show and Hide Right Collapsable Panel', async ({ page }) => { page.locator('[data-testid="KnowledgePanel.GlossaryTerms"]') ).not.toBeVisible(); - await expect( - page.locator('[data-testid="KnowledgePanel.CustomProperties"]') - ).not.toBeVisible(); - await expect( page.locator('[data-testid="KnowledgePanel.TableConstraints"]') ).not.toBeVisible(); @@ -75,10 +71,6 @@ test('Show and Hide Right Collapsable Panel', async ({ page }) => { page.locator('[data-testid="KnowledgePanel.GlossaryTerms"]') ).toBeVisible(); - await expect( - page.locator('[data-testid="KnowledgePanel.CustomProperties"]') - ).toBeVisible(); - await expect( page.locator('[data-testid="KnowledgePanel.TableConstraints"]') ).toBeVisible(); diff --git a/openmetadata-ui/src/main/resources/ui/playwright/support/entity/DatabaseClass.ts b/openmetadata-ui/src/main/resources/ui/playwright/support/entity/DatabaseClass.ts index d800d4fe3da..6964dcd281c 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/support/entity/DatabaseClass.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/support/entity/DatabaseClass.ts @@ -249,7 +249,9 @@ export class DatabaseClass extends EntityClass { await expect( page .getByTestId(`table-data-card_${searchTerm}`) - .getByRole('link', { name: owner }) + .getByTestId('owner-label') + .getByTestId('owner-link') + .getByTestId(owner) ).toBeVisible(); }