yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-17 04:52:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Addressing checkstyle issues

Browse Source
This commit is contained in:
Suresh Srinivas 2021-08-21 18:51:05 -07:00
parent 19151dcac7
commit e16c8aafc0
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/topics/TopicResource.java
View File

@ -232,8 +232,9 @@ public class TopicResource {
SecurityUtil.checkAdminOrBotRole(authorizer, securityContext); SecurityUtil.checkAdminOrBotRole(authorizer, securityContext);
Topic topic = Topic topic =
new Topic().withId(UUID.randomUUID()).withName(create.getName()).withDescription(create.getDescription()) new Topic().withId(UUID.randomUUID()).withName(create.getName()).withDescription(create.getDescription())
.withService(create.getService()).withPartitions(create.getPartitions()).withSchema(create.getSchema()) .withService(create.getService()).withPartitions(create.getPartitions())
.withSchemaType(create.getSchemaType()).withCleanupPolicies(create.getCleanupPolicies()) .withSchema(create.getSchema()).withSchemaType(create.getSchemaType())
.withCleanupPolicies(create.getCleanupPolicies())
.withMaximumMessageSize(create.getMaximumMessageSize()) .withMaximumMessageSize(create.getMaximumMessageSize())
.withMinimumInSyncReplicas(create.getMinimumInSyncReplicas()) .withMinimumInSyncReplicas(create.getMinimumInSyncReplicas())
.withRetentionSize(create.getRetentionSize()).withRetentionTime(create.getRetentionTime()); .withRetentionSize(create.getRetentionSize()).withRetentionTime(create.getRetentionTime());
@ -278,8 +279,9 @@ public class TopicResource {
Topic topic = Topic topic =
new Topic().withId(UUID.randomUUID()).withName(create.getName()).withDescription(create.getDescription()) new Topic().withId(UUID.randomUUID()).withName(create.getName()).withDescription(create.getDescription())
.withService(create.getService()).withPartitions(create.getPartitions()).withSchema(create.getSchema()) .withService(create.getService()).withPartitions(create.getPartitions())
.withSchemaType(create.getSchemaType()).withCleanupPolicies(create.getCleanupPolicies()) .withSchema(create.getSchema()).withSchemaType(create.getSchemaType())
.withCleanupPolicies(create.getCleanupPolicies())
.withMaximumMessageSize(create.getMaximumMessageSize()) .withMaximumMessageSize(create.getMaximumMessageSize())
.withMinimumInSyncReplicas(create.getMinimumInSyncReplicas()) .withMinimumInSyncReplicas(create.getMinimumInSyncReplicas())
.withRetentionSize(create.getRetentionSize()).withRetentionTime(create.getRetentionTime()); .withRetentionSize(create.getRetentionSize()).withRetentionTime(create.getRetentionTime());

3
catalog-rest-service/src/test/java/org/openmetadata/catalog/resources/services/MessagingServiceResourceTest.java
View File

@ -326,7 +326,8 @@ public class MessagingServiceResourceTest extends CatalogApplicationTest {
// Ensure deleted service does not exist // Ensure deleted service does not exist
HttpResponseException exception = assertThrows(HttpResponseException.class, () -> getService(id, authHeaders)); HttpResponseException exception = assertThrows(HttpResponseException.class, () -> getService(id, authHeaders));
TestUtils.assertResponse(exception, NOT_FOUND, CatalogExceptionMessage.entityNotFound(Entity.MESSAGING_SERVICE, id)); TestUtils.assertResponse(exception, NOT_FOUND,
CatalogExceptionMessage.entityNotFound(Entity.MESSAGING_SERVICE, id));
// Ensure deleted service does not exist when getting by name // Ensure deleted service does not exist when getting by name
exception = assertThrows(HttpResponseException.class, () -> getServiceByName(name, null, authHeaders)); exception = assertThrows(HttpResponseException.class, () -> getServiceByName(name, null, authHeaders));