From e197c3f3d01e33a64538bc891ed8ef33de7a8af4 Mon Sep 17 00:00:00 2001
From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Date: Tue, 29 Oct 2024 12:18:51 +0530
Subject: [PATCH] fix(ui): unable to add more enum values for enum cp (#18440)

* fix(ui): unable to add more enum values for enum cp

* replicate height constraint and dropdown visibility to add cp
---
 .../CustomProperty/AddCustomProperty/AddCustomProperty.tsx | 2 ++
 .../EditCustomPropertyModal/EditCustomPropertyModal.tsx    | 2 ++
 .../main/resources/ui/src/constants/Services.constant.ts   | 7 +++++--
 .../main/resources/ui/src/styles/components/select.less    | 7 +++++++
 4 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/AddCustomProperty/AddCustomProperty.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/AddCustomProperty/AddCustomProperty.tsx
index 11a0cb93dfa..bdc949df91e 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/AddCustomProperty/AddCustomProperty.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/AddCustomProperty/AddCustomProperty.tsx
@@ -326,6 +326,8 @@ const AddCustomProperty = () => {
       'data-testid': 'enumConfig',
       mode: 'tags',
       placeholder: t('label.enum-value-plural'),
+      open: false,
+      className: 'trim-select',
     },
     rules: [
       {
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/EditCustomPropertyModal/EditCustomPropertyModal.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/EditCustomPropertyModal/EditCustomPropertyModal.tsx
index d3821557f42..c875ebb9f8a 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/EditCustomPropertyModal/EditCustomPropertyModal.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/CustomProperty/EditCustomPropertyModal/EditCustomPropertyModal.tsx
@@ -100,6 +100,8 @@ const EditCustomPropertyModal: FC<EditCustomPropertyModalProps> = ({
         const updatedValues = uniq([...value, ...(enumConfig?.values ?? [])]);
         form.setFieldsValue({ customPropertyConfig: updatedValues });
       },
+      open: false,
+      className: 'trim-select',
     },
     rules: [
       {
diff --git a/openmetadata-ui/src/main/resources/ui/src/constants/Services.constant.ts b/openmetadata-ui/src/main/resources/ui/src/constants/Services.constant.ts
index ed16f79a2dd..46f18c1a1b3 100644
--- a/openmetadata-ui/src/main/resources/ui/src/constants/Services.constant.ts
+++ b/openmetadata-ui/src/main/resources/ui/src/constants/Services.constant.ts
@@ -286,13 +286,16 @@ export const DEF_UI_SCHEMA = {
   supportsMetadataExtraction: { 'ui:widget': 'hidden', 'ui:hideError': true },
   supportsUsageExtraction: { 'ui:widget': 'hidden', 'ui:hideError': true },
   supportsLineageExtraction: { 'ui:widget': 'hidden', 'ui:hideError': true },
-  supportsViewLineageExtraction: { 'ui:widget': 'hidden', 'ui:hideError': true },
+  supportsViewLineageExtraction: {
+    'ui:widget': 'hidden',
+    'ui:hideError': true,
+  },
   supportsProfiler: { 'ui:widget': 'hidden', 'ui:hideError': true },
   supportsDatabase: { 'ui:widget': 'hidden', 'ui:hideError': true },
   supportsQueryComment: { 'ui:widget': 'hidden', 'ui:hideError': true },
   supportsDBTExtraction: { 'ui:widget': 'hidden', 'ui:hideError': true },
   type: { 'ui:widget': 'hidden' },
-}
+};
 
 export const INGESTION_ELASTIC_SEARCH_WORKFLOW_UI_SCHEMA = {
   useSSL: { 'ui:widget': 'hidden', 'ui:hideError': true },
diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/components/select.less b/openmetadata-ui/src/main/resources/ui/src/styles/components/select.less
index e28e757725b..3d42ab2e95f 100644
--- a/openmetadata-ui/src/main/resources/ui/src/styles/components/select.less
+++ b/openmetadata-ui/src/main/resources/ui/src/styles/components/select.less
@@ -50,3 +50,10 @@
     }
   }
 }
+
+.ant-select.trim-select {
+  .ant-select-selection-overflow {
+    max-height: 200px;
+    overflow-y: auto;
+  }
+}