From e19d0d9d678c96b8d9434b44538c24646155db64 Mon Sep 17 00:00:00 2001 From: pmbrull Date: Mon, 18 Apr 2022 16:41:05 +0200 Subject: [PATCH] dashboard services use URI as hostPort --- .../services/connections/dashboard/metabaseConnection.json | 2 +- .../services/connections/dashboard/tableauConnection.json | 3 ++- ingestion/examples/workflows/looker.json | 2 +- ingestion/examples/workflows/metabase.json | 2 +- ingestion/examples/workflows/tableau.json | 2 +- 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/metabaseConnection.json b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/metabaseConnection.json index 50beadde67e..954edda652a 100644 --- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/metabaseConnection.json +++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/metabaseConnection.json @@ -30,7 +30,7 @@ }, "hostPort": { "description": "Host and Port of Metabase instance.", - "type": "string" + "format": "uri" }, "dbServiceName": { "description": "Database Service Name for creation of lineage", diff --git a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/tableauConnection.json b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/tableauConnection.json index edb72d87afa..2dffa71fdfc 100644 --- a/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/tableauConnection.json +++ b/catalog-rest-service/src/main/resources/json/schema/entity/services/connections/dashboard/tableauConnection.json @@ -21,7 +21,8 @@ }, "hostPort": { "description": "Tableau Server", - "type": "string" + "type": "string", + "format": "uri" }, "username": { "description": "username for the Tableau", diff --git a/ingestion/examples/workflows/looker.json b/ingestion/examples/workflows/looker.json index b84d5a66a06..264fe494e53 100644 --- a/ingestion/examples/workflows/looker.json +++ b/ingestion/examples/workflows/looker.json @@ -7,7 +7,7 @@ "type": "Looker", "username": "username", "password": "password", - "hostPort": "hostPort", + "hostPort": "http://hostPort", "env": "env" } }, diff --git a/ingestion/examples/workflows/metabase.json b/ingestion/examples/workflows/metabase.json index 06e3932c43f..5443bda0b3a 100644 --- a/ingestion/examples/workflows/metabase.json +++ b/ingestion/examples/workflows/metabase.json @@ -7,7 +7,7 @@ "type": "Metabase", "username": "username", "password": "password", - "hostPort": "hostPort", + "hostPort": "http://hostPort", "dbServiceName": "Database Service Name to create Lineage" } }, diff --git a/ingestion/examples/workflows/tableau.json b/ingestion/examples/workflows/tableau.json index a5eb58bd74d..45ddd120865 100644 --- a/ingestion/examples/workflows/tableau.json +++ b/ingestion/examples/workflows/tableau.json @@ -8,7 +8,7 @@ "username": "username", "password": "password", "env": "tableau_prod", - "hostPort": "localhost", + "hostPort": "http://localhost", "siteName": "site_name", "apiVersion": "api_version", "personalAccessTokenName": "personal_access_token_name",