yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-28 17:23:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR BQ sampler type missing (#19696)

Browse Source 
* fix: missing entity type in bq sampler

* fix: failing tests
This commit is contained in:
Teddy 2025-02-11 10:46:34 -08:00 committed by GitHub
parent 92c9f0754b
commit e1b3e08317
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ingestion/src/metadata/sampler/sqlalchemy/bigquery/sampler.py
View File

@ -54,7 +54,6 @@ class BigQuerySampler(SQASampler):
sample_query: Optional[str] = None, sample_query: Optional[str] = None,
storage_config: DataStorageConfig = None, storage_config: DataStorageConfig = None,
sample_data_count: Optional[int] = SAMPLE_DATA_DEFAULT_COUNT, sample_data_count: Optional[int] = SAMPLE_DATA_DEFAULT_COUNT,
table_type: TableType = None,
**kwargs, **kwargs,
): ):
super().__init__( super().__init__(
@ -68,7 +67,7 @@ class BigQuerySampler(SQASampler):
sample_data_count=sample_data_count, sample_data_count=sample_data_count,
**kwargs, **kwargs,
) )
self.raw_dataset_type: TableType = table_type self.raw_dataset_type: Optional[TableType] = entity.tableType
def set_tablesample(self, selectable: SqaTable): def set_tablesample(self, selectable: SqaTable):
"""Set the TABLESAMPLE clause for BigQuery """Set the TABLESAMPLE clause for BigQuery

29
ingestion/tests/unit/profiler/sqlalchemy/bigquery/test_bigquery_sampling.py
View File

@ -127,14 +127,25 @@ class SampleTest(TestCase):
""" """
Test view sampling Test view sampling
""" """
view_entity = Table(
id=uuid4(),
name="user",
columns=[
EntityColumn(
name=ColumnName("id"),
dataType=DataType.INT,
),
],
tableType=TableType.View,
)
sampler = BigQuerySampler( sampler = BigQuerySampler(
service_connection_config=self.bq_conn, service_connection_config=self.bq_conn,
ometa_client=None, ometa_client=None,
entity=self.table_entity, entity=view_entity,
sample_config=SampleConfig( sample_config=SampleConfig(
profileSampleType=ProfileSampleType.PERCENTAGE, profileSample=50.0 profileSampleType=ProfileSampleType.PERCENTAGE, profileSample=50.0
), ),
table_type=TableType.View,
) )
query: CTE = sampler.get_sample_query() query: CTE = sampler.get_sample_query()
expected_query = ( expected_query = (
@ -151,10 +162,22 @@ class SampleTest(TestCase):
""" """
Test view sampling with partition Test view sampling with partition
""" """
view_entity = Table(
id=uuid4(),
name="user",
columns=[
EntityColumn(
name=ColumnName("id"),
dataType=DataType.INT,
),
],
tableType=TableType.View,
)
sampler = BigQuerySampler( sampler = BigQuerySampler(
service_connection_config=self.bq_conn, service_connection_config=self.bq_conn,
ometa_client=None, ometa_client=None,
entity=self.table_entity, entity=view_entity,
sample_config=SampleConfig( sample_config=SampleConfig(
profileSampleType=ProfileSampleType.PERCENTAGE, profileSample=50.0 profileSampleType=ProfileSampleType.PERCENTAGE, profileSample=50.0
), ),