diff --git a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/Lineage.spec.ts b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/Lineage.spec.ts index 444ad1d4a9b..bcc6de33b36 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/Lineage.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Flow/Lineage.spec.ts @@ -82,6 +82,30 @@ const deleteNode = (node) => { verifyResponseStatusCode('@lineageDeleteApi', 200); }; +const deleteEdge = (fromNode, toNode) => { + interceptURL('DELETE', '/api/v1/lineage/**', 'lineageDeleteApi'); + cy.get(`[data-testid="edge-${fromNode.fqn}-${toNode.fqn}"]`).click({ + force: true, + }); + + if ( + ['Table', 'Topic'].indexOf(fromNode.entityType) > -1 && + ['Table', 'Topic'].indexOf(toNode.entityType) > -1 + ) { + cy.get('[data-testid="add-pipeline"]').click(); + + cy.get( + '[data-testid="add-edge-modal"] [data-testid="remove-edge-button"]' + ).click(); + } else { + cy.get('[data-testid="delete-button"]').click(); + } + cy.get( + '[data-testid="delete-edge-confirmation-modal"] .ant-btn-primary' + ).click(); + verifyResponseStatusCode('@lineageDeleteApi', 200); +}; + const applyPipelineFromModal = (fromNode, toNode, pipelineData) => { interceptURL('PUT', '/api/v1/lineage', 'lineageApi'); cy.get(`[data-testid="edge-${fromNode.fqn}-${toNode.fqn}"]`).click({ @@ -244,10 +268,10 @@ describe('Lineage verification', { tags: 'DataAssets' }, () => { // Delete Nodes for (let i = 0; i < LINEAGE_ITEMS.length; i++) { if (i !== index) { - deleteNode(LINEAGE_ITEMS[i]); - cy.get(`[data-testid="lineage-node-${LINEAGE_ITEMS[i].fqn}"]`).should( - 'not.exist' - ); + deleteEdge(entity, LINEAGE_ITEMS[i]); + cy.get( + `[data-testid="edge-${entity.fqn}-${LINEAGE_ITEMS[i].fqn}"]` + ).should('not.exist'); } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/AppContainer/AppContainer.tsx b/openmetadata-ui/src/main/resources/ui/src/components/AppContainer/AppContainer.tsx index b4208d6b409..427d28b7a0e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/AppContainer/AppContainer.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/AppContainer/AppContainer.tsx @@ -22,6 +22,7 @@ import SignUpPage from '../../pages/SignUp/SignUpPage'; import applicationRoutesClass from '../../utils/ApplicationRoutesClassBase'; import Appbar from '../AppBar/Appbar'; import LeftSidebar from '../MyData/LeftSidebar/LeftSidebar.component'; +import applicationsClassBase from '../Settings/Applications/AppDetails/ApplicationsClassBase'; import './app-container.less'; const AppContainer = () => { @@ -29,7 +30,7 @@ const AppContainer = () => { const { Header, Sider, Content } = Layout; const { currentUser } = useApplicationStore(); const AuthenticatedRouter = applicationRoutesClass.getRouteElements(); - + const ApplicationExtras = applicationsClassBase.getApplicationExtension(); const isDirectionRTL = useMemo(() => i18n.dir() === 'rtl', [i18n]); return ( @@ -53,6 +54,7 @@ const AppContainer = () => { + {ApplicationExtras && } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTab/SchemaTab.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTab/SchemaTab.component.tsx index 42688375332..4371bc74302 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTab/SchemaTab.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaTab/SchemaTab.component.tsx @@ -11,13 +11,10 @@ * limitations under the License. */ -import { Button } from 'antd'; import { t } from 'i18next'; import { lowerCase } from 'lodash'; -import React, { Fragment, FunctionComponent, useMemo, useState } from 'react'; -import EntityLink from '../../../utils/EntityLink'; +import React, { Fragment, FunctionComponent, useState } from 'react'; import Searchbar from '../../common/SearchBarComponent/SearchBar.component'; -import { useSuggestionsContext } from '../../Suggestions/SuggestionsProvider/SuggestionsProvider'; import SchemaTable from '../SchemaTable/SchemaTable.component'; import { Props } from './SchemaTab.interfaces'; @@ -34,20 +31,11 @@ const SchemaTab: FunctionComponent = ({ tableConstraints, }: Props) => { const [searchText, setSearchText] = useState(''); - const { selectedUserSuggestions } = useSuggestionsContext(); const handleSearchAction = (searchValue: string) => { setSearchText(searchValue); }; - const columnSuggestions = useMemo( - () => - selectedUserSuggestions?.filter( - (item) => EntityLink.getTableColumnName(item.entityLink) !== undefined - ) ?? [], - [selectedUserSuggestions] - ); - return (
@@ -60,11 +48,6 @@ const SchemaTab: FunctionComponent = ({ onSearch={handleSearchAction} />
- {columnSuggestions.length > 0 && ( - - )} ); @@ -86,7 +87,7 @@ const TableDescription = ({ return ( diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.component.tsx index 0204b596cbf..57a138ffe6c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.component.tsx @@ -76,7 +76,7 @@ import AppSchedule from '../AppSchedule/AppSchedule.component'; import { ApplicationTabs } from '../MarketPlaceAppDetails/MarketPlaceAppDetails.interface'; import './app-details.less'; import { AppAction } from './AppDetails.interface'; -import applicationSchemaClassBase from './ApplicationSchemaClassBase'; +import applicationsClassBase from './ApplicationsClassBase'; const AppDetails = () => { const { t } = useTranslation(); @@ -93,7 +93,7 @@ const AppDetails = () => { isRunLoading: false, isSaveLoading: false, }); - const UiSchema = applicationSchemaClassBase.getJSONUISchema(); + const UiSchema = applicationsClassBase.getJSONUISchema(); const fetchAppDetails = useCallback(async () => { setLoadingState((prev) => ({ ...prev, isFetchLoading: true })); @@ -104,7 +104,7 @@ const AppDetails = () => { }); setAppData(data); - const schema = await applicationSchemaClassBase.importSchema(fqn); + const schema = await applicationsClassBase.importSchema(fqn); setJsonSchema(schema.default); } catch (error) { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.test.tsx index 6095faf1c70..8956e35bbc8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/AppDetails.test.tsx @@ -138,7 +138,7 @@ jest.mock('../AppSchedule/AppSchedule.component', () => )) ); -jest.mock('./ApplicationSchemaClassBase', () => ({ +jest.mock('./ApplicationsClassBase', () => ({ importSchema: jest.fn().mockReturnValue({ default: ['table'] }), getJSONUISchema: jest.fn().mockReturnValue({}), })); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/ApplicationSchemaClassBase.ts b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/ApplicationsClassBase.ts similarity index 67% rename from openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/ApplicationSchemaClassBase.ts rename to openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/ApplicationsClassBase.ts index e6c006dbb8a..e65b50fdbc8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/ApplicationSchemaClassBase.ts +++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppDetails/ApplicationsClassBase.ts @@ -11,7 +11,9 @@ * limitations under the License. */ -class ApplicationSchemaClassBase { +import { FC } from 'react'; + +class ApplicationsClassBase { public importSchema(fqn: string) { return import(`../../../../utils/ApplicationSchemas/${fqn}.json`); } @@ -21,9 +23,17 @@ class ApplicationSchemaClassBase { public importAppLogo(appName: string) { return import(`../../../../assets/svg/${appName}.svg`); } + /** + * Used to pass extra elements from installed Apps. + * + * @return {FC | null} The application extension, or null if none exists. + */ + public getApplicationExtension(): FC | null { + return null; + } } -const applicationSchemaClassBase = new ApplicationSchemaClassBase(); +const applicationsClassBase = new ApplicationsClassBase(); -export default applicationSchemaClassBase; -export { ApplicationSchemaClassBase }; +export default applicationsClassBase; +export { ApplicationsClassBase }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppLogo/AppLogo.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppLogo/AppLogo.component.tsx index 27420d5eec3..06cf150ade5 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppLogo/AppLogo.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Settings/Applications/AppLogo/AppLogo.component.tsx @@ -12,7 +12,7 @@ */ import { Avatar } from 'antd'; import React, { useCallback, useEffect, useState } from 'react'; -import applicationSchemaClassBase from '../AppDetails/ApplicationSchemaClassBase'; +import applicationsClassBase from '../AppDetails/ApplicationsClassBase'; const AppLogo = ({ logo, @@ -25,7 +25,7 @@ const AppLogo = ({ const fetchLogo = useCallback(async () => { if (!logo) { - const data = await applicationSchemaClassBase.importAppLogo(appName); + const data = await applicationsClassBase.importAppLogo(appName); const Icon = data.ReactComponent as React.ComponentType< JSX.IntrinsicElements['svg'] >; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.interface.ts b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.interface.ts index 189c4a40a86..4bf345015c6 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.interface.ts +++ b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.interface.ts @@ -16,4 +16,5 @@ export interface SuggestionsAlertProps { suggestion: Suggestion; hasEditAccess?: boolean; maxLength?: number; + showSuggestedBy?: boolean; } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.tsx index 0171c5eec89..0bfb712a088 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsAlert/SuggestionsAlert.tsx @@ -11,7 +11,7 @@ * limitations under the License. */ import { CheckOutlined, CloseOutlined } from '@ant-design/icons'; -import { Button, Card, Space, Typography } from 'antd'; +import { Button, Card, Typography } from 'antd'; import React from 'react'; import { useTranslation } from 'react-i18next'; import { ReactComponent as StarIcon } from '../../../assets/svg/ic-suggestions.svg'; @@ -27,6 +27,7 @@ const SuggestionsAlert = ({ suggestion, hasEditAccess = false, maxLength, + showSuggestedBy = true, }: SuggestionsAlertProps) => { const { t } = useTranslation(); const { acceptRejectSuggestion } = useSuggestionsContext(); @@ -37,60 +38,59 @@ const SuggestionsAlert = ({ } return ( - - -
- -
-
-
- - - {t('label.suggested-by')} - - - - - - -
- {hasEditAccess && ( -
-
+ +
+ +
+
+
+ {showSuggestedBy && ( + <> + + + {t('label.suggested-by')} + + + + + + + )}
- - + + {hasEditAccess && ( +
+
+ )} +
+ ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.interface.ts b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.interface.ts index 2095bbd350f..6537b0ddf21 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.interface.ts +++ b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.interface.ts @@ -24,7 +24,7 @@ export interface SuggestionsContextType { loadingAccept: boolean; loadingReject: boolean; allSuggestionsUsers: EntityReference[]; - onUpdateActiveUser: (user: EntityReference) => void; + onUpdateActiveUser: (user?: EntityReference) => void; fetchSuggestions: (entityFqn: string) => void; acceptRejectSuggestion: ( suggestion: Suggestion, diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.tsx index 0b13e57e66a..05e8f4b87e0 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsProvider/SuggestionsProvider.tsx @@ -119,7 +119,7 @@ const SuggestionsProvider = ({ children }: { children?: ReactNode }) => { ); const onUpdateActiveUser = useCallback( - (user: EntityReference) => { + (user?: EntityReference) => { setActiveUser(user); }, [suggestionsByUser] diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsSlider/SuggestionsSlider.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsSlider/SuggestionsSlider.tsx index 94eb966d19a..810b49e81df 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsSlider/SuggestionsSlider.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Suggestions/SuggestionsSlider/SuggestionsSlider.tsx @@ -10,7 +10,8 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { Button, Typography } from 'antd'; +import { CheckOutlined, CloseOutlined } from '@ant-design/icons'; +import { Button, Space, Typography } from 'antd'; import { t } from 'i18next'; import React from 'react'; import { SuggestionType } from '../../../generated/entity/feed/suggestion'; @@ -24,6 +25,7 @@ const SuggestionsSlider = () => { acceptRejectAllSuggestions, loadingAccept, loadingReject, + onUpdateActiveUser, } = useSuggestionsContext(); return ( @@ -33,11 +35,13 @@ const SuggestionsSlider = () => { {selectedUserSuggestions.length > 0 && ( - <> + - + + )}
); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.test.tsx index 8c74fd23c21..9edf8baf92e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.test.tsx @@ -10,7 +10,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { fireEvent, render, screen } from '@testing-library/react'; +import { render, screen } from '@testing-library/react'; import React from 'react'; import AvatarCarousel from './AvatarCarousel'; @@ -35,6 +35,7 @@ jest.mock('../../Suggestions/SuggestionsProvider/SuggestionsProvider', () => ({ { id: '2', name: 'Avatar 2', type: 'user' }, ], acceptRejectSuggestion: jest.fn(), + selectedUserSuggestions: [], onUpdateActiveUser: jest.fn(), })), __esModule: true, @@ -70,19 +71,10 @@ jest.mock('../../../rest/suggestionsAPI', () => ({ describe('AvatarCarousel', () => { it('renders without crashing', () => { - render(); + render(); expect(screen.getByText(/Avatar 1/i)).toBeInTheDocument(); expect(screen.getByText(/Avatar 2/i)).toBeInTheDocument(); expect(screen.getByTestId('prev-slide')).toBeDisabled(); }); - - it('disables the next button when on the last slide', () => { - render(); - const nextButton = screen.getByTestId('next-slide'); - fireEvent.click(nextButton); - fireEvent.click(nextButton); - - expect(nextButton).toBeDisabled(); - }); }); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.tsx index 07f232764bf..58e52d48f4b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/AvatarCarousel.tsx @@ -11,16 +11,24 @@ * limitations under the License. */ import { LeftOutlined, RightOutlined } from '@ant-design/icons'; -import { Button, Carousel } from 'antd'; +import { Badge, Button, Carousel } from 'antd'; +import classNames from 'classnames'; import React, { useCallback, useEffect, useState } from 'react'; import { useSuggestionsContext } from '../../Suggestions/SuggestionsProvider/SuggestionsProvider'; import UserPopOverCard from '../PopOverCard/UserPopOverCard'; import ProfilePicture from '../ProfilePicture/ProfilePicture'; import './avatar-carousel.less'; -const AvatarCarousel = () => { - const { allSuggestionsUsers: avatarList, onUpdateActiveUser } = - useSuggestionsContext(); +interface AvatarCarouselProps { + showArrows?: boolean; +} + +const AvatarCarousel = ({ showArrows = false }: AvatarCarouselProps) => { + const { + allSuggestionsUsers: avatarList, + onUpdateActiveUser, + selectedUserSuggestions, + } = useSuggestionsContext(); const [currentSlide, setCurrentSlide] = useState(-1); const prevSlide = useCallback(() => { @@ -43,48 +51,69 @@ const AvatarCarousel = () => { onProfileClick(currentSlide); }, [currentSlide]); + useEffect(() => { + if (selectedUserSuggestions.length === 0) { + setCurrentSlide(-1); + } + }, [selectedUserSuggestions]); + return (
- - - ))} + ); + + return ( + + {isActive ? ( // Show Badge only for active item + {button} + ) : ( + button + )} + + ); + })} -
); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/avatar-carousel.less b/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/avatar-carousel.less index ff03595271c..a3059609a85 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/avatar-carousel.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/AvatarCarousel/avatar-carousel.less @@ -13,20 +13,42 @@ @import url('../../../styles/variables.less'); .avatar-item { - opacity: 0.4; - &.active { - opacity: 1; - } + position: relative; &:hover { border-color: @border-color !important; } &:focus { border-color: @border-color !important; } + &.ant-btn { + width: 28px; + height: 28px; + min-width: 28px; + } } .avatar-carousel-container { .slick-slide { width: 32px !important; } + .slick-list { + overflow: visible !important; + } + .ant-badge-count { + right: 4px; + background-color: @red-3; + } +} + +.slider-btn-container { + .ant-btn { + padding: 0 10px; + height: 30px; + } + .ant-btn.exit-suggestion { + color: @grey-4; + border-color: @grey-4; + padding: 0; + width: 30px; + } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/DescriptionV1.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/DescriptionV1.tsx index c5a840bc16f..864fd2e40fa 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/DescriptionV1.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/DescriptionV1.tsx @@ -205,7 +205,7 @@ const DescriptionV1 = ({ data-testid="asset-description-container" direction="vertical" size={16}> -
+
{t('label.description')} {showActions && actionButtons} diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.component.tsx index 86062a5b2bf..1207464226c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.component.tsx @@ -24,7 +24,7 @@ import FormBuilder from '../../components/common/FormBuilder/FormBuilder'; import Loader from '../../components/common/Loader/Loader'; import TestSuiteScheduler from '../../components/DataQuality/AddDataQualityTest/components/TestSuiteScheduler'; import PageLayoutV1 from '../../components/PageLayoutV1/PageLayoutV1'; -import applicationSchemaClassBase from '../../components/Settings/Applications/AppDetails/ApplicationSchemaClassBase'; +import applicationSchemaClassBase from '../../components/Settings/Applications/AppDetails/ApplicationsClassBase'; import AppInstallVerifyCard from '../../components/Settings/Applications/AppInstallVerifyCard/AppInstallVerifyCard.component'; import IngestionStepper from '../../components/Settings/Services/Ingestion/IngestionStepper/IngestionStepper.component'; import { STEPS_FOR_APP_INSTALL } from '../../constants/Applications.constant'; diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.test.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.test.tsx index 9b2bd5a768c..f887af1ca70 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/AppInstall/AppInstall.test.tsx @@ -48,7 +48,7 @@ jest.mock( ); jest.mock( - '../../components/Settings/Applications/AppDetails/ApplicationSchemaClassBase', + '../../components/Settings/Applications/AppDetails/ApplicationsClassBase', () => ({ importSchema: jest.fn().mockResolvedValue({}), getJSONUISchema: jest.fn().mockReturnValue({}), diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx index d719392aff7..9e9999e3624 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/TableDetailsPageV1/TableDetailsPageV1.tsx @@ -104,9 +104,6 @@ import TableConstraints from './TableConstraints/TableConstraints'; const TableDetailsPageV1: React.FC = () => { const { isTourOpen, activeTabForTourDatasetPage, isTourPage } = useTourProvider(); - const FloatingButton = entityUtilClassBase.getEntityFloatingButton( - EntityType.TABLE - ); const { currentUser } = useApplicationStore(); const [tableDetails, setTableDetails] = useState(); const { tab: activeTab = EntityTabs.SCHEMA } = @@ -1075,8 +1072,6 @@ const TableDetailsPageV1: React.FC = () => { onCancel={onThreadPanelClose} /> ) : null} - - {FloatingButton && } );