From e2e32d9f0c918c47083b610de4fcdf6193a8d5cc Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Wed, 9 Oct 2024 16:51:21 +0530
Subject: [PATCH] PLAYWRIGHT: fix activityFeed and DataInsight AUT playwright
 test (#18180)

* fix activityFeed and DataInsight AUT playwright test

* minor improvement

(cherry picked from commit af713adaa7f90a207167f060b80c3743b0869d86)
---
 .../resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts | 2 ++
 .../src/components/Entity/Task/TaskTab/TaskTab.component.tsx  | 4 ++--
 .../main/resources/ui/src/pages/DataInsightPage/KPIList.tsx   | 1 +
 openmetadata-ui/src/main/resources/ui/src/styles/app.less     | 3 ++-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts
index e535d84ec4e..3f395b4d061 100644
--- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts
+++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts
@@ -30,6 +30,7 @@ import {
 } from '../../utils/activityFeed';
 import { performAdminLogin } from '../../utils/admin';
 import {
+  clickOutside,
   descriptionBox,
   redirectToHomePage,
   removeLandingBanner,
@@ -877,6 +878,7 @@ base.describe('Activity feed with Data Consumer User', () => {
         const dropdownValue = page2.getByTestId(`tag-PII.None`);
         await dropdownValue.hover();
         await dropdownValue.click();
+        await clickOutside(page2);
 
         await expect(page2.getByTestId('selected-tag-PII.None')).toBeVisible();
 
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/TaskTab.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/TaskTab.component.tsx
index 705ffd5b7c1..06fe575e1a3 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/TaskTab.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Entity/Task/TaskTab/TaskTab.component.tsx
@@ -956,9 +956,9 @@ export const TaskTab = ({
       {isTaskTestCaseResult ? (
         <Modal
           destroyOnClose
-          maskClosable
           closable={false}
           closeIcon={null}
+          maskClosable={false}
           okButtonProps={{
             loading: isActionLoading,
           }}
@@ -1019,9 +1019,9 @@ export const TaskTab = ({
       ) : (
         <Modal
           destroyOnClose
-          maskClosable
           closable={false}
           closeIcon={null}
+          maskClosable={false}
           open={showEditTaskModel}
           title={`${t('label.edit-entity', {
             entity: t('label.task-lowercase'),
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/DataInsightPage/KPIList.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/DataInsightPage/KPIList.tsx
index dca8ec058a7..0c2454b77a2 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/DataInsightPage/KPIList.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/DataInsightPage/KPIList.tsx
@@ -234,6 +234,7 @@ const KPIList = () => {
       <Col span={24}>
         <Table
           bordered
+          className="kpi-table"
           columns={columns}
           data-testid="kpi-table"
           dataSource={kpiList}
diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/app.less b/openmetadata-ui/src/main/resources/ui/src/styles/app.less
index 5a327fe1f3f..fb47ca5fc67 100644
--- a/openmetadata-ui/src/main/resources/ui/src/styles/app.less
+++ b/openmetadata-ui/src/main/resources/ui/src/styles/app.less
@@ -827,7 +827,8 @@ a[href].link-text-grey,
   .activity-feed-editor-drawer,
   .policies-list-table,
   .roles-list-table,
-  .list-table {
+  .list-table,
+  .kpi-table {
     margin-right: 64px;
   }
 }