yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-25 08:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Validate JSON and YAML config files (#4824)

Browse Source
This commit is contained in:
Pere Miquel Brull 2022-05-10 09:32:56 +02:00 committed by GitHub
parent a774a67ffa
commit e818fcd2de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ingestion/src/metadata/config/common.py
View File

@ -19,6 +19,10 @@ from typing import IO, Any, Optional
import yaml import yaml
from pydantic import BaseModel from pydantic import BaseModel
from metadata.utils.logger import ingestion_logger
logger = ingestion_logger()
FQDN_SEPARATOR: str = "." FQDN_SEPARATOR: str = "."
@ -50,16 +54,26 @@ class YamlConfigurationMechanism(ConfigurationMechanism):
"""load configuration from yaml files""" """load configuration from yaml files"""
def load_config(self, config_fp: IO) -> dict: def load_config(self, config_fp: IO) -> dict:
config = yaml.safe_load(config_fp) try:
return config config = yaml.safe_load(config_fp)
return config
except yaml.error.YAMLError:
msg = "YAML Configuration file is not a valid YAML"
logger.error(msg)
raise ConfigurationError(msg)
class JsonConfigurationMechanism(ConfigurationMechanism): class JsonConfigurationMechanism(ConfigurationMechanism):
"""load configuration from json files""" """load configuration from json files"""
def load_config(self, config_fp: IO) -> dict: def load_config(self, config_fp: IO) -> dict:
config = json.load(config_fp) try:
return config config = json.load(config_fp)
return config
except json.decoder.JSONDecodeError:
msg = "JSON Configuration file is not a valid JSON"
logger.error(msg)
raise ConfigurationError(msg)
def load_config_file(config_file: pathlib.Path) -> dict: def load_config_file(config_file: pathlib.Path) -> dict: