From e9a888fce7e1a6762e9ee5dac724dca8228dad10 Mon Sep 17 00:00:00 2001 From: Sriharsha Chintalapani Date: Tue, 5 Nov 2024 08:55:02 -0800 Subject: [PATCH] Fix tests (#18494) * Fix TestCaseResource testCaseInheritedFields * Fix TableResourceTest * Fix tests * remove setInheritedFields in listing of search entities * Fix tests * remove unique entity name creations * add specific names in search listing tests * add large size for fetching from ES, as other tests adds to the table_search_index * Fix tests * fix tests --- .../service/jdbi3/EntityRepository.java | 4 +- .../resources/dqtests/TestSuiteResource.java | 2 +- .../service/search/SearchRepository.java | 5 ++ .../elasticsearch/ElasticSearchClient.java | 2 +- .../databases/TableResourceTest.java | 15 +++- .../dqtests/TestCaseResourceTest.java | 76 +++++++++++++------ .../dqtests/TestSuiteResourceTest.java | 30 ++++++-- .../resources/query/QueryResourceTest.java | 4 +- .../services/APIServiceResourceTest.java | 5 +- .../DashboardServiceResourceTest.java | 10 ++- .../services/DatabaseServiceResourceTest.java | 17 +++-- .../services/MetadataServiceResourceTest.java | 5 +- .../services/MlModelServiceResourceTest.java | 5 +- .../services/PipelineServiceResourceTest.java | 12 ++- .../services/SearchServiceResourceTest.java | 5 +- .../services/StorageServiceResourceTest.java | 5 +- 16 files changed, 141 insertions(+), 61 deletions(-) diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java index e71a280314b..b93594c72bd 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java @@ -1202,9 +1202,7 @@ public abstract class EntityRepository { searchListFilter, limit, offset, entityType, searchSortFilter, q); total = results.getTotal(); for (Map json : results.getResults()) { - T entity = setFieldsInternal(JsonUtils.readOrConvertValue(json, entityClass), fields); - setInheritedFields(entity, fields); - clearFieldsInternal(entity, fields); + T entity = JsonUtils.readOrConvertValue(json, entityClass); entityList.add(withHref(uriInfo, entity)); } return new ResultList<>(entityList, offset, limit, total.intValue()); diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestSuiteResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestSuiteResource.java index f1eba18f6b8..bc4887c1d5d 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestSuiteResource.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestSuiteResource.java @@ -292,7 +292,7 @@ public class TestSuiteResource extends EntityResource { private final TagResourceTest tagResourceTest = new TagResourceTest(); private final DatabaseServiceResourceTest dbServiceTest = new DatabaseServiceResourceTest(); @@ -2471,6 +2472,7 @@ public class TableResourceTest extends EntityResourceTest { // Create an entity without column description CreateTable createWithNullColumnDescription = createRequest(test, 1) + .withName("tableWithNullColumnDescription") .withDatabaseSchema(schema.getFullyQualifiedName()) .withDescription("description") .withColumns(listOf(columnWithNullDescription)) @@ -2480,6 +2482,7 @@ public class TableResourceTest extends EntityResourceTest { // Create an entity with empty column description CreateTable createWithEmptyColumnDescription = createRequest(test, 2) + .withName("tableWithEmptyColumnDescription") .withDatabaseSchema(schema.getFullyQualifiedName()) .withDescription("description") .withColumns(listOf(columnWithEmptyDescription)) @@ -2489,6 +2492,7 @@ public class TableResourceTest extends EntityResourceTest { // Create an entity with null description but with column description CreateTable createWithNullDescription = createRequest(test, 6) + .withName("tableWithNullDescription") .withDatabaseSchema(schema.getFullyQualifiedName()) .withDescription(null) .withColumns(listOf(columnWithDescription)) @@ -2497,6 +2501,7 @@ public class TableResourceTest extends EntityResourceTest { // Create an entity with description complete CreateTable createWithDescription = createRequest(test, 4) + .withName("tableWithDescription") .withDatabaseSchema(schema.getFullyQualifiedName()) .withDescription("description") .withColumns(listOf(columnWithDescription)) @@ -2507,6 +2512,14 @@ public class TableResourceTest extends EntityResourceTest { RestClient searchClient = getSearchClient(); IndexMapping index = Entity.getSearchRepository().getIndexMapping(TABLE); Response response; + // lets refresh the indexes before calling search + Request refreshRequest = + new Request( + "POST", + String.format( + "%s/_refresh", index.getIndexName(Entity.getSearchRepository().getClusterAlias()))); + searchClient.performRequest(refreshRequest); + // Direct request to es needs to have es clusterAlias appended with indexName Request request = new Request( @@ -2514,7 +2527,7 @@ public class TableResourceTest extends EntityResourceTest { String.format( "%s/_search", index.getIndexName(Entity.getSearchRepository().getClusterAlias()))); String query = - "{\"size\": 100,\"query\":{\"bool\":{\"must\":[{\"term\":{\"descriptionStatus\":\"INCOMPLETE\"}}]}}}"; + "{\"size\": 1000,\"query\":{\"bool\":{\"must\":[{\"term\":{\"descriptionStatus\":\"INCOMPLETE\"}}]}}}"; request.setJsonEntity(query); response = searchClient.performRequest(request); searchClient.close(); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java index e2f40cb61dd..d3cf7b2675c 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java @@ -17,6 +17,7 @@ import static javax.ws.rs.core.Response.Status.BAD_REQUEST; import static javax.ws.rs.core.Response.Status.FORBIDDEN; import static javax.ws.rs.core.Response.Status.NOT_FOUND; import static javax.ws.rs.core.Response.Status.OK; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotEquals; @@ -25,6 +26,7 @@ import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; import static org.openmetadata.common.utils.CommonUtil.listOf; +import static org.openmetadata.schema.api.teams.CreateTeam.TeamType.GROUP; import static org.openmetadata.schema.type.ColumnDataType.BIGINT; import static org.openmetadata.schema.type.MetadataOperation.EDIT_TESTS; import static org.openmetadata.service.Entity.ADMIN_USER_NAME; @@ -59,6 +61,7 @@ import java.util.*; import java.util.stream.Collectors; import javax.ws.rs.client.WebTarget; import lombok.extern.slf4j.Slf4j; +import org.apache.commons.lang.RandomStringUtils; import org.apache.http.client.HttpResponseException; import org.apache.http.util.EntityUtils; import org.junit.jupiter.api.Assertions; @@ -72,12 +75,16 @@ import org.junit.jupiter.api.parallel.ExecutionMode; import org.openmetadata.schema.api.data.CreateTable; import org.openmetadata.schema.api.feed.CloseTask; import org.openmetadata.schema.api.feed.ResolveTask; +import org.openmetadata.schema.api.teams.CreateTeam; +import org.openmetadata.schema.api.teams.CreateUser; import org.openmetadata.schema.api.tests.CreateTestCase; import org.openmetadata.schema.api.tests.CreateTestCaseResolutionStatus; import org.openmetadata.schema.api.tests.CreateTestCaseResult; import org.openmetadata.schema.api.tests.CreateTestSuite; import org.openmetadata.schema.entity.data.Table; import org.openmetadata.schema.entity.feed.Thread; +import org.openmetadata.schema.entity.teams.Team; +import org.openmetadata.schema.entity.teams.User; import org.openmetadata.schema.tests.DataQualityReport; import org.openmetadata.schema.tests.ResultSummary; import org.openmetadata.schema.tests.TestCase; @@ -109,6 +116,8 @@ import org.openmetadata.service.resources.EntityResourceTest; import org.openmetadata.service.resources.databases.TableResourceTest; import org.openmetadata.service.resources.feeds.FeedResourceTest; import org.openmetadata.service.resources.feeds.MessageParser; +import org.openmetadata.service.resources.teams.TeamResourceTest; +import org.openmetadata.service.resources.teams.UserResourceTest; import org.openmetadata.service.search.SearchAggregation; import org.openmetadata.service.search.SearchIndexUtils; import org.openmetadata.service.search.SearchRepository; @@ -617,6 +626,21 @@ public class TestCaseResourceTest extends EntityResourceTest tables = new ArrayList<>(); Map testSuites = new HashMap<>(); @@ -646,7 +670,7 @@ public class TestCaseResourceTest extends EntityResourceTest allEntities = listEntitiesFromSearch(queryParams, testCasesNum, 0, ADMIN_AUTH_HEADERS); assertEquals(testCasesNum, allEntities.getData().size()); - queryParams.put("q", "test_getSimpleListFromSearchc"); + queryParams.put("q", "test_getSimpleListFromSearchb"); allEntities = listEntitiesFromSearch(queryParams, testCasesNum, 0, ADMIN_AUTH_HEADERS); assertEquals(1, allEntities.getData().size()); - org.assertj.core.api.Assertions.assertThat(allEntities.getData().get(0).getName()) - .contains("test_getSimpleListFromSearchc"); + assertThat(allEntities.getData().get(0).getName()).contains("test_getSimpleListFromSearchb"); queryParams.clear(); queryParams.put("entityLink", testCaseForEL.getEntityLink()); queryParams.put("includeAllTests", "true"); allEntities = listEntitiesFromSearch(queryParams, testCasesNum, 0, ADMIN_AUTH_HEADERS); assertEquals(1, allEntities.getData().size()); - org.assertj.core.api.Assertions.assertThat(allEntities.getData().get(0).getEntityLink()) + assertThat(allEntities.getData().get(0).getEntityLink()) .contains(testCaseForEL.getEntityLink()); queryParams.clear(); @@ -727,12 +750,22 @@ public class TestCaseResourceTest extends EntityResourceTest { + assertTrue( + tc.getOwners().stream().anyMatch(owner -> owner.getId().equals(user2Ref.getId())), + String.format( + "Test case %s does not contain the expected owner %s", + tc.getName(), user2Ref.getName())); + }); - queryParams.put("owner", USER_TEAM21.getName()); + queryParams.put("owner", team.getName()); allEntities = listEntitiesFromSearch(queryParams, testCasesNum, 0, ADMIN_AUTH_HEADERS); assertEquals( 1, @@ -847,18 +880,20 @@ public class TestCaseResourceTest extends EntityResourceTest", table.getFullyQualifiedName(), C1)) + String.format( + "<#E::table::%s::columns::%s>", table.getFullyQualifiedName(), columnName)) .withTestSuite(testSuite.getFullyQualifiedName()) .withTestDefinition(TEST_DEFINITION3.getFullyQualifiedName()) .withParameterValues( @@ -897,7 +933,7 @@ public class TestCaseResourceTest extends EntityResourceTest actualTags = tags.stream().map(TagLabel::getName).collect(Collectors.toCollection(HashSet::new)); HashSet expectedTags; - if (testCase.getEntityLink().contains(C1)) { + if (testCase.getEntityLink().contains(columnName)) { expectedTags = new HashSet<>( List.of( @@ -917,7 +953,7 @@ public class TestCaseResourceTest extends EntityResourceTest tags = testCase.getTags(); - HashSet actualTags = - tags.stream().map(TagLabel::getName).collect(Collectors.toCollection(HashSet::new)); - HashSet expectedTags; - List expectedTagsList = table.getTags(); - if (testCase.getEntityLink().contains(C1)) { - expectedTagsList.addAll(table.getColumns().get(0).getTags()); - } - expectedTags = new HashSet<>(expectedTagsList.stream().map(TagLabel::getName).toList()); - assertEquals(expectedTags, actualTags); } } diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestSuiteResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestSuiteResourceTest.java index b4e0cff94a6..ceb09aedca8 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestSuiteResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestSuiteResourceTest.java @@ -7,6 +7,7 @@ import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.openmetadata.schema.api.teams.CreateTeam.TeamType.GROUP; import static org.openmetadata.service.util.TestUtils.ADMIN_AUTH_HEADERS; import static org.openmetadata.service.util.TestUtils.LONG_ENTITY_NAME; import static org.openmetadata.service.util.TestUtils.assertListNotNull; @@ -34,11 +35,15 @@ import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.TestInfo; import org.openmetadata.schema.api.data.CreateTable; +import org.openmetadata.schema.api.teams.CreateTeam; +import org.openmetadata.schema.api.teams.CreateUser; import org.openmetadata.schema.api.tests.CreateLogicalTestCases; import org.openmetadata.schema.api.tests.CreateTestCase; import org.openmetadata.schema.api.tests.CreateTestCaseResult; import org.openmetadata.schema.api.tests.CreateTestSuite; import org.openmetadata.schema.entity.data.Table; +import org.openmetadata.schema.entity.teams.Team; +import org.openmetadata.schema.entity.teams.User; import org.openmetadata.schema.tests.TestCase; import org.openmetadata.schema.tests.TestSuite; import org.openmetadata.schema.tests.type.TestCaseStatus; @@ -50,6 +55,8 @@ import org.openmetadata.schema.type.Include; import org.openmetadata.service.Entity; import org.openmetadata.service.resources.EntityResourceTest; import org.openmetadata.service.resources.databases.TableResourceTest; +import org.openmetadata.service.resources.teams.TeamResourceTest; +import org.openmetadata.service.resources.teams.UserResourceTest; import org.openmetadata.service.search.models.IndexMapping; import org.openmetadata.service.util.JsonUtils; import org.openmetadata.service.util.ResultList; @@ -315,6 +322,17 @@ public class TestSuiteResourceTest extends EntityResourceTest testCases1 = new ArrayList<>(); @@ -347,7 +365,7 @@ public class TestSuiteResourceTest extends EntityResourceTest teamOwnerTestSuites = listEntitiesFromSearch(queryParams, 100, 0, ADMIN_AUTH_HEADERS); Assertions.assertTrue( teamOwnerTestSuites.getData().stream() - .allMatch(ts -> ts.getOwners().get(0).getId().equals(TEAM11_REF.getId()))); + .allMatch(ts -> ts.getOwners().get(0).getId().equals(teamRef.getId()))); // 8.2 User owner queryParams.clear(); - queryParams.put("owner", USER1_REF.getFullyQualifiedName()); + queryParams.put("owner", user1Ref.getFullyQualifiedName()); queryParams.put("fields", "owners"); ResultList userOwnerTestSuites = listEntitiesFromSearch(queryParams, 100, 0, ADMIN_AUTH_HEADERS); Assertions.assertTrue( userOwnerTestSuites.getData().stream() - .allMatch(ts -> ts.getOwners().get(0).getId().equals(USER1_REF.getId()))); + .allMatch(ts -> ts.getOwners().get(0).getId().equals(user1Ref.getId()))); } @Test diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/query/QueryResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/query/QueryResourceTest.java index 06fed3c97a6..6474c7f6137 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/query/QueryResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/query/QueryResourceTest.java @@ -151,9 +151,9 @@ public class QueryResourceTest extends EntityResourceTest { @Test void post_same_query_forSameEntityType_409(TestInfo test) throws HttpResponseException { CreateQuery create = createRequest(getEntityName(test)); - createEntity(create, ADMIN_AUTH_HEADERS); + Query query = createEntity(create, ADMIN_AUTH_HEADERS); - CreateQuery create1 = createRequest(getEntityName(test)); + CreateQuery create1 = createRequest(query.getName()); assertResponse( () -> createEntity(create1, ADMIN_AUTH_HEADERS), diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/APIServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/APIServiceResourceTest.java index d135883f454..c54077a72fb 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/APIServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/APIServiceResourceTest.java @@ -113,7 +113,10 @@ public class APIServiceResourceTest extends ServiceResourceTest - createEntity( - createRequest(test).withDescription(null).withConnection(dbConn), - ADMIN_AUTH_HEADERS), + () -> createEntity(create, ADMIN_AUTH_HEADERS), BAD_REQUEST, String.format( "Failed to convert [%s] to type [Snowflake]. Review the connection.", - getEntityName(test))); + create.getName())); DatabaseService service = createAndCheckEntity(createRequest(test).withDescription(null), ADMIN_AUTH_HEADERS); // Update database description and ingestion service that are null - CreateDatabaseService update = createRequest(test).withDescription("description1"); + CreateDatabaseService update = + createRequest(test).withDescription("description1").withName(service.getName()); ChangeDescription change = getChangeDescription(service, MINOR_UPDATE); fieldAdded(change, "description", "description1"); @@ -244,7 +244,8 @@ public class DatabaseServiceResourceTest new DatabaseConnection().withConfig(snowflakeConnection); // Update database connection to a new connection - CreateDatabaseService update = createRequest(test).withConnection(databaseConnection); + CreateDatabaseService update = + createRequest(test).withConnection(databaseConnection).withName(service.getName()); ChangeDescription change = getChangeDescription(service, MINOR_UPDATE); fieldUpdated(change, "connection", oldDatabaseConnection, databaseConnection); service = updateAndCheckEntity(update, OK, ADMIN_AUTH_HEADERS, MINOR_UPDATE, change); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MetadataServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MetadataServiceResourceTest.java index 78c729653f8..a92f345792a 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MetadataServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MetadataServiceResourceTest.java @@ -135,7 +135,10 @@ public class MetadataServiceResourceTest .withPassword(secretPassword)); // Update metadata description CreateMetadataService update = - createRequest(test).withDescription("description1").withConnection(metadataConnection); + createRequest(test) + .withDescription("description1") + .withConnection(metadataConnection) + .withName(service.getName()); ChangeDescription change = getChangeDescription(service, MINOR_UPDATE); fieldAdded(change, "description", "description1"); service = updateAndCheckEntity(update, OK, ADMIN_AUTH_HEADERS, MINOR_UPDATE, change); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java index 2f77e570744..fa6b2a1eec0 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/MlModelServiceResourceTest.java @@ -123,7 +123,10 @@ public class MlModelServiceResourceTest .withTrackingUri("http://localhost:5001")); CreateMlModelService update = - createRequest(test).withDescription("description1").withConnection(MlModelConnection1); + createRequest(test) + .withDescription("description1") + .withConnection(MlModelConnection1) + .withName(service.getName()); ChangeDescription change = getChangeDescription(service, MINOR_UPDATE); fieldAdded(change, "description", "description1"); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/PipelineServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/PipelineServiceResourceTest.java index 66aa00875b6..1621214eabd 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/PipelineServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/PipelineServiceResourceTest.java @@ -123,7 +123,8 @@ public class PipelineServiceResourceTest createAndCheckEntity(createRequest(test).withDescription(null), ADMIN_AUTH_HEADERS); // Update pipeline description and ingestion service that are null - CreatePipelineService update = createRequest(test).withDescription("description1"); + CreatePipelineService update = + createRequest(test).withDescription("description1").withName(service.getName()); ChangeDescription change = getChangeDescription(service, MINOR_UPDATE); fieldAdded(change, "description", "description1"); @@ -156,15 +157,12 @@ public class PipelineServiceResourceTest void post_put_invalidConnection_as_admin_4xx(TestInfo test) { RedshiftConnection redshiftConnection = new RedshiftConnection(); PipelineConnection pipelineConnection = new PipelineConnection().withConfig(redshiftConnection); + CreatePipelineService create = createRequest(test).withConnection(pipelineConnection); assertResponseContains( - () -> - createEntity( - createRequest(test).withDescription(null).withConnection(pipelineConnection), - ADMIN_AUTH_HEADERS), + () -> createEntity(create, ADMIN_AUTH_HEADERS), BAD_REQUEST, String.format( - "Failed to convert [%s] to type [Airflow]. Review the connection.", - getEntityName(test))); + "Failed to convert [%s] to type [Airflow]. Review the connection.", create.getName())); } @Test diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/SearchServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/SearchServiceResourceTest.java index db5af6d2ed1..41b1b4c497f 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/SearchServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/SearchServiceResourceTest.java @@ -110,7 +110,10 @@ public class SearchServiceResourceTest // Update SearchService description and connection CreateSearchService update = - createRequest(test).withDescription("description1").withConnection(connection2); + createRequest(test) + .withDescription("description1") + .withConnection(connection2) + .withName(service.getName()); ChangeDescription change = getChangeDescription(service, MINOR_UPDATE); fieldAdded(change, "description", "description1"); diff --git a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java index e66a5ef3413..6b9bef58db2 100644 --- a/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java +++ b/openmetadata-service/src/test/java/org/openmetadata/service/resources/services/StorageServiceResourceTest.java @@ -106,7 +106,10 @@ public class StorageServiceResourceTest // Update StorageService description and connection CreateStorageService update = - createRequest(test).withDescription("description1").withConnection(connection2); + createRequest(test) + .withDescription("description1") + .withConnection(connection2) + .withName(service.getName()); ChangeDescription change = getChangeDescription(service, MINOR_UPDATE); fieldAdded(change, "description", "description1");