yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-03 14:47:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

UI: Improved Add tag UX and added services search-bar back Also fixed services loader issue (#1043)

Browse Source 
* UI: Improved Add tag UX and added services search-bar back Also fixed services loader issue

* Addressing comments
This commit is contained in:
darth-coder00 2021-11-03 19:02:28 +05:30 committed by GitHub
parent 4cc922c885
commit ea4e3b4319
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
catalog-rest-service/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx
View File

@ -516,12 +516,8 @@ const EntityTable = ({
/>
</button>
) : (
<span className="tw-opacity-0 group-hover:tw-opacity-100">
<Tags
className="tw-border-main"
tag="+ Add tag"
type="outlined"
/>
<span className="tw-opacity-60 group-hover:tw-opacity-100 tw-text-grey-muted group-hover:tw-text-primary">
<Tags tag="+ Add tag" type="outlined" />
</span>
)
) : null}
@ -567,7 +563,7 @@ const EntityTable = ({
</div>
{checkIfJoinsAvailable(row.original.name) && (
<div className="tw-mt-3">
<span className="tw-text-gray-400 tw-mr-1">
<span className="tw-text-grey-muted tw-mr-1">
Frequently joined columns:
</span>
<span>

8
catalog-rest-service/src/main/resources/ui/src/pages/services/index.tsx
View File

@ -394,7 +394,11 @@ const ServicesPage = () => {
value: service.collection.name,
};
});
setIsLoading(false);
// Removed "setIsLoading(false)" from here,
// If there are service categories available
// Loader should wait for each category to fetch list of services
// Then only it should stop Loading and show available data or No data template
// This is handled in "updateServiceList" method
} else {
setIsLoading(false);
}
@ -423,7 +427,7 @@ const ServicesPage = () => {
</div>
<div className="tw-flex">
<div className="tw-w-4/12">
{searchText || serviceList.length > 10 ? (
{searchText || serviceList.length > 0 ? (
<Searchbar
placeholder={`Search for ${servicesDisplayName[serviceName]}...`}
searchValue={searchText}