fix(ui): missing localization key for delete widget (#9600)

This commit is contained in:
Chirag Madlani 2023-01-05 10:00:50 +05:30 committed by GitHub
parent 0d71d15b04
commit ea84695648
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 18 additions and 19 deletions

View File

@ -78,7 +78,7 @@ describe('Teams flow should work properly', () => {
it('Add user to created team', () => {
interceptURL('GET', '/api/v1/users*', 'getUsers');
interceptURL('GET', `/api/v1/users?fields=teams,roles&team=${TEAM_DETAILS.name}&limit=15`, 'getUsers');
interceptURL('GET', `/api/v1/teams/name/${TEAM_DETAILS.name}?*`,'getSelectedTeam')
//Click on created team
cy.get(`[data-row-key="${TEAM_DETAILS.name}"]`)
@ -87,10 +87,7 @@ describe('Teams flow should work properly', () => {
cy.wait("@getSelectedTeam").then(() =>{
cy.get('[data-testid="team-heading"]')
.should('be.visible')
.within(() => {
cy.contains(TEAM_DETAILS.name).should('be.visible');
})
.should('be.visible').and('contain', TEAM_DETAILS.name)
});
verifyResponseStatusCode('@getUsers', 200);
//Clicking on users tab

View File

@ -1385,10 +1385,10 @@ const TeamDetailsV1 = ({
closable={false}
confirmLoading={isModalLoading}
okText={t('label.confirm')}
open={!isUndefined(selectedEntity.record)}
title={`${t('label.remove-entity', {
entity: getEntityName(selectedEntity?.record),
})} ${t('label.from-lowercase')} ${getEntityName(currentTeam)}`}
visible={!isUndefined(selectedEntity.record)}
onCancel={() => setEntity(undefined)}
onOk={async () => {
await handleAttributeDelete(
@ -1398,10 +1398,10 @@ const TeamDetailsV1 = ({
setEntity(undefined);
}}>
<Typography.Text>
{t('message.sure-to-remove')}{' '}
{`${getEntityName(
selectedEntity.record
)} t('label.from-lowercase') ${getEntityName(currentTeam)}?`}
{t('message.are-you-sure-you-want-to-remove-child-from-parent', {
child: getEntityName(selectedEntity.record),
parent: getEntityName(currentTeam),
})}
</Typography.Text>
</Modal>
)}

View File

@ -521,6 +521,7 @@
"are-you-sure-delete-tag": "Are you sure you want to delete the {{type}} \"{{tagName}}\"?",
"are-you-sure-to-revoke-access": "Are you sure you want to revoke access for JWT token?",
"are-you-sure-want-to-text": "Are you sure you want to {{text}}",
"are-you-sure-you-want-to-remove-child-from-parent": "Are you sure you want to remove the {{child}} from {{parent}}?",
"are-you-want-to-restore": "Are you sure you want to restore",
"assess-data-reliability-with-data-profiler-lineage": "Assess data reliability with data profiler, lineage, sample data, and more",
"assigned-you-a-new-task-lowercase": "assigned you a new task",

View File

@ -542,19 +542,20 @@ const PoliciesDetailPage = () => {
closable={false}
confirmLoading={isloadingOnSave}
okText={t('label.confirm')}
open={!isUndefined(selectedEntity.record)}
title={`${t('label.remove-entity', {
entity: getEntityName(selectedEntity.record),
})} ${t('label.from-lowercase')} ${getEntityName(policy)}`}
visible={!isUndefined(selectedEntity.record)}
onCancel={() => setEntity(undefined)}
onOk={async () => {
await handleDelete(selectedEntity.record, selectedEntity.attribute);
setEntity(undefined);
}}>
<Typography.Text>
{` ${t('message.sure-to-remove')} ${getEntityName(
selectedEntity.record
)} ${t('label.from-lowercase')} ${getEntityName(policy)}?`}
{t('message.are-you-sure-you-want-to-remove-child-from-parent', {
child: getEntityName(selectedEntity.record),
parent: getEntityName(policy),
})}
</Typography.Text>
</Modal>
)}

View File

@ -357,20 +357,20 @@ const RolesDetailPage = () => {
closable={false}
confirmLoading={isLoadingOnSave}
okText={t('label.confirm')}
open={!isUndefined(selectedEntity.record)}
title={`${t('label.remove-entity', {
entity: getEntityName(selectedEntity.record),
})} ${t('label.from-lowercase')} ${getEntityName(role)}`}
visible={!isUndefined(selectedEntity.record)}
onCancel={() => setEntity(undefined)}
onOk={async () => {
await handleDelete(selectedEntity.record, selectedEntity.attribute);
setEntity(undefined);
}}>
<Typography.Text>
{t('message.sure-to-remove')}{' '}
{`${getEntityName(selectedEntity.record)} ${t(
'label.from-lowercase'
)} ${getEntityName(role)}?`}
{t('message.are-you-sure-you-want-to-remove-child-from-parent', {
child: getEntityName(selectedEntity.record),
parent: getEntityName(role),
})}
</Typography.Text>
</Modal>
)}