yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-01 19:18:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: update settings tab with proper values (#18453)

Browse Source 
* fix: update settings tab with proper values

* address feedback comment
This commit is contained in:
Kenil Shah 2024-10-29 15:15:05 +05:30 committed by Pere Miquel Brull
parent 7b5b5eab60
commit eb6a959886
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openmetadata-ui/src/main/resources/ui/src/pages/GlobalSettingPage/GlobalSettingPage.tsx
View File

@ -13,7 +13,7 @@
import { Col, Row } from 'antd';
import { isEmpty, isUndefined } from 'lodash';
import React, { useCallback, useEffect, useMemo, useState } from 'react';
import React, { useCallback, useMemo } from 'react';
import { useTranslation } from 'react-i18next';
import { useHistory } from 'react-router-dom';
import ErrorPlaceHolder from '../../components/common/ErrorWithPlaceholder/ErrorPlaceHolder';
@ -41,8 +41,6 @@ const GlobalSettingPage = () => {
const { isAdminUser } = useAuth();
const { loading } = useApplicationsProvider();
const [settings, setSettings] = useState<SettingMenuItem[]>([]);
const settingItems = useMemo(
() =>
globalSettingsClassBase
@ -67,10 +65,6 @@ const GlobalSettingPage = () => {
history.push(getSettingPath(category));
}, []);
useEffect(() => {
setSettings(settingItems);
}, []);
if (isEmpty(settingItems)) {
return <ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />;
}
@ -84,7 +78,7 @@ const GlobalSettingPage = () => {
<Col span={24}>
<Row gutter={[20, 20]}>
{settings.map((setting) => (
{settingItems.map((setting) => (
<Col key={setting?.key} span={6}>
<SettingItemCard
data={setting}