fix(ui): autocomplete off for password fields (#11070)

This commit is contained in:
Chirag Madlani 2023-04-20 14:02:53 +05:30 committed by GitHub
parent 3f0a9090e2
commit eb7ab3054f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 37 additions and 2 deletions

View File

@ -85,6 +85,7 @@ const AuthMechanism: FC<Props> = ({
<Space className="w-full tw-justify-between ant-space-authMechanism">
<Input.Password
readOnly
autoComplete="off"
data-testid="token"
placeholder="Generate new token..."
value={JWTToken}
@ -158,6 +159,7 @@ const AuthMechanism: FC<Props> = ({
<Space className="w-full tw-justify-between ant-space-authMechanism">
<Input.Password
readOnly
autoComplete="off"
data-testid="secretKey"
value={authConfig?.secretKey}
/>
@ -171,6 +173,7 @@ const AuthMechanism: FC<Props> = ({
<Space className="w-full tw-justify-between ant-space-authMechanism">
<Input.Password
readOnly
autoComplete="off"
data-testid="privateKey"
value={authConfig?.privateKey}
/>
@ -184,6 +187,7 @@ const AuthMechanism: FC<Props> = ({
<Space className="w-full tw-justify-between ant-space-authMechanism">
<Input.Password
readOnly
autoComplete="off"
data-testid="clientSecret"
value={authConfig?.clientSecret}
/>

View File

@ -238,6 +238,7 @@ const AuthMechanismForm: FC<Props> = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="secretKey"
name="secretKey"
placeholder={t('label.secret-key')}
@ -273,6 +274,7 @@ const AuthMechanismForm: FC<Props> = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="secretKey"
name="secretKey"
placeholder={t('label.secret-key')}
@ -334,6 +336,7 @@ const AuthMechanismForm: FC<Props> = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="clientSecret"
name="clientSecret"
placeholder={t('label.client-secret')}
@ -416,6 +419,7 @@ const AuthMechanismForm: FC<Props> = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="privateKey"
name="privateKey"
placeholder={t('label.privateKey')}
@ -508,6 +512,7 @@ const AuthMechanismForm: FC<Props> = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="secretKey"
name="secretKey"
placeholder={t('label.secret-key')}

View File

@ -369,6 +369,7 @@ const CreateUser = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="secretKey"
name="secretKey"
placeholder={t('label.secret-key')}
@ -404,6 +405,7 @@ const CreateUser = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="secretKey"
name="secretKey"
placeholder={t('label.secret-key')}
@ -467,6 +469,7 @@ const CreateUser = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="clientSecret"
name="clientSecret"
placeholder={t('label.client-secret')}
@ -547,6 +550,7 @@ const CreateUser = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="privateKey"
name="privateKey"
placeholder={t('label.private-key')}
@ -639,6 +643,7 @@ const CreateUser = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="secretKey"
name="secretKey"
placeholder={t('label.secret-key')}
@ -868,6 +873,7 @@ const CreateUser = ({
},
]}>
<Input.Password
autoComplete="off"
name="password"
placeholder={t('label.password-type', {
type: t('label.enter'),
@ -896,6 +902,7 @@ const CreateUser = ({
},
]}>
<Input.Password
autoComplete="off"
name="confirmPassword"
placeholder={t('label.password-type', {
type: t('label.confirm'),
@ -943,6 +950,7 @@ const CreateUser = ({
</div>
</div>
}
autoComplete="off"
name="generatedPassword"
value={generatedPassword}
/>

View File

@ -76,6 +76,7 @@ const ChangePasswordForm: React.FC<ChangePasswordForm> = ({
},
]}>
<Input.Password
autoComplete="off"
data-testid="name"
placeholder={t('label.enter-type-password', {
type: t('label.old'),
@ -96,6 +97,7 @@ const ChangePasswordForm: React.FC<ChangePasswordForm> = ({
},
]}>
<Input.Password
autoComplete="off"
placeholder={t('label.enter-type-password', {
type: t('label.new'),
})}
@ -115,7 +117,10 @@ const ChangePasswordForm: React.FC<ChangePasswordForm> = ({
},
},
]}>
<Input.Password placeholder={t('label.confirm-new-password')} />
<Input.Password
autoComplete="off"
placeholder={t('label.confirm-new-password')}
/>
</Form.Item>
</Form>
</Modal>

View File

@ -123,6 +123,7 @@ export const DBTCloudConfig: FunctionComponent<Props> = ({
{t('label.dbt-cloud-account-auth-token')}
</p>
<Input.Password
autoComplete="off"
className="tw-form-inputs tw-form-inputs-padding"
data-testid="cloud-auth-token"
id="cloud-auth-token"

View File

@ -188,6 +188,7 @@ export const DBTGCSConfig: FunctionComponent<Props> = ({
{t('label.google-cloud-private-key-id')}
</p>
<Input.Password
autoComplete="off"
className="tw-form-inputs tw-form-inputs-padding"
data-testid="private-key-id"
id="private-key-id"
@ -209,6 +210,7 @@ export const DBTGCSConfig: FunctionComponent<Props> = ({
{t('label.google-cloud-private-key')}
</p>
<Input.Password
autoComplete="off"
className="tw-form-inputs tw-form-inputs-padding"
data-testid="private-key"
id="private-key"

View File

@ -119,6 +119,7 @@ export const DBTS3Config: FunctionComponent<Props> = ({
{`${t('label.aws-access-key-id')}.`}
</p>
<Input.Password
autoComplete="off"
className="tw-form-inputs tw-form-inputs-padding"
data-testid="aws-access-key-id"
id="aws-access-key-id"
@ -138,6 +139,7 @@ export const DBTS3Config: FunctionComponent<Props> = ({
</p>
<Input.Password
autoComplete="off"
className="tw-form-inputs tw-form-inputs-padding"
data-testid="aws-secret-access-key-id"
id="aws-secret-access-key-id"
@ -174,6 +176,7 @@ export const DBTS3Config: FunctionComponent<Props> = ({
{`${t('label.aws-session-token')}.`}
</p>
<Input.Password
autoComplete="off"
className="tw-form-inputs tw-form-inputs-padding"
data-testid="aws-session-token"
id="aws-session-token"

View File

@ -260,7 +260,10 @@ const SigninPage = () => {
name="password"
requiredMark={false}
rules={[{ required: true }]}>
<Input.Password placeholder={t('label.password')} />
<Input.Password
autoComplete="off"
placeholder={t('label.password')}
/>
</Form.Item>
<Button

View File

@ -129,6 +129,7 @@ const ResetPassword = () => {
},
]}>
<Input.Password
autoComplete="off"
className="w-full"
placeholder={t('label.enter-entity', {
entity: t('label.new-password'),
@ -156,6 +157,7 @@ const ResetPassword = () => {
},
]}>
<Input.Password
autoComplete="off"
className="w-full"
placeholder={t('label.re-enter-new-password')}
/>

View File

@ -135,6 +135,7 @@ const BasicSignUp = () => {
},
]}>
<Input.Password
autoComplete="off"
placeholder={t('label.enter-entity', {
entity: t('label.password-lowercase'),
})}
@ -164,6 +165,7 @@ const BasicSignUp = () => {
},
]}>
<Input.Password
autoComplete="off"
placeholder={t('label.confirm-password')}
/>
</Form.Item>