From eb7ab3054ff4fc348d15e14a9a81b7fb0ca85126 Mon Sep 17 00:00:00 2001
From: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Date: Thu, 20 Apr 2023 14:02:53 +0530
Subject: [PATCH] fix(ui): autocomplete off for password fields (#11070)

---
 .../ui/src/components/BotDetails/AuthMechanism.tsx        | 4 ++++
 .../ui/src/components/BotDetails/AuthMechanismForm.tsx    | 5 +++++
 .../ui/src/components/CreateUser/CreateUser.component.tsx | 8 ++++++++
 .../ui/src/components/Users/ChangePasswordForm.tsx        | 7 ++++++-
 .../common/DBTConfigFormBuilder/DBTCloudConfig.tsx        | 1 +
 .../common/DBTConfigFormBuilder/DBTGCSConfig.tsx          | 2 ++
 .../common/DBTConfigFormBuilder/DBTS3Config.tsx           | 3 +++
 .../src/main/resources/ui/src/pages/login/index.tsx       | 5 ++++-
 .../src/pages/reset-password/reset-password.component.tsx | 2 ++
 .../ui/src/pages/signup/basic-signup.component.tsx        | 2 ++
 10 files changed, 37 insertions(+), 2 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanism.tsx b/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanism.tsx
index 8886d68c2b0..7ae4c4d6045 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanism.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanism.tsx
@@ -85,6 +85,7 @@ const AuthMechanism: FC<Props> = ({
             <Space className="w-full tw-justify-between ant-space-authMechanism">
               <Input.Password
                 readOnly
+                autoComplete="off"
                 data-testid="token"
                 placeholder="Generate new token..."
                 value={JWTToken}
@@ -158,6 +159,7 @@ const AuthMechanism: FC<Props> = ({
               <Space className="w-full tw-justify-between ant-space-authMechanism">
                 <Input.Password
                   readOnly
+                  autoComplete="off"
                   data-testid="secretKey"
                   value={authConfig?.secretKey}
                 />
@@ -171,6 +173,7 @@ const AuthMechanism: FC<Props> = ({
               <Space className="w-full tw-justify-between ant-space-authMechanism">
                 <Input.Password
                   readOnly
+                  autoComplete="off"
                   data-testid="privateKey"
                   value={authConfig?.privateKey}
                 />
@@ -184,6 +187,7 @@ const AuthMechanism: FC<Props> = ({
               <Space className="w-full tw-justify-between ant-space-authMechanism">
                 <Input.Password
                   readOnly
+                  autoComplete="off"
                   data-testid="clientSecret"
                   value={authConfig?.clientSecret}
                 />
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanismForm.tsx b/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanismForm.tsx
index ad3b953513c..dad8ebce56f 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanismForm.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/BotDetails/AuthMechanismForm.tsx
@@ -238,6 +238,7 @@ const AuthMechanismForm: FC<Props> = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="secretKey"
                 name="secretKey"
                 placeholder={t('label.secret-key')}
@@ -273,6 +274,7 @@ const AuthMechanismForm: FC<Props> = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="secretKey"
                 name="secretKey"
                 placeholder={t('label.secret-key')}
@@ -334,6 +336,7 @@ const AuthMechanismForm: FC<Props> = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="clientSecret"
                 name="clientSecret"
                 placeholder={t('label.client-secret')}
@@ -416,6 +419,7 @@ const AuthMechanismForm: FC<Props> = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="privateKey"
                 name="privateKey"
                 placeholder={t('label.privateKey')}
@@ -508,6 +512,7 @@ const AuthMechanismForm: FC<Props> = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="secretKey"
                 name="secretKey"
                 placeholder={t('label.secret-key')}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/CreateUser/CreateUser.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/CreateUser/CreateUser.component.tsx
index 70dd8677129..a56d4c70e9c 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/CreateUser/CreateUser.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/CreateUser/CreateUser.component.tsx
@@ -369,6 +369,7 @@ const CreateUser = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="secretKey"
                 name="secretKey"
                 placeholder={t('label.secret-key')}
@@ -404,6 +405,7 @@ const CreateUser = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="secretKey"
                 name="secretKey"
                 placeholder={t('label.secret-key')}
@@ -467,6 +469,7 @@ const CreateUser = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="clientSecret"
                 name="clientSecret"
                 placeholder={t('label.client-secret')}
@@ -547,6 +550,7 @@ const CreateUser = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="privateKey"
                 name="privateKey"
                 placeholder={t('label.private-key')}
@@ -639,6 +643,7 @@ const CreateUser = ({
                 },
               ]}>
               <Input.Password
+                autoComplete="off"
                 data-testid="secretKey"
                 name="secretKey"
                 placeholder={t('label.secret-key')}
@@ -868,6 +873,7 @@ const CreateUser = ({
                           },
                         ]}>
                         <Input.Password
+                          autoComplete="off"
                           name="password"
                           placeholder={t('label.password-type', {
                             type: t('label.enter'),
@@ -896,6 +902,7 @@ const CreateUser = ({
                           },
                         ]}>
                         <Input.Password
+                          autoComplete="off"
                           name="confirmPassword"
                           placeholder={t('label.password-type', {
                             type: t('label.confirm'),
@@ -943,6 +950,7 @@ const CreateUser = ({
                               </div>
                             </div>
                           }
+                          autoComplete="off"
                           name="generatedPassword"
                           value={generatedPassword}
                         />
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Users/ChangePasswordForm.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Users/ChangePasswordForm.tsx
index a7c1692b7b3..a9ab8c42d42 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Users/ChangePasswordForm.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Users/ChangePasswordForm.tsx
@@ -76,6 +76,7 @@ const ChangePasswordForm: React.FC<ChangePasswordForm> = ({
               },
             ]}>
             <Input.Password
+              autoComplete="off"
               data-testid="name"
               placeholder={t('label.enter-type-password', {
                 type: t('label.old'),
@@ -96,6 +97,7 @@ const ChangePasswordForm: React.FC<ChangePasswordForm> = ({
             },
           ]}>
           <Input.Password
+            autoComplete="off"
             placeholder={t('label.enter-type-password', {
               type: t('label.new'),
             })}
@@ -115,7 +117,10 @@ const ChangePasswordForm: React.FC<ChangePasswordForm> = ({
               },
             },
           ]}>
-          <Input.Password placeholder={t('label.confirm-new-password')} />
+          <Input.Password
+            autoComplete="off"
+            placeholder={t('label.confirm-new-password')}
+          />
         </Form.Item>
       </Form>
     </Modal>
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTCloudConfig.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTCloudConfig.tsx
index d5a84b0b5c9..d3c7b6659d6 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTCloudConfig.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTCloudConfig.tsx
@@ -123,6 +123,7 @@ export const DBTCloudConfig: FunctionComponent<Props> = ({
           {t('label.dbt-cloud-account-auth-token')}
         </p>
         <Input.Password
+          autoComplete="off"
           className="tw-form-inputs tw-form-inputs-padding"
           data-testid="cloud-auth-token"
           id="cloud-auth-token"
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTGCSConfig.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTGCSConfig.tsx
index f9b83e4eb8d..8193e28564a 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTGCSConfig.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTGCSConfig.tsx
@@ -188,6 +188,7 @@ export const DBTGCSConfig: FunctionComponent<Props> = ({
             {t('label.google-cloud-private-key-id')}
           </p>
           <Input.Password
+            autoComplete="off"
             className="tw-form-inputs tw-form-inputs-padding"
             data-testid="private-key-id"
             id="private-key-id"
@@ -209,6 +210,7 @@ export const DBTGCSConfig: FunctionComponent<Props> = ({
             {t('label.google-cloud-private-key')}
           </p>
           <Input.Password
+            autoComplete="off"
             className="tw-form-inputs tw-form-inputs-padding"
             data-testid="private-key"
             id="private-key"
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTS3Config.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTS3Config.tsx
index 9c736faf5f5..2cb48ad7fbc 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTS3Config.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/DBTConfigFormBuilder/DBTS3Config.tsx
@@ -119,6 +119,7 @@ export const DBTS3Config: FunctionComponent<Props> = ({
           {`${t('label.aws-access-key-id')}.`}
         </p>
         <Input.Password
+          autoComplete="off"
           className="tw-form-inputs tw-form-inputs-padding"
           data-testid="aws-access-key-id"
           id="aws-access-key-id"
@@ -138,6 +139,7 @@ export const DBTS3Config: FunctionComponent<Props> = ({
         </p>
 
         <Input.Password
+          autoComplete="off"
           className="tw-form-inputs tw-form-inputs-padding"
           data-testid="aws-secret-access-key-id"
           id="aws-secret-access-key-id"
@@ -174,6 +176,7 @@ export const DBTS3Config: FunctionComponent<Props> = ({
           {`${t('label.aws-session-token')}.`}
         </p>
         <Input.Password
+          autoComplete="off"
           className="tw-form-inputs tw-form-inputs-padding"
           data-testid="aws-session-token"
           id="aws-session-token"
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/login/index.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/login/index.tsx
index f2900e3a999..38635810e6a 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/login/index.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/login/index.tsx
@@ -260,7 +260,10 @@ const SigninPage = () => {
                     name="password"
                     requiredMark={false}
                     rules={[{ required: true }]}>
-                    <Input.Password placeholder={t('label.password')} />
+                    <Input.Password
+                      autoComplete="off"
+                      placeholder={t('label.password')}
+                    />
                   </Form.Item>
 
                   <Button
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/reset-password/reset-password.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/reset-password/reset-password.component.tsx
index f0f3b3bd135..e9cad97abcd 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/reset-password/reset-password.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/reset-password/reset-password.component.tsx
@@ -129,6 +129,7 @@ const ResetPassword = () => {
                     },
                   ]}>
                   <Input.Password
+                    autoComplete="off"
                     className="w-full"
                     placeholder={t('label.enter-entity', {
                       entity: t('label.new-password'),
@@ -156,6 +157,7 @@ const ResetPassword = () => {
                     },
                   ]}>
                   <Input.Password
+                    autoComplete="off"
                     className="w-full"
                     placeholder={t('label.re-enter-new-password')}
                   />
diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/signup/basic-signup.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/signup/basic-signup.component.tsx
index 9bf3c029bec..691e5c1eddb 100644
--- a/openmetadata-ui/src/main/resources/ui/src/pages/signup/basic-signup.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/pages/signup/basic-signup.component.tsx
@@ -135,6 +135,7 @@ const BasicSignUp = () => {
                             },
                           ]}>
                           <Input.Password
+                            autoComplete="off"
                             placeholder={t('label.enter-entity', {
                               entity: t('label.password-lowercase'),
                             })}
@@ -164,6 +165,7 @@ const BasicSignUp = () => {
                             },
                           ]}>
                           <Input.Password
+                            autoComplete="off"
                             placeholder={t('label.confirm-password')}
                           />
                         </Form.Item>