yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-12 00:41:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): supported announcement in pending entities (#13414)

Browse Source 
* supported announcement in pending entities

* added announcement support in database, database schema and entity services
This commit is contained in:
Ashish Gupta 2023-10-04 17:05:14 +05:30 committed by GitHub
parent 5a3d759b48
commit eb89d789bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/FeedCardHeader/FeedCardHeader.tsx
View File

@ -114,6 +114,7 @@ const FeedCardHeader: FC<FeedHeaderProp> = ({
{t('message.made-announcement-for-entity', { entity: entityType })}{' '} {t('message.made-announcement-for-entity', { entity: entityType })}{' '}
<EntityPopOverCard entityFQN={entityFQN} entityType={entityType}> <EntityPopOverCard entityFQN={entityFQN} entityType={entityType}>
<Link <Link
className="break-all"
data-testid="entitylink" data-testid="entitylink"
to={prepareFeedLink(entityType, entityFQN)}> to={prepareFeedLink(entityType, entityFQN)}>
{entityDisplayName(entityType, entityFQN)} {entityDisplayName(entityType, entityFQN)}

6
openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx
View File

@ -254,9 +254,11 @@ export const DataAssetsHeader = ({
}; };
useEffect(() => { useEffect(() => {
if (dataAsset.fullyQualifiedName && !isTourPage && !excludeEntityService) { if (dataAsset.fullyQualifiedName && !isTourPage) {
fetchActiveAnnouncement(); fetchActiveAnnouncement();
fetchTaskCount(); if (!excludeEntityService) {
fetchTaskCount();
}
} }
if (entityType === EntityType.CONTAINER) { if (entityType === EntityType.CONTAINER) {
const asset = dataAsset as Container; const asset = dataAsset as Container;

3
openmetadata-ui/src/main/resources/ui/src/components/common/entityPageInfo/AnnouncementDrawer/AnnouncementDrawer.tsx
View File

@ -60,10 +60,11 @@ const AnnouncementDrawer: FC<Props> = ({
const title = ( const title = (
<Space <Space
align="start"
className="justify-between" className="justify-between"
data-testid="title" data-testid="title"
style={{ width: '100%' }}> style={{ width: '100%' }}>
<Typography.Text className="font-medium"> <Typography.Text className="font-medium break-all">
{t('label.announcement-on-entity', { entity: entityName })} {t('label.announcement-on-entity', { entity: entityName })}
</Typography.Text> </Typography.Text>
<CloseOutlined onClick={onClose} /> <CloseOutlined onClick={onClose} />

13
openmetadata-ui/src/main/resources/ui/src/utils/AnnouncementsUtils.ts
View File

@ -19,7 +19,20 @@ export const ANNOUNCEMENT_ENTITIES = [
EntityType.TOPIC, EntityType.TOPIC,
EntityType.PIPELINE, EntityType.PIPELINE,
EntityType.MLMODEL, EntityType.MLMODEL,
EntityType.CONTAINER,
EntityType.DASHBOARD_DATA_MODEL,
EntityType.STORED_PROCEDURE,
EntityType.SEARCH_INDEX, EntityType.SEARCH_INDEX,
EntityType.DATABASE,
EntityType.DATABASE_SCHEMA,
EntityType.DATABASE_SERVICE,
EntityType.MESSAGING_SERVICE,
EntityType.DASHBOARD_SERVICE,
EntityType.PIPELINE_SERVICE,
EntityType.MLMODEL_SERVICE,
EntityType.STORAGE_SERVICE,
EntityType.METADATA_SERVICE,
EntityType.SEARCH_SERVICE,
]; ];
export const isActiveAnnouncement = (startTime: number, endTime: number) => { export const isActiveAnnouncement = (startTime: number, endTime: number) => {

4
openmetadata-ui/src/main/resources/ui/src/utils/FeedUtils.tsx
View File

@ -570,6 +570,10 @@ export const entityDisplayName = (entityType: string, entityFQN: string) => {
EntityType.DASHBOARD_SERVICE, EntityType.DASHBOARD_SERVICE,
EntityType.MESSAGING_SERVICE, EntityType.MESSAGING_SERVICE,
EntityType.PIPELINE_SERVICE, EntityType.PIPELINE_SERVICE,
EntityType.MLMODEL_SERVICE,
EntityType.METADATA_SERVICE,
EntityType.STORAGE_SERVICE,
EntityType.SEARCH_SERVICE,
EntityType.TYPE, EntityType.TYPE,
EntityType.MLMODEL, EntityType.MLMODEL,
].includes(entityType as EntityType) ].includes(entityType as EntityType)

4
openmetadata-ui/src/main/resources/ui/src/utils/TableUtils.tsx
View File

@ -242,6 +242,10 @@ export const getEntityLink = (
case EntityType.DASHBOARD_SERVICE: case EntityType.DASHBOARD_SERVICE:
case EntityType.MESSAGING_SERVICE: case EntityType.MESSAGING_SERVICE:
case EntityType.PIPELINE_SERVICE: case EntityType.PIPELINE_SERVICE:
case EntityType.MLMODEL_SERVICE:
case EntityType.METADATA_SERVICE:
case EntityType.STORAGE_SERVICE:
case EntityType.SEARCH_SERVICE:
return getServiceDetailsPath(fullyQualifiedName, `${indexType}s`); return getServiceDetailsPath(fullyQualifiedName, `${indexType}s`);
case EntityType.WEBHOOK: case EntityType.WEBHOOK: