From ebc0c320c0bd5e96c12efaa2b0e650846fde1880 Mon Sep 17 00:00:00 2001
From: parthp2107 <83201188+parthp2107@users.noreply.github.com>
Date: Mon, 8 Nov 2021 22:20:36 +0530
Subject: [PATCH] added frequently joined tables and columns tests (#1104)

* added frequently joined tables and columns tests

* addressing reviewdog findings
---
 .../EntityTable/EntityTable.component.tsx     |  4 ++-
 .../FrequentlyJoinedTables.component.tsx      |  1 +
 .../tableDetails/TableDetailsPageTest.java    | 32 +++++++++++++++++++
 3 files changed, 36 insertions(+), 1 deletion(-)

diff --git a/catalog-rest-service/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx b/catalog-rest-service/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx
index fe1c8f38ebd..3462d85b25c 100644
--- a/catalog-rest-service/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx
+++ b/catalog-rest-service/src/main/resources/ui/src/components/EntityTable/EntityTable.component.tsx
@@ -562,7 +562,9 @@ const EntityTable = ({
                             ) : null}
                           </div>
                           {checkIfJoinsAvailable(row.original.name) && (
-                            <div className="tw-mt-3">
+                            <div
+                              className="tw-mt-3"
+                              data-testid="frequently-joined-columns">
                               <span className="tw-text-grey-muted tw-mr-1">
                                 Frequently joined columns:
                               </span>
diff --git a/catalog-rest-service/src/main/resources/ui/src/components/FrequentlyJoinedTables/FrequentlyJoinedTables.component.tsx b/catalog-rest-service/src/main/resources/ui/src/components/FrequentlyJoinedTables/FrequentlyJoinedTables.component.tsx
index 74b83d07787..53763d7e2bc 100644
--- a/catalog-rest-service/src/main/resources/ui/src/components/FrequentlyJoinedTables/FrequentlyJoinedTables.component.tsx
+++ b/catalog-rest-service/src/main/resources/ui/src/components/FrequentlyJoinedTables/FrequentlyJoinedTables.component.tsx
@@ -73,6 +73,7 @@ const FrequentlyJoinedTables: FunctionComponent<Props> = ({
             key={index}>
             <span
               className="link-text"
+              data-testid="more-related-tables-data"
               onClick={() =>
                 handleTableClick(table.fullyQualifiedName as string)
               }>
diff --git a/catalog-rest-service/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java b/catalog-rest-service/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java
index f53bad2566b..8f0caa1cddb 100644
--- a/catalog-rest-service/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java
+++ b/catalog-rest-service/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java
@@ -242,6 +242,38 @@ public class TableDetailsPageTest {
         Events.click(webDriver, By.cssSelector("[data-testid='closeDrawer']"));
     }
 
+    @Test
+    @Order(13)
+    public void checkFrequentlyJoinedTables() throws InterruptedException {
+        openExplorePage();
+        webDriver.findElement(By.cssSelector("[data-testid='searchBox']")).sendKeys("fact_sale");
+        Events.click(webDriver, By.cssSelector("[data-testid='data-name']"));
+        for (int i = 1; i<=3; i++) {
+            Events.click(webDriver, By.xpath("(//div[@data-testid='related-tables-data']//a)" + "[" + i + "]"));
+            webDriver.navigate().back();
+            Thread.sleep(waitTime);
+        }
+        for (int i = 1; i<=3; i++) {
+            Events.click(webDriver, By.xpath("(//div[@data-testid='related-tables-data']//div//span)"));
+            Events.click(webDriver, By.xpath("(//span[@data-testid='more-related-tables-data'])" + "[" + i + "]"));
+            webDriver.navigate().back();
+            Thread.sleep(waitTime);
+        }
+    }
+
+    @Test
+    @Order(14)
+    public void checkFrequentlyJoinedColumns() throws InterruptedException {
+        openExplorePage();
+        webDriver.findElement(By.cssSelector("[data-testid='searchBox']")).sendKeys("fact_sale");
+        Events.click(webDriver, By.cssSelector("[data-testid='data-name']"));
+        for (int i = 1; i<=3; i++) {
+            Events.click(webDriver, By.xpath(
+                    "(//div[@data-testid='frequently-joined-columns']//span//a)" + "[" + i + "]"));
+            webDriver.navigate().back();
+        }
+    }
+
     @AfterEach
     public void closeTabs() {
         ArrayList<String> tabs = new ArrayList<>(webDriver.getWindowHandles());