yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-15 13:10:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed wrong field names showing in the validation messages for add and edit announcement modal. (#8564)

Browse Source
This commit is contained in:
Aniket Katkar 2022-11-07 23:07:31 +05:30 committed by GitHub
parent b44972ef60
commit ecee66fce9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openmetadata-ui/src/main/resources/ui/src/components/Modals/AnnouncementModal/AddAnnouncementModal.tsx
View File

@ -114,6 +114,7 @@ const AddAnnouncementModal: FC<Props> = ({
onFinish={handleCreateAnnouncement}> onFinish={handleCreateAnnouncement}>
<Form.Item <Form.Item
label="Title:" label="Title:"
messageVariables={{ fieldName: 'title' }}
name="title" name="title"
rules={[ rules={[
{ {
@ -132,6 +133,7 @@ const AddAnnouncementModal: FC<Props> = ({
<Space className="announcement-date-space" size={16}> <Space className="announcement-date-space" size={16}>
<Form.Item <Form.Item
label={`Start Date: (${getTimeZone()})`} label={`Start Date: (${getTimeZone()})`}
messageVariables={{ fieldName: 'startDate' }}
name="startDate" name="startDate"
rules={[ rules={[
{ {
@ -146,6 +148,7 @@ const AddAnnouncementModal: FC<Props> = ({
</Form.Item> </Form.Item>
<Form.Item <Form.Item
label={`End Date: (${getTimeZone()})`} label={`End Date: (${getTimeZone()})`}
messageVariables={{ fieldName: 'endtDate' }}
name="endtDate" name="endtDate"
rules={[ rules={[
{ {

3
openmetadata-ui/src/main/resources/ui/src/components/Modals/AnnouncementModal/EditAnnouncementModal.tsx
View File

@ -96,6 +96,7 @@ const EditAnnouncementModal: FC<Props> = ({
onFinish={handleConfirm}> onFinish={handleConfirm}>
<Form.Item <Form.Item
label="Title:" label="Title:"
messageVariables={{ fieldName: 'title' }}
name="title" name="title"
rules={[ rules={[
{ {
@ -114,6 +115,7 @@ const EditAnnouncementModal: FC<Props> = ({
<Space className="announcement-date-space" size={16}> <Space className="announcement-date-space" size={16}>
<Form.Item <Form.Item
label={`Start Date: (${getTimeZone()})`} label={`Start Date: (${getTimeZone()})`}
messageVariables={{ fieldName: 'startDate' }}
name="startDate" name="startDate"
rules={[ rules={[
{ {
@ -128,6 +130,7 @@ const EditAnnouncementModal: FC<Props> = ({
</Form.Item> </Form.Item>
<Form.Item <Form.Item
label={`End Date: (${getTimeZone()})`} label={`End Date: (${getTimeZone()})`}
messageVariables={{ fieldName: 'endDate' }}
name="endDate" name="endDate"
rules={[ rules={[
{ {

4
openmetadata-ui/src/main/resources/ui/src/utils/AnnouncementsUtils.ts
View File

@ -9,9 +9,9 @@ export const ANNOUNCEMENT_ENTITIES = [
]; ];
export const validateMessages = { export const validateMessages = {
required: '${name} is required!', required: '${fieldName} is required!',
string: { string: {
range: '${name} must be between ${min} and ${max} character.', range: '${fieldName} must be between ${min} and ${max} character.',
}, },
}; };