yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-26 09:55:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): count vs percentage value shows correctly (#17568)

Browse Source
This commit is contained in:
Chirag Madlani 2024-08-23 18:40:06 +05:30 committed by GitHub
parent bb52bc779e
commit f000be355c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
openmetadata-ui/src/main/resources/ui/src/components/DataInsight/DataInsightChartCard.tsx
View File

@ -510,7 +510,12 @@ export const DataInsightChartCard = ({
label={rightSidePanelLabel} label={rightSidePanelLabel}
progress={round(totalValue, 2)} progress={round(totalValue, 2)}
showProgress={isPercentageGraph} showProgress={isPercentageGraph}
suffix={isPercentageGraph ? '%' : ''} suffix={
isPercentageGraph ||
type === SystemChartType.TotalDataAssetsByTier
? '%'
: ''
}
target={targetValue} target={targetValue}
/> />
</Col> </Col>
@ -538,10 +543,7 @@ export const DataInsightChartCard = ({
activeKeys.length ? activeKeys.includes(entity) : true activeKeys.length ? activeKeys.includes(entity) : true
} }
label={`${round(latestData[entity] ?? 0, 2)}${ label={`${round(latestData[entity] ?? 0, 2)}${
isPercentageGraph && isPercentageGraph ? '%' : ''
type !== SystemChartType.TotalDataAssetsByTier
? '%'
: ''
}`} }`}
pluralize={ pluralize={
![ ![

1
openmetadata-ui/src/main/resources/ui/src/utils/DataInsightUtils.tsx
View File

@ -445,7 +445,6 @@ export const isPercentageSystemGraph = (graph: SystemChartType) => {
SystemChartType.PercentageOfDataAssetWithOwner, SystemChartType.PercentageOfDataAssetWithOwner,
SystemChartType.PercentageOfServiceWithDescription, SystemChartType.PercentageOfServiceWithDescription,
SystemChartType.PercentageOfServiceWithOwner, SystemChartType.PercentageOfServiceWithOwner,
SystemChartType.TotalDataAssetsByTier,
].includes(graph); ].includes(graph);
}; };