yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-30 03:46:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed saphana connection (#16255)

Browse Source
This commit is contained in:
Onkar Ravgan 2024-05-15 11:01:17 +05:30 committed by GitHub
parent 75feb748ec
commit f231e552e1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ingestion/src/metadata/ingestion/source/database/saphana/connection.py
View File

@ -21,10 +21,14 @@ from sqlalchemy.engine import Engine
from metadata.generated.schema.entity.automations.workflow import (
Workflow as AutomationWorkflow,
)
from metadata.generated.schema.entity.services.connections.database.sapHana.sapHanaHDBConnection import (
SapHanaHDBConnection,
)
from metadata.generated.schema.entity.services.connections.database.sapHana.sapHanaSQLConnection import (
SapHanaSQLConnection,
)
from metadata.generated.schema.entity.services.connections.database.sapHanaConnection import (
HdbUserStoreConnection,
SapHanaConnection,
SqlConnection,
)
from metadata.ingestion.connections.builders import (
create_generic_db_connection,
@ -46,7 +50,7 @@ def get_database_connection_url(connection: SapHanaConnection) -> str:
conn = connection.connection
if not isinstance(conn, SqlConnection):
if not isinstance(conn, SapHanaSQLConnection):
raise ValueError("Database Connection requires the SQL connection details")
url = (
@ -75,7 +79,7 @@ def get_hdb_connection_url(connection: SapHanaConnection) -> str:
Build the SQLConnection URL for the database connection
"""
if not isinstance(connection.connection, HdbUserStoreConnection):
if not isinstance(connection.connection, SapHanaHDBConnection):
raise ValueError("Database Connection requires the SQL connection details")
return f"{connection.scheme.value}://userkey={connection.connection.userKey}"
@ -86,14 +90,14 @@ def get_connection(connection: SapHanaConnection) -> Engine:
Create connection
"""
if isinstance(connection.connection, SqlConnection):
if isinstance(connection.connection, SapHanaSQLConnection):
return create_generic_db_connection(
connection=connection,
get_connection_url_fn=get_database_connection_url,
get_connection_args_fn=get_connection_args_common,
)
if isinstance(connection.connection, HdbUserStoreConnection):
if isinstance(connection.connection, SapHanaHDBConnection):
return create_generic_db_connection(
connection=connection,
get_connection_url_fn=get_hdb_connection_url,
@ -128,7 +132,7 @@ def _build_test_fn_dict(
inspector_fn(schema)
break
if isinstance(service_connection.connection, SqlConnection):
if isinstance(service_connection.connection, SapHanaSQLConnection):
return {
"CheckAccess": partial(test_connection_engine_step, engine),
"GetSchemas": partial(execute_inspector_func, engine, "get_schema_names"),
@ -136,7 +140,7 @@ def _build_test_fn_dict(
"GetViews": partial(custom_executor, engine, "get_view_names"),
}
if isinstance(service_connection.connection, HdbUserStoreConnection):
if isinstance(service_connection.connection, SapHanaHDBConnection):
return {
"CheckAccess": partial(test_connection_engine_step, engine),
"GetSchemas": partial(execute_inspector_func, engine, "get_schema_names"),