From f276239688ee9d12d2ec16e7758526349826576e Mon Sep 17 00:00:00 2001 From: Aniket Katkar Date: Wed, 21 Dec 2022 00:40:18 +0530 Subject: [PATCH] UI: Improvements from #9242 (#9434) * Changed custom font size given inside activity feed cards to make it consistent with application * Fixed popovers and date categories overlapping issue * Fixed overlapping and emoticons not visible issue inside comment editor in conversation thread panel * Fixed icons description editor in add team form overflowing out of modal * Fixed search suggestion dropdown overlapping issue --- .../ActivityFeedCard/ActivityFeedCard.tsx | 1 + .../ActivityFeedList/ActivityFeedList.less | 2 +- .../ui/src/components/FeedEditor/FeedEditor.css | 12 ++++++++++-- .../ui/src/components/app-bar/Suggestions.tsx | 2 +- .../common/rich-text-editor/RichTextEditor.css | 12 ------------ .../resources/ui/src/pages/teams/AddTeamForm.tsx | 2 +- .../src/main/resources/ui/src/styles/app.less | 3 +++ 7 files changed, 17 insertions(+), 17 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx index f0e83f008ed..52ade232f6d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedCard/ActivityFeedCard.tsx @@ -194,6 +194,7 @@ const ActivityFeedCard: FC = ({ placement="topRight" trigger="hover" visible={visible && !isEditPost} + zIndex={100} onVisibleChange={handleVisibleChange}> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.less b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.less index 960837f69cb..1e40e76de8e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedList/ActivityFeedList.less @@ -37,7 +37,7 @@ top: 0; margin-left: -8px; margin-right: -8px; - z-index: 10; + z-index: 300; background-color: @filters-container-bg; } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/FeedEditor/FeedEditor.css b/openmetadata-ui/src/main/resources/ui/src/components/FeedEditor/FeedEditor.css index ece15764399..a2b3650e8ef 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/FeedEditor/FeedEditor.css +++ b/openmetadata-ui/src/main/resources/ui/src/components/FeedEditor/FeedEditor.css @@ -1062,7 +1062,15 @@ button.ql-emoji { vertical-align: bottom; } -#tab-panel { +#emoji-palette > #tab-panel { gap: 4px; - margin-top: 8px; + padding-top: 8px; +} + +#emoji-palette { + z-index: 9999; +} + +.ap { + text-indent: 0px; } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/app-bar/Suggestions.tsx b/openmetadata-ui/src/main/resources/ui/src/components/app-bar/Suggestions.tsx index 3699279f14b..3d267db944b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/app-bar/Suggestions.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/app-bar/Suggestions.tsx @@ -318,7 +318,7 @@ const Suggestions = ({ searchText, isOpen, setIsOpen }: SuggestionProp) => {
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/rich-text-editor/RichTextEditor.css b/openmetadata-ui/src/main/resources/ui/src/components/common/rich-text-editor/RichTextEditor.css index f295f0209bc..0e7ea7e1a3f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/rich-text-editor/RichTextEditor.css +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/rich-text-editor/RichTextEditor.css @@ -236,9 +236,6 @@ li.ProseMirror-selectednode:after { position: relative; border: 1px solid #dadde6; height: 100%; - font-family: 'Open Sans', 'Helvetica Neue', 'Helvetica', 'Arial', - '나눔바른고딕', 'Nanum Barun Gothic', '맑은고딕', 'Malgun Gothic', - sans-serif; border-radius: 4px; } @@ -821,9 +818,6 @@ li.ProseMirror-selectednode:after { font-size: 12px; border-radius: 3px; color: #fff; - font-family: 'Open Sans', 'Helvetica Neue', 'Helvetica', 'Arial', - '나눔바른고딕', 'Nanum Barun Gothic', '맑은고딕', 'Malgun Gothic', - sans-serif; } .toastui-editor-tooltip .arrow { @@ -961,9 +955,6 @@ li.ProseMirror-selectednode:after { 40 - tooltip */ .ProseMirror { - font-family: 'Open Sans', 'Helvetica Neue', 'Helvetica', 'Arial', - '나눔바른고딕', 'Nanum Barun Gothic', '맑은고딕', 'Malgun Gothic', - sans-serif; color: #222; font-size: 13px; overflow-y: auto; @@ -997,9 +988,6 @@ table.ProseMirror-selectednode { margin: 0; padding: 0; font-size: 13px; - font-family: 'Open Sans', 'Helvetica Neue', 'Helvetica', 'Arial', - '나눔바른고딕', 'Nanum Barun Gothic', '맑은고딕', 'Malgun Gothic', - sans-serif; z-index: 20; } diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddTeamForm.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddTeamForm.tsx index f43adf87a29..b43717f43ca 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddTeamForm.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/teams/AddTeamForm.tsx @@ -90,7 +90,7 @@ const AddTeamForm: React.FC = ({ }} title={t('label.add-team')} visible={visible} - width={650} + width={750} onCancel={onCancel}>