yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-21 07:28:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #16591 : DBT Glossary Term linking Independent from Tag rule (#16745)

Browse Source
This commit is contained in:
Suman Maharana 2024-06-21 17:36:25 +05:30 committed by GitHub
parent 5bd48fcc34
commit f425d9bf73
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 67 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ingestion/src/metadata/ingestion/source/database/dbt/metadata.py
View File

@ -721,7 +721,7 @@ class DbtSource(DbtServiceSource):
get_tag_labels( get_tag_labels(
metadata=self.metadata, metadata=self.metadata,
tags=dbt_meta_info.openmetadata.glossary, tags=dbt_meta_info.openmetadata.glossary,
include_tags=self.source_config.includeTags, include_tags=True,
tag_type=GlossaryTerm, tag_type=GlossaryTerm,
) )
or [] or []
@ -734,7 +734,7 @@ class DbtSource(DbtServiceSource):
metadata=self.metadata, metadata=self.metadata,
tags=[tier_fqn.split(fqn.FQN_SEPARATOR)[-1]], tags=[tier_fqn.split(fqn.FQN_SEPARATOR)[-1]],
classification_name=tier_fqn.split(fqn.FQN_SEPARATOR)[0], classification_name=tier_fqn.split(fqn.FQN_SEPARATOR)[0],
include_tags=self.source_config.includeTags, include_tags=True,
) )
or [] or []
) )

24
ingestion/tests/unit/resources/datasets/manifest_v8.json
View File

@ -32,7 +32,13 @@
"model_tag_two" "model_tag_two"
], ],
"meta": { "meta": {
"owner": "aaron_johnson0" "owner": "aaron_johnson0",
"openmetadata": {
"glossary": [
"Test_Glossary.term_one",
"Test_Glossary.term_two.nested_term.more_nested_term"
]
}
}, },
"materialized": "table", "materialized": "table",
"incremental_strategy": null, "incremental_strategy": null,
@ -114,7 +120,13 @@
} }
}, },
"meta": { "meta": {
"owner": "aaron_johnson0" "owner": "aaron_johnson0",
"openmetadata": {
"glossary": [
"Test_Glossary.term_one",
"Test_Glossary.term_two.nested_term.more_nested_term"
]
}
}, },
"docs": { "docs": {
"show": true, "show": true,
@ -131,7 +143,13 @@
"model_tag_two" "model_tag_two"
], ],
"meta": { "meta": {
"owner": "aaron_johnson0" "owner": "aaron_johnson0",
"openmetadata": {
"glossary": [
"Test_Glossary.term_one",
"Test_Glossary.term_two.nested_term.more_nested_term"
]
}
} }
}, },
"created_at": 1673981809.96386, "created_at": 1673981809.96386,

44
ingestion/tests/unit/test_dbt.py
View File

@ -251,6 +251,21 @@ MOCK_TAG_LABELS = [
), ),
] ]
MOCK_GLOASSARY_LABELS = [
TagLabel(
tagFQN="Test_Glossary.term_one",
labelType=LabelType.Automated,
state=State.Suggested,
source=TagSource.Glossary,
),
TagLabel(
tagFQN="Test_Glossary.term_two.nested_term.more_nested_term",
labelType=LabelType.Automated,
state=State.Suggested,
source=TagSource.Glossary,
),
]
class DbtUnitTest(TestCase): class DbtUnitTest(TestCase):
""" """
@ -511,3 +526,32 @@ class DbtUnitTest(TestCase):
zip(expected_data_models, data_model_list) zip(expected_data_models, data_model_list)
): ):
self.assertEqual(expected, original) self.assertEqual(expected, original)
@patch("metadata.utils.tag_utils.get_tag_label")
def test_dbt_glossary_tiers(self, get_tag_label):
get_tag_label.side_effect = [
TagLabel(
tagFQN="Test_Glossary.term_one",
labelType=LabelType.Automated.value,
state=State.Suggested.value,
source=TagSource.Glossary.value,
),
TagLabel(
tagFQN="Test_Glossary.term_two.nested_term.more_nested_term",
labelType=LabelType.Automated.value,
state=State.Suggested.value,
source=TagSource.Glossary.value,
),
]
_, dbt_objects = self.get_dbt_object_files(
mock_manifest=MOCK_SAMPLE_MANIFEST_V8
)
manifest_node = dbt_objects.dbt_manifest.nodes.get(
"model.jaffle_shop.customers"
)
dbt_meta_tags = self.dbt_source_obj.process_dbt_meta(
manifest_meta=manifest_node.meta
)
self.assertEqual(dbt_meta_tags, MOCK_GLOASSARY_LABELS)