Add database name filed for oracle db (#11906)

This commit is contained in:
Mayur Singal 2023-06-09 09:31:07 +05:30 committed by GitHub
parent 5404440e41
commit f43aaf4150
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 36 additions and 0 deletions

View File

@ -126,6 +126,12 @@ This is a sample config for Oracle:
{% /codeInfo %} {% /codeInfo %}
{% codeInfo srNumber=32 %}
**databaseName**: Optional name to give to the database in OpenMetadata. If left blank, we will use default as the database name. It is recommended to use the database name same as the SID, This ensures accurate results and proper identification of tables during profiling, data quality checks and dbt workflow.
{% /codeInfo %}
#### Source Configuration - Source Config #### Source Configuration - Source Config
{% codeInfo srNumber=7 %} {% codeInfo srNumber=7 %}
@ -204,6 +210,9 @@ source:
oracleServiceName: serviceName oracleServiceName: serviceName
# databaseSchema: schema # databaseSchema: schema
``` ```
```yaml {% srNumber=32 %}
databaseName: custom_db_display_name
```
```yaml {% srNumber=5 %} ```yaml {% srNumber=5 %}
# connectionOptions: # connectionOptions:
# key: value # key: value

View File

@ -127,6 +127,12 @@ This is a sample config for Oracle:
{% /codeInfo %} {% /codeInfo %}
{% codeInfo srNumber=23 %}
**databaseName**: Optional name to give to the database in OpenMetadata. If left blank, we will use default as the database name. It is recommended to use the database name same as the SID, This ensures accurate results and proper identification of tables during profiling, data quality checks and dbt workflow.
{% /codeInfo %}
#### Source Configuration - Source Config #### Source Configuration - Source Config
{% codeInfo srNumber=7 %} {% codeInfo srNumber=7 %}
@ -205,6 +211,9 @@ source:
oracleServiceName: serviceName oracleServiceName: serviceName
# databaseSchema: schema # databaseSchema: schema
``` ```
```yaml {% srNumber=23 %}
databaseName: custom_db_display_name
```
```yaml {% srNumber=5 %} ```yaml {% srNumber=5 %}
# connectionOptions: # connectionOptions:
# key: value # key: value

View File

@ -205,6 +205,7 @@ desired.
- **Username**: Specify the User to connect to Oracle. It should have enough privileges to read all the metadata. - **Username**: Specify the User to connect to Oracle. It should have enough privileges to read all the metadata.
- **Password**: Password to connect to Oracle. - **Password**: Password to connect to Oracle.
- **Host and Port**: Enter the fully qualified hostname and port number for your Oracle deployment in the Host and Port field. - **Host and Port**: Enter the fully qualified hostname and port number for your Oracle deployment in the Host and Port field.
- **Database Name**: Optional name to give to the database in OpenMetadata. If left blank, we will use default as the database name. It is recommended to use the database name same as the SID, This ensures accurate results and proper identification of tables during profiling, data quality checks and dbt workflow.
- **Oracle Connection Type** : Select the Oracle Connection Type. The type can either be `Oracle Service Name` or `Database Schema` - **Oracle Connection Type** : Select the Oracle Connection Type. The type can either be `Oracle Service Name` or `Database Schema`
- **Oracle Service Name**: The Oracle Service name is the TNS alias that you give when you remotely connect to your database and this Service name is recorded in tnsnames. - **Oracle Service Name**: The Oracle Service name is the TNS alias that you give when you remotely connect to your database and this Service name is recorded in tnsnames.
- **Database Schema**: The name of the database schema available in Oracle that you want to connect with. - **Database Schema**: The name of the database schema available in Oracle that you want to connect with.

View File

@ -91,6 +91,11 @@
"description": "This directory will be used to set the LD_LIBRARY_PATH env variable. It is required if you need to enable thick connection mode. By default, we bring instant client 19 and point to /instantclient.", "description": "This directory will be used to set the LD_LIBRARY_PATH env variable. It is required if you need to enable thick connection mode. By default, we bring instant client 19 and point to /instantclient.",
"default": "/instantclient" "default": "/instantclient"
}, },
"databaseName": {
"title": "Database Name",
"description": "Optional name to give to the database in OpenMetadata. If left blank, we will use default as the database name.",
"type": "string"
},
"connectionOptions": { "connectionOptions": {
"title": "Connection Options", "title": "Connection Options",
"$ref": "../connectionBasicType.json#/definitions/connectionOptions" "$ref": "../connectionBasicType.json#/definitions/connectionOptions"

View File

@ -91,6 +91,18 @@ $$section
This directory will be used to set the `LD_LIBRARY_PATH` env variable. It is required if you need to enable thick connection mode. By default, we bring Instant Client 19 and point to `/instantclient`. This directory will be used to set the `LD_LIBRARY_PATH` env variable. It is required if you need to enable thick connection mode. By default, we bring Instant Client 19 and point to `/instantclient`.
$$ $$
$$section
### Database Name $(id="databaseName")
In OpenMetadata, the Database Service hierarchy works as follows:
```
Database Service > Database > Schema > Table
```
In the case of Oracle, we won't have a Database as such. If you'd like to see your data in a database named something other than `default`, you can specify the name in this field.
**Note:** It is recommended to use the database name same as the SID, This ensures accurate results and proper identification of tables during profiling, data quality checks and dbt workflow.
$$
$$section $$section
### Connection Options $(id="connectionOptions") ### Connection Options $(id="connectionOptions")