yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-17 19:57:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): hide email if not present in the data (#15927)

Browse Source
This commit is contained in:
Chirag Madlani 2024-04-17 15:30:37 +05:30 committed by GitHub
parent 6c44308ba4
commit f4ebfbbfc6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 34 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileDetails/UserProfileDetails.component.tsx
View File

@ -223,19 +223,25 @@ const UserProfileDetails = ({
};
const userEmailRender = useMemo(
() => (
<Space align="center">
<Typography.Text
className="text-grey-muted"
data-testid="user-email-label">{`${t(
'label.email'
)} :`}</Typography.Text>
() =>
userData.email && (
<>
<Space align="center">
<Typography.Text
className="text-grey-muted"
data-testid="user-email-label">{`${t(
'label.email'
)} :`}</Typography.Text>
<Typography.Paragraph className="m-b-0" data-testid="user-email-value">
{userData.email}
</Typography.Paragraph>
</Space>
),
<Typography.Paragraph
className="m-b-0"
data-testid="user-email-value">
{userData.email}
</Typography.Paragraph>
</Space>
<Divider type="vertical" />
</>
),
[userData.email]
);

16
openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UsersProfile/UserProfileDetails/UserProfileDetails.test.tsx
View File

@ -263,4 +263,20 @@ describe('Test User Profile Details Component', () => {
'defaultPersona'
);
});
it('should not render if not present', async () => {
render(
<UserProfileDetails
{...mockPropsData}
userData={{ ...USER_DATA, email: '' }}
/>,
{
wrapper: MemoryRouter,
}
);
// user email
expect(screen.queryByTestId('user-email-label')).not.toBeInTheDocument();
expect(screen.queryByTestId('user-email-value')).not.toBeInTheDocument();
});
});