yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-08-27 02:16:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: unable to create new kpi issue (#10361)

Browse Source 
* updated cypres.config to run searchflow last

* updated cypress config

* fixed kpi creation issue

* reverting cypress change
This commit is contained in:
Shailesh Parmar 2023-02-28 20:12:01 +05:30 committed by GitHub
parent 909cedeca1
commit f4fc1b6438
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/AddKPIPage.tsx
View File

@ -142,7 +142,7 @@ const AddKPIPage = () => {
const handleChartSelect = (value: string) => { const handleChartSelect = (value: string) => {
const selectedChartValue = dataInsightCharts.find( const selectedChartValue = dataInsightCharts.find(
(chart) => chart.id === value (chart) => chart.fullyQualifiedName === value
); );
setSelectedChart(selectedChartValue); setSelectedChart(selectedChartValue);
}; };
@ -191,7 +191,6 @@ const AddKPIPage = () => {
const targetValue = getKpiTargetValueByMetricType(metricType, metricValue); const targetValue = getKpiTargetValueByMetricType(metricType, metricValue);
const formData: CreateKpiRequest = { const formData: CreateKpiRequest = {
// TODO: this needs to be fullyQualifiedName of the dataInsightChart
dataInsightChart: values.dataInsightChart, dataInsightChart: values.dataInsightChart,
description, description,
name: kebabCase(`${values.displayName} ${selectedMetric?.name}`), name: kebabCase(`${values.displayName} ${selectedMetric?.name}`),
@ -256,10 +255,10 @@ const AddKPIPage = () => {
data-testid="dataInsightChart" data-testid="dataInsightChart"
notFoundContent={t('message.all-charts-are-mapped')} notFoundContent={t('message.all-charts-are-mapped')}
placeholder={t('label.select-a-chart')} placeholder={t('label.select-a-chart')}
value={selectedChart?.id} value={selectedChart?.fullyQualifiedName}
onChange={handleChartSelect}> onChange={handleChartSelect}>
{chartOptions.map((chart) => ( {chartOptions.map((chart) => (
<Option key={chart.id}> <Option key={chart.fullyQualifiedName}>
{chart.displayName || chart.name} {chart.displayName || chart.name}
</Option> </Option>
))} ))}