yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-12-13 16:46:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Missing try catch for es-migrate option

Browse Source
This commit is contained in:
mohitdeuex 2023-06-30 11:58:21 +05:30
parent a96b3ab5b4
commit f51781c32d
2 changed files with 28 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
openmetadata-service/src/main/java/org/openmetadata/service/search/SearchClient.java
View File

@ -254,29 +254,33 @@ public interface SearchClient {
@SneakyThrows @SneakyThrows
default void updateElasticSearchFailureStatus(String failedFor, String failureMessage) { default void updateElasticSearchFailureStatus(String failedFor, String failureMessage) {
long updateTime = Date.from(LocalDateTime.now().atZone(ZoneId.systemDefault()).toInstant()).getTime(); try {
String recordString = long updateTime = Date.from(LocalDateTime.now().atZone(ZoneId.systemDefault()).toInstant()).getTime();
getDao() String recordString =
.entityExtensionTimeSeriesDao() getDao()
.getExtension(ELASTIC_SEARCH_ENTITY_FQN_STREAM, ELASTIC_SEARCH_EXTENSION); .entityExtensionTimeSeriesDao()
EventPublisherJob lastRecord = JsonUtils.readValue(recordString, EventPublisherJob.class); .getExtension(ELASTIC_SEARCH_ENTITY_FQN_STREAM, ELASTIC_SEARCH_EXTENSION);
long originalLastUpdate = lastRecord.getTimestamp(); EventPublisherJob lastRecord = JsonUtils.readValue(recordString, EventPublisherJob.class);
lastRecord.setStatus(EventPublisherJob.Status.ACTIVE_WITH_ERROR); long originalLastUpdate = lastRecord.getTimestamp();
lastRecord.setTimestamp(updateTime); lastRecord.setStatus(EventPublisherJob.Status.ACTIVE_WITH_ERROR);
lastRecord.setFailure( lastRecord.setTimestamp(updateTime);
new Failure() lastRecord.setFailure(
.withSinkError( new Failure()
new FailureDetails() .withSinkError(
.withContext(failedFor) new FailureDetails()
.withLastFailedAt(updateTime) .withContext(failedFor)
.withLastFailedReason(failureMessage))); .withLastFailedAt(updateTime)
.withLastFailedReason(failureMessage)));
getDao() getDao()
.entityExtensionTimeSeriesDao() .entityExtensionTimeSeriesDao()
.update( .update(
ELASTIC_SEARCH_ENTITY_FQN_STREAM, ELASTIC_SEARCH_ENTITY_FQN_STREAM,
ELASTIC_SEARCH_EXTENSION, ELASTIC_SEARCH_EXTENSION,
JsonUtils.pojoToJson(lastRecord), JsonUtils.pojoToJson(lastRecord),
originalLastUpdate); originalLastUpdate);
} catch (Exception e) {
// Failure to update
}
} }
} }

1
openmetadata-service/src/main/java/org/openmetadata/service/search/elasticSearch/ElasticSearchClientImpl.java
View File

@ -211,6 +211,7 @@ public class ElasticSearchClientImpl implements SearchClient {
LOG.info("{} Updated {}", elasticSearchIndexType.indexName, putMappingResponse.isAcknowledged()); LOG.info("{} Updated {}", elasticSearchIndexType.indexName, putMappingResponse.isAcknowledged());
} else { } else {
CreateIndexRequest request = new CreateIndexRequest(elasticSearchIndexType.indexName); CreateIndexRequest request = new CreateIndexRequest(elasticSearchIndexType.indexName);
request.source(elasticSearchIndexMapping, XContentType.JSON);
CreateIndexResponse createIndexResponse = client.indices().create(request, RequestOptions.DEFAULT); CreateIndexResponse createIndexResponse = client.indices().create(request, RequestOptions.DEFAULT);
LOG.info("{} Created {}", elasticSearchIndexType.indexName, createIndexResponse.isAcknowledged()); LOG.info("{} Created {}", elasticSearchIndexType.indexName, createIndexResponse.isAcknowledged());
} }