From f6e5de350ce50ba3016f5578d279209a0d56674b Mon Sep 17 00:00:00 2001 From: Ashish Gupta Date: Mon, 12 Feb 2024 11:35:43 +0530 Subject: [PATCH] added unit test for github star (#15134) --- .../GithubStarCard.component.tsx | 16 +-- .../GithubStarCard/GithubStarCard.test.tsx | 130 ++++++++++++++++++ 2 files changed, 138 insertions(+), 8 deletions(-) create mode 100644 openmetadata-ui/src/main/resources/ui/src/components/GithubStarCard/GithubStarCard.test.tsx diff --git a/openmetadata-ui/src/main/resources/ui/src/components/GithubStarCard/GithubStarCard.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/GithubStarCard/GithubStarCard.component.tsx index f5c9aa41f85..eb8f4f05203 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/GithubStarCard/GithubStarCard.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/GithubStarCard/GithubStarCard.component.tsx @@ -43,16 +43,14 @@ const GithubStarCard = () => { const [starredCount, setStarredCount] = useState(0); const [isLoading, setIsLoading] = useState(true); - const loggedInUserName = useMemo(() => currentUser?.name, [currentUser]); - const isWhatNewAlertVisible = useMemo( () => cookieStorage.getItem(COOKIE_VERSION) !== 'true', [cookieStorage] ); const userCookieName = useMemo( - () => `${STAR_OMD_USER}_${loggedInUserName}`, - [loggedInUserName] + () => `${STAR_OMD_USER}_${currentUser?.name}`, + [currentUser?.name] ); const isHomePage = useMemo( @@ -89,12 +87,12 @@ const GithubStarCard = () => { const githubPopup = useCallback( (show: boolean) => { - if (loggedInUserName && show) { + if (currentUser?.name && show) { fetchOpenMetaData(); } setShowGithubStarPopup(show); }, - [loggedInUserName, userCookieName] + [currentUser?.name, userCookieName] ); const updateGithubPopup = useCallback( @@ -136,7 +134,7 @@ const GithubStarCard = () => {