yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-01 13:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: dynamic assertion to create json (#16865)

Browse Source
This commit is contained in:
Teddy 2024-07-01 16:52:09 +02:00 committed by GitHub
parent 65ba2d19ac
commit f766ba872d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseRepository.java
View File

@ -79,7 +79,7 @@ public class TestCaseRepository extends EntityRepository<TestCase> {
private static final String UPDATE_FIELDS = private static final String UPDATE_FIELDS =
"owner,entityLink,testSuite,testSuites,testDefinition"; "owner,entityLink,testSuite,testSuites,testDefinition";
private static final String PATCH_FIELDS = private static final String PATCH_FIELDS =
"owner,entityLink,testSuite,testDefinition,computePassedFailedRowCount"; "owner,entityLink,testSuite,testDefinition,computePassedFailedRowCount,useDynamicAssertion";
public static final String TESTCASE_RESULT_EXTENSION = "testCase.testCaseResult"; public static final String TESTCASE_RESULT_EXTENSION = "testCase.testCaseResult";
public static final String FAILED_ROWS_SAMPLE_EXTENSION = "testCase.failedRowsSample"; public static final String FAILED_ROWS_SAMPLE_EXTENSION = "testCase.failedRowsSample";
@ -972,6 +972,10 @@ public class TestCaseRepository extends EntityRepository<TestCase> {
"computePassedFailedRowCount", "computePassedFailedRowCount",
original.getComputePassedFailedRowCount(), original.getComputePassedFailedRowCount(),
updated.getComputePassedFailedRowCount()); updated.getComputePassedFailedRowCount());
recordChange(
"useDynamicAssertion",
original.getUseDynamicAssertion(),
updated.getUseDynamicAssertion());
recordChange("testCaseResult", original.getTestCaseResult(), updated.getTestCaseResult()); recordChange("testCaseResult", original.getTestCaseResult(), updated.getTestCaseResult());
} }
} }

1
openmetadata-service/src/main/java/org/openmetadata/service/resources/dqtests/TestCaseResource.java
View File

@ -1175,6 +1175,7 @@ public class TestCaseResource extends EntityResource<TestCase, TestCaseRepositor
.withParameterValues(create.getParameterValues()) .withParameterValues(create.getParameterValues())
.withEntityLink(create.getEntityLink()) .withEntityLink(create.getEntityLink())
.withComputePassedFailedRowCount(create.getComputePassedFailedRowCount()) .withComputePassedFailedRowCount(create.getComputePassedFailedRowCount())
.withUseDynamicAssertion(create.getUseDynamicAssertion())
.withEntityFQN(entityLink.getFullyQualifiedFieldValue()) .withEntityFQN(entityLink.getFullyQualifiedFieldValue())
.withTestSuite(getEntityReference(Entity.TEST_SUITE, create.getTestSuite())) .withTestSuite(getEntityReference(Entity.TEST_SUITE, create.getTestSuite()))
.withTestDefinition(getEntityReference(Entity.TEST_DEFINITION, create.getTestDefinition())); .withTestDefinition(getEntityReference(Entity.TEST_DEFINITION, create.getTestDefinition()));

12
openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java
View File

@ -2652,6 +2652,18 @@ public class TestCaseResourceTest extends EntityResourceTest<TestCase, CreateTes
() -> createEntity(request3, ADMIN_AUTH_HEADERS), BAD_REQUEST, "name must match"); () -> createEntity(request3, ADMIN_AUTH_HEADERS), BAD_REQUEST, "name must match");
} }
@Test
void createUpdate_DynamicAssertionTests(TestInfo testInfo) throws IOException {
CreateTestCase create = createRequest(testInfo).withUseDynamicAssertion(true);
TestCase testCase = createAndCheckEntity(create, ADMIN_AUTH_HEADERS);
testCase = getTestCase(testCase.getFullyQualifiedName(), ADMIN_AUTH_HEADERS);
assertTrue(testCase.getUseDynamicAssertion());
CreateTestCase update = create.withUseDynamicAssertion(false);
updateEntity(update, OK, ADMIN_AUTH_HEADERS);
testCase = getTestCase(testCase.getFullyQualifiedName(), ADMIN_AUTH_HEADERS);
assertFalse(testCase.getUseDynamicAssertion());
}
private void putInspectionQuery(TestCase testCase, String sql, Map<String, String> authHeaders) private void putInspectionQuery(TestCase testCase, String sql, Map<String, String> authHeaders)
throws IOException { throws IOException {
TestCase putResponse = putInspectionQuery(testCase.getId(), sql, authHeaders); TestCase putResponse = putInspectionQuery(testCase.getId(), sql, authHeaders);

5
openmetadata-spec/src/main/resources/json/schema/api/tests/createTestCase.json
View File

@ -44,6 +44,11 @@
"description": "Compute the passed and failed row count for the test case.", "description": "Compute the passed and failed row count for the test case.",
"type": "boolean", "type": "boolean",
"default": false "default": false
},
"useDynamicAssertion": {
"description": "If the test definition supports it, use dynamic assertion to evaluate the test case.",
"type": "boolean",
"default": false
} }
}, },
"required": ["name", "testDefinition", "entityLink", "testSuite"], "required": ["name", "testDefinition", "entityLink", "testSuite"],