diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/close-circle-outlined-color.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/close-circle-outlined-color.svg index 79e8c19ae34..1e43fb07f54 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/close-circle-outlined-color.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/close-circle-outlined-color.svg @@ -1,12 +1,22 @@ - - - - - - ionicons-v5-m - - - - - \ No newline at end of file + + + + + + + + + + +ionicons-v5-m + + + + + + + + + + \ No newline at end of file diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx index 8769024a71b..a15a63d6434 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx @@ -514,9 +514,9 @@ export const DataAssetsHeader = ({ {followers} + title={copyTooltip}> - - - - - {sqlQuery && ( - - toggleModal(true)} - /> + + + + + - )} - + + {sqlQuery && ( + + toggleModal(true)} + /> + + )} + + + + + + + ) + } + rightPanelWidth={400}> + + + {!loading ? ( + + ) : ( + + )} - - + + )} - - ) - } - rightPanelWidth={400}> - - - {!loading ? ( - - ) : ( - - )} - - - {searchQueryParam && tabItems.length === 0 && !loading && ( - - - - )} - {searchQueryParam && tabItems.length === 0 && loading && } - + + {searchQueryParam && tabItems.length === 0 && !loading && ( + + + + )} + {searchQueryParam && tabItems.length === 0 && loading && } ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/constants/AdvancedSearch.constants.ts b/openmetadata-ui/src/main/resources/ui/src/constants/AdvancedSearch.constants.ts index f94f2412a65..7d7f170633d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/constants/AdvancedSearch.constants.ts +++ b/openmetadata-ui/src/main/resources/ui/src/constants/AdvancedSearch.constants.ts @@ -44,18 +44,18 @@ export const COMMON_DROPDOWN_ITEMS = [ }, { label: t('label.service'), - key: 'service.name', + key: 'service.name.keyword', }, ]; export const TABLE_DROPDOWN_ITEMS = [ { label: t('label.database'), - key: 'database.name', + key: 'database.name.keyword', }, { label: t('label.schema'), - key: 'databaseSchema.name', + key: 'databaseSchema.name.keyword', }, { label: t('label.column'), diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/TagsPage/TagsPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/TagsPage/TagsPage.tsx index 7338ee45314..3a526072d88 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/TagsPage/TagsPage.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/TagsPage/TagsPage.tsx @@ -1040,9 +1040,7 @@ const TagsPage = () => { {isUpdateLoading ? ( ) : ( -
+
{currentClassification && ( diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/explore/ExplorePageV1.component.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/explore/ExplorePageV1.component.tsx index 0518ae0d64d..e5b720a18e7 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/explore/ExplorePageV1.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/explore/ExplorePageV1.component.tsx @@ -37,7 +37,6 @@ import React, { } from 'react'; import { useHistory, useLocation, useParams } from 'react-router-dom'; import { searchQuery } from 'rest/searchAPI'; -import useDeepCompareEffect from 'use-deep-compare-effect'; import { getCombinedQueryFilterObject, getUpdatedAggregateFieldValue, @@ -51,10 +50,6 @@ import { } from '../../constants/explore.constants'; import { SearchIndex } from '../../enums/search.enum'; import { Aggregations, SearchResponse } from '../../interface/search.interface'; -import { - filterObjectToElasticsearchQuery, - isFilterObject, -} from '../../utils/FilterUtils'; import { showErrorToast } from '../../utils/ToastUtils'; import { QueryFieldInterface, @@ -109,19 +104,6 @@ const ExplorePageV1: FunctionComponent = () => { [location.search] ); - const facetFilters = useMemo( - () => - isFilterObject(parsedSearch.facetFilter) - ? parsedSearch.facetFilter - : undefined, - [parsedSearch.facetFilter] - ); - - const elasticsearchQueryFilter = useMemo( - () => filterObjectToElasticsearchQuery(facetFilters), - [facetFilters] - ); - const handlePageChange: ExploreProps['onChangePage'] = (page, size) => { history.push({ search: Qs.stringify({ ...parsedSearch, page, size: size ?? PAGE_SIZE }), @@ -197,14 +179,6 @@ const ExplorePageV1: FunctionComponent = () => { [history, parsedSearch] ); - const handleFacetFilterChange: ExploreProps['onChangeFacetFilters'] = ( - facetFilter - ) => { - history.push({ - search: Qs.stringify({ ...parsedSearch, facetFilter, page: 1 }), - }); - }; - const handleShowDeletedChange: ExploreProps['onChangeShowDeleted'] = ( showDeleted ) => { @@ -301,11 +275,10 @@ const ExplorePageV1: FunctionComponent = () => { fetchFilterAggregationsWithoutFilters(); }, [searchIndex]); - useDeepCompareEffect(() => { + useEffect(() => { const updatedQuickFilters = getAdvancedSearchQuickFilters(); const combinedQueryFilter = getCombinedQueryFilterObject( - elasticsearchQueryFilter as unknown as QueryFilterInterface, updatedQuickFilters as QueryFilterInterface, queryFilter as unknown as QueryFilterInterface ); @@ -390,7 +363,6 @@ const ExplorePageV1: FunctionComponent = () => { sortValue, sortOrder, showDeleted, - elasticsearchQueryFilter, searchIndex, page, size, @@ -440,7 +412,6 @@ const ExplorePageV1: FunctionComponent = () => { return ( { sortValue={sortValue} tabCounts={searchHitCounts} onChangeAdvancedSearchQuickFilters={handleAdvanceSearchQuickFiltersChange} - onChangeFacetFilters={handleFacetFilterChange} onChangePage={handlePageChange} onChangeSearchIndex={handleSearchIndexChange} onChangeShowDeleted={handleShowDeletedChange} diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/app.less b/openmetadata-ui/src/main/resources/ui/src/styles/app.less index 90f8a409aa6..9ee6f4f992a 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/app.less +++ b/openmetadata-ui/src/main/resources/ui/src/styles/app.less @@ -439,3 +439,7 @@ a[href].link-text-grey, .global-border-radius { border-radius: 10px; } + +.full-height { + height: calc(100vh - 64px); // removing only navbar height +} diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/temp.css b/openmetadata-ui/src/main/resources/ui/src/styles/temp.css index e9091d0b1c5..262a6d8dec4 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/temp.css +++ b/openmetadata-ui/src/main/resources/ui/src/styles/temp.css @@ -828,27 +828,6 @@ body .list-option.rdw-option-active { /* EntityLineage Sidebar CSS */ -.entity-lineage.sidebar { - height: 110%; - background: white; - position: absolute; - top: 0; - left: 0; - width: 100px; - z-index: 200; - overflow-y: auto; - padding: 8px; - transform: translateX(100%); - display: none; - border-right: 1px solid #d9ceee; - transition: transform 0.3s ease-out; -} - -.entity-lineage.sidebar.open { - transform: translateX(0); - display: block; -} - /* login slider */ .login-slider.slick-dots li.slick-active button:before { diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/x-master.css b/openmetadata-ui/src/main/resources/ui/src/styles/x-master.css index 07610eedf90..6e17b2ead3e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/x-master.css +++ b/openmetadata-ui/src/main/resources/ui/src/styles/x-master.css @@ -709,12 +709,6 @@ body .profiler-graph .recharts-active-dot circle { width: calc(100% - 330px); } -/* page-container v1 */ - -.full-height { - height: calc(100vh - 110px); -} - /* 64 header + ( 16 + 16 )spacing Y = 96*/ #left-panel { position: fixed; diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx b/openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx index d962903f605..698a71d9b6d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchUtils.tsx @@ -17,6 +17,7 @@ import ProfilePicture from 'components/common/ProfilePicture/ProfilePicture'; import { SearchDropdownOption } from 'components/SearchDropdown/SearchDropdown.interface'; import i18next from 'i18next'; import { + Bucket, ContainerSearchSource, DashboardSearchSource, ExploreSearchSource, @@ -389,3 +390,15 @@ export const getOptionTextFromKey = ( } } }; + +export const getOptionsFromAggregationBucket = (buckets: Bucket[]) => { + if (!buckets) { + return []; + } + + return buckets.map((option) => ({ + key: option.key, + label: option.key, + count: option.doc_count ?? 0, + })); +};