yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-31 10:39:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes 22418: Fixed the teams page breadcrumb url issue (#23824)

Browse Source 
* Fix: Fixed the teams page breadcrum url issue

* Playwright: Added test for verifing breadcrumb navigation for teams which contains dot in their name
This commit is contained in:
Rohit Jain 2025-10-10 18:36:58 +05:30 committed by GitHub
parent 598de16eea
commit f97ed64316
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Teams.spec.ts
View File

@ -36,10 +36,14 @@ import {
uuid,
visitOwnProfilePage,
} from '../../utils/common';
import { addMultiOwner } from '../../utils/entity';
import {
addMultiOwner,
waitForAllLoadersToDisappear,
} from '../../utils/entity';
import { settingClick } from '../../utils/sidebar';
import {
addEmailTeam,
addTeamHierarchy,
addTeamOwnerToEntity,
addUserInTeam,
addUserTeam,
@ -47,6 +51,7 @@ import {
createTeam,
executionOnOwnerGroupTeam,
executionOnOwnerTeam,
getNewTeamDetails,
hardDeleteTeam,
searchTeam,
softDeleteTeam,
@ -676,6 +681,39 @@ test.describe('Teams Page', () => {
await afterAction();
});
test('Verify breadcrumb navigation for a team with a dot in its name', async ({
page,
}) => {
const team1Details = getNewTeamDetails(`test.department-${uuid()}`);
const team2Details = getNewTeamDetails(`test.team-${uuid()}`);
await settingClick(page, GlobalSettingOptions.TEAMS);
await addTeamHierarchy(page, team1Details, 0);
await page.getByRole('link', { name: team1Details.displayName }).click();
await waitForAllLoadersToDisappear(page);
await addTeamHierarchy(page, team2Details, 1, true);
await page.getByRole('link', { name: team2Details.displayName }).click();
await waitForAllLoadersToDisappear(page);
await expect(page.getByTestId('team-heading')).toContainText(
team2Details.displayName
);
await page.getByRole('link', { name: team1Details.displayName }).click();
await waitForAllLoadersToDisappear(page);
await expect(page.getByTestId('team-heading')).toContainText(
team1Details.displayName
);
await expect(
page.getByTestId('team-hierarchy-table').getByRole('link')
).toContainText(team2Details.displayName);
await hardDeleteTeam(page);
});
});
test.describe('Teams Page with EditUser Permission', () => {

2
openmetadata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/TeamDetailsV1.tsx
View File

@ -447,7 +447,7 @@ const TeamDetailsV1 = ({
? parentTeams.map((parent) => ({
name: getEntityName(parent),
url: getTeamsWithFqnPath(
parent.name ?? parent.fullyQualifiedName ?? ''
parent.fullyQualifiedName ?? parent.name ?? ''
),
}))
: [];